New issue
Advanced search Search tips

Issue 800748 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Drop unused {Load,Store}EnrollmentState from cryptohome

Project Member Reported by tnagel@chromium.org, Jan 10 2018

Issue description

This seems to date back to the time before install attributes.
 

Comment 1 by tnagel@chromium.org, Jan 10 2018

Actually it's an abandoned launch from 2013, cf.  issue 241313 .

Comment 2 by tnagel@chromium.org, Jan 10 2018

Summary: Drop unused {Load,Store}EnrollmentState from cryptohome (was: Drop unused {Load,Store]EnrollmentState from cryptohome)
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/system_api/+/0511461621b848ff3963345e21a52fd0b4e69d38

commit 0511461621b848ff3963345e21a52fd0b4e69d38
Author: Thiemo Nagel <tnagel@chromium.org>
Date: Fri Jan 19 01:40:03 2018

system_api: Drop unused *EnrollmentState

BUG= chromium:800748 
TEST=both Chrome and cryptohomed still compile

Change-Id: I365ed096571e515fa0767ec2936b2c4081289f43
Reviewed-on: https://chromium-review.googlesource.com/859766
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Thiemo Nagel <tnagel@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/0511461621b848ff3963345e21a52fd0b4e69d38/dbus/cryptohome/dbus-constants.h

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/e0317a6e19f08330bf95b16d1dcd0a361ab1440a

commit e0317a6e19f08330bf95b16d1dcd0a361ab1440a
Author: Thiemo Nagel <tnagel@chromium.org>
Date: Fri Jan 19 01:40:04 2018

init: Remove reference to enrollment_state.epb

The related code has been abandoned before launch in 2013.

BUG= chromium:800748 
TEST=none
CQ-DEPEND=CL:859997

Change-Id: Ie4b9102d441f96c1047adc7946c46b2034350257
Reviewed-on: https://chromium-review.googlesource.com/859788
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Thiemo Nagel <tnagel@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/e0317a6e19f08330bf95b16d1dcd0a361ab1440a/init/clobber-state

Comment 6 by tnagel@chromium.org, Jan 23 2018

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Marked this as "Verified" based on a code review and lack of issues with enrollment using install attributes during M-65 / M-66 Full Release testing.
Pijat tradisional n refleksi

Pada tanggal Jum, 19 Jan 2018 8:43 AM, bugdro… via monorail <
monorail+v2.3275348242@chromium.org> menulis:

Sign in to add a comment