$PWD not set on V8 CQ bots |
|||
Issue descriptionCompare following two logs: [1] https://logs.chromium.org/v/?s=v8%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8957784855455357776%2F%2B%2Fsteps%2Fcompile%2F0%2Fstdout [2] https://logs.chromium.org/v/?s=chromium%2Fbb%2Fclient.v8.fyi%2FV8_Linux64_-_node.js_integration%2F984%2F%2B%2Frecipes%2Fsteps%2Fbuild_addons_and_test_node.js%2F0%2Fstdout [1] is a Luci bot. Both build and test Node.js. The difference is that PWD is set to "/" for [1] and "/b/build/slave/node_js/build" for [2]. This has caused some failures when I synced our Node.js fork with upstream. The new version of Node.js adds some uses of $PWD in the Makefile, which is usually fine since shells set the expected $PWD. In case of [1] it caused failures, which I fixed with this PR: https://github.com/v8/node/commit/b3e2ddf169b769b78577c3b8f6313f99f91b0548 I'm mostly just curious why there is this difference.
,
Jan 10 2018
I'll never get to this with P3 :-).
,
Jan 11 2018
Looks like PWD is not set by any recipe directly, but rather inherited all the way from the swarming bot process, which is triggered by Upstart on LUCI. It appears Upstart uses PWD=/ by default. On Buildbot, there is no swarming process and instead a recipe is run by the Buildbot slave process, which sets PWD to its own working dir: https://chromium.googlesource.com/chromium/tools/build/+/29e1b94894c6c2790acfb21d9c6e0e360b0ffff8/third_party/buildbot_slave_8_4/buildslave/runprocess.py#434. I assume there is no further AI on this bug since you've fixed the issue with a PR. However, if in the future we'll want to change PWD, we can do so in the swarming config files prior to running the task that invokes the recipe and directly in the recipe prior to building/testing Node. |
|||
►
Sign in to add a comment |
|||
Comment 1 by serg...@chromium.org
, Jan 10 2018