enable perfetto builds in chrome also for is_android |
||
Issue description
I guess just an oversight. I was looking at build logs and couldn't figure out why perfetto didn't show up. Turns out that right now the root BUILD.gn says:
if (is_mac || is_linux) {
deps += [ "//third_party/perfetto:all" ]
}
I guess there is an is_android missing :)
,
Jan 10 2018
(Specifically it's the Android test_task_runner which doesn't compile).
,
Jan 10 2018
Ahh makes sense if it was deliberate. No worries then, it's not urgent. P.s. I did split out the Android task runner yesterday off base. I think we can exclude it from the unit test via ifdef that on chrome. That is only meant to integrate in Android services that must use a looper. Chrome is going to have its own task runner that wraps base's. Or if we want to build perfetto standalone we can just use the UnixTaskRunner which uses no external libraries
,
Apr 26 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by oysteine@chromium.org
, Jan 10 2018