New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 800690 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Password disappears from the password field when clicked on submit icon in Lock screen

Project Member Reported by kebalaji@chromium.org, Jan 10 2018

Issue description

Chrome Version: 65.0.3316/10295.0.0 dev-channel Candy,Daisy,Reks
OS: Chrome OS

What steps will reproduce the problem?
(1)Sign-in to user>> Lock the screen>> Enter user password and click on submit icon and observe

Expected: Password should stay in the password field when clicked on submit icon
Actual: Password disappears from the password field when clicked on submit icon

NOTE: 1. Issue is seen only in Lock screen and not seen in sign-out screen
      2. Issue is not seen in Windows and Linux
      3. Issue is also seen in M64 beta

This is a Regression issue as same is working fine in M63 stable

@Wzang: Please confirm the issue




 
ActualLockscreenpwd.jpg
1.3 MB View Download
ActualLockscreenPwd.mp4
4.7 MB View Download
ExpectedLockscreenPwd.mp4
3.8 MB View Download

Comment 1 by wzang@chromium.org, Jan 10 2018

Cc: jdufault@chromium.org
Is it necessary to make the passwords stay after auth success?
We should probably maintain existing behavior. Just don't clear password after auth success - clearing is currently done when auth fails so this should be a trivial change.
Cc: xiy...@chromium.org alemate@chromium.org
 Issue 801630  has been merged into this issue.

Comment 4 by wzang@chromium.org, Jan 12 2018

Status: Started (was: Assigned)
https://chromium-review.googlesource.com/c/chromium/src/+/861042
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f2e5a53920172dcd238f4fea91d346153449deb

commit 3f2e5a53920172dcd238f4fea91d346153449deb
Author: Wenzhao Zang <wzang@chromium.org>
Date: Wed Jan 17 03:05:57 2018

cros: Clear lock screen password only when auth fails

Bug:  800690 
Change-Id: Ie4f7844446d7d47f42b08163b9226eba919a1bf4
Reviewed-on: https://chromium-review.googlesource.com/861042
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529562}
[modify] https://crrev.com/3f2e5a53920172dcd238f4fea91d346153449deb/ash/login/ui/lock_screen_sanity_unittest.cc
[modify] https://crrev.com/3f2e5a53920172dcd238f4fea91d346153449deb/ash/login/ui/login_auth_user_view.cc

Comment 6 by wzang@chromium.org, Jan 17 2018

Labels: Merge-Request-64
Status: Fixed (was: Started)
Project Member

Comment 7 by sheriffbot@chromium.org, Jan 17 2018

Labels: -Merge-Request-64 Hotlist-Merge-Review Merge-Review-64
This bug requires manual review: We are only 5 days from stable.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-64 Merge-Approved-64
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 17 2018

Labels: -merge-approved-64 merge-merged-3282
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5c5ccd3f785a5d1caf2c5bc38497e878c0c1f74

commit a5c5ccd3f785a5d1caf2c5bc38497e878c0c1f74
Author: Wenzhao Zang <wzang@chromium.org>
Date: Wed Jan 17 19:45:57 2018

cros: Clear lock screen password only when auth fails

TBR=wzang@chromium.org

(cherry picked from commit 3f2e5a53920172dcd238f4fea91d346153449deb)

Bug:  800690 
Change-Id: Ie4f7844446d7d47f42b08163b9226eba919a1bf4
Reviewed-on: https://chromium-review.googlesource.com/861042
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#529562}
Reviewed-on: https://chromium-review.googlesource.com/871260
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/branch-heads/3282@{#528}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
[modify] https://crrev.com/a5c5ccd3f785a5d1caf2c5bc38497e878c0c1f74/ash/login/ui/lock_screen_sanity_unittest.cc
[modify] https://crrev.com/a5c5ccd3f785a5d1caf2c5bc38497e878c0c1f74/ash/login/ui/login_auth_user_view.cc

Labels: Inhouse-HYD-Reported

Sign in to add a comment