New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 800659 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Jun 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 827934

Blocking:
issue 709301



Sign in to add a comment

Move the //device/geolocation to //services/device/geolocation.

Project Member Reported by ke...@intel.com, Jan 10 2018

Issue description

Now all the geolocation interfaces are hosted by Device Service. The next steps are:
1) Move all the geolocation relevant *.mojom from //device/geolocation/public to //service/device/public.

2) Move the whole //device/geolocation to //service/device/geolocation. The folder //device/geolocation will be eliminated.

 

Comment 1 by ke...@intel.com, Jan 10 2018

Blocking: 709301

Comment 2 by ke...@intel.com, Jan 10 2018

Description: Show this description
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/69870e3f77c947d16761a34cd783b2090b684e76

commit 69870e3f77c947d16761a34cd783b2090b684e76
Author: Ke He <ke.he@intel.com>
Date: Thu Jan 18 03:09:52 2018

Move the geolocation_control.mojom to //services

Moves the geolocation_control.mojom from //device/geolocation/public/interfaces
to //services/device/public/interfaces.

BUG= 800659 

Change-Id: Ic6ee46650220b39fe29f94cb4fb037084927f7e9
Reviewed-on: https://chromium-review.googlesource.com/859102
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Commit-Queue: Ke He <ke.he@intel.com>
Cr-Commit-Position: refs/heads/master@{#530036}
[modify] https://crrev.com/69870e3f77c947d16761a34cd783b2090b684e76/chrome/browser/BUILD.gn
[modify] https://crrev.com/69870e3f77c947d16761a34cd783b2090b684e76/chrome/browser/geolocation/geolocation_permission_context.h
[modify] https://crrev.com/69870e3f77c947d16761a34cd783b2090b684e76/device/geolocation/BUILD.gn
[modify] https://crrev.com/69870e3f77c947d16761a34cd783b2090b684e76/device/geolocation/geolocation_provider_impl.h
[modify] https://crrev.com/69870e3f77c947d16761a34cd783b2090b684e76/device/geolocation/public/interfaces/BUILD.gn
[modify] https://crrev.com/69870e3f77c947d16761a34cd783b2090b684e76/services/device/device_service.h
[modify] https://crrev.com/69870e3f77c947d16761a34cd783b2090b684e76/services/device/public/interfaces/BUILD.gn
[rename] https://crrev.com/69870e3f77c947d16761a34cd783b2090b684e76/services/device/public/interfaces/geolocation_control.mojom

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/231dce3c86755ffad3f3bf75faedcda4e87652b4

commit 231dce3c86755ffad3f3bf75faedcda4e87652b4
Author: Ke He <ke.he@intel.com>
Date: Thu Jan 18 05:19:04 2018

Move the geolocation_context.mojom from //device to //services

As part of the Device Service, all the geolocation mojom files need
to be moved to //services.
This CL moves the geolocation_context.mojom

BUG= 800659 

Change-Id: Ida13378f68c01a54ff3c6015f6e108ae167b1896
Reviewed-on: https://chromium-review.googlesource.com/861156
Commit-Queue: Ke He <ke.he@intel.com>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530058}
[modify] https://crrev.com/231dce3c86755ffad3f3bf75faedcda4e87652b4/components/autofill/content/browser/risk/fingerprint.cc
[modify] https://crrev.com/231dce3c86755ffad3f3bf75faedcda4e87652b4/content/browser/devtools/protocol/emulation_handler.cc
[modify] https://crrev.com/231dce3c86755ffad3f3bf75faedcda4e87652b4/content/browser/frame_host/render_frame_host_delegate.h
[modify] https://crrev.com/231dce3c86755ffad3f3bf75faedcda4e87652b4/content/browser/geolocation/geolocation_service_impl.h
[modify] https://crrev.com/231dce3c86755ffad3f3bf75faedcda4e87652b4/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/231dce3c86755ffad3f3bf75faedcda4e87652b4/device/geolocation/geolocation_context.h
[modify] https://crrev.com/231dce3c86755ffad3f3bf75faedcda4e87652b4/device/geolocation/public/cpp/scoped_geolocation_overrider.h
[modify] https://crrev.com/231dce3c86755ffad3f3bf75faedcda4e87652b4/device/geolocation/public/interfaces/BUILD.gn
[modify] https://crrev.com/231dce3c86755ffad3f3bf75faedcda4e87652b4/services/device/device_service.h
[modify] https://crrev.com/231dce3c86755ffad3f3bf75faedcda4e87652b4/services/device/public/interfaces/BUILD.gn
[rename] https://crrev.com/231dce3c86755ffad3f3bf75faedcda4e87652b4/services/device/public/interfaces/geolocation_context.mojom

Project Member

Comment 5 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9801c7334fb6eb93dd609be8ed990ee231df8b4

commit f9801c7334fb6eb93dd609be8ed990ee231df8b4
Author: Ke He <ke.he@intel.com>
Date: Thu Jan 18 07:19:44 2018

Move the geolocation_config.mojom from //device to //services

All the geolocation mojom files need to be moved to //services.
This CL moves the geolocation_config.mojom.

BUG= 800659 

Change-Id: Ia5a3495f417d6888a0cce314e3e034168e639c29
Reviewed-on: https://chromium-review.googlesource.com/858962
Commit-Queue: Ke He <ke.he@intel.com>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530081}
[modify] https://crrev.com/f9801c7334fb6eb93dd609be8ed990ee231df8b4/chrome/browser/android/vr_shell/BUILD.gn
[modify] https://crrev.com/f9801c7334fb6eb93dd609be8ed990ee231df8b4/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/f9801c7334fb6eb93dd609be8ed990ee231df8b4/chrome/browser/android/vr_shell/vr_shell.h
[modify] https://crrev.com/f9801c7334fb6eb93dd609be8ed990ee231df8b4/device/geolocation/geolocation_config.h
[modify] https://crrev.com/f9801c7334fb6eb93dd609be8ed990ee231df8b4/device/geolocation/public/interfaces/BUILD.gn
[modify] https://crrev.com/f9801c7334fb6eb93dd609be8ed990ee231df8b4/services/device/device_service.h
[modify] https://crrev.com/f9801c7334fb6eb93dd609be8ed990ee231df8b4/services/device/public/interfaces/BUILD.gn
[rename] https://crrev.com/f9801c7334fb6eb93dd609be8ed990ee231df8b4/services/device/public/interfaces/geolocation_config.mojom

Project Member

Comment 6 by bugdroid1@chromium.org, Jan 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/59131eef644c0002389c379bfddbee2728fb1ce5

commit 59131eef644c0002389c379bfddbee2728fb1ce5
Author: Ke He <ke.he@intel.com>
Date: Wed Jan 24 03:49:28 2018

Move the geolocation.mojom from //device to //service.

As part of the Device Service, all the geolocation related mojom
files need to be moved to //services.
This CL moves the geolocation.mojom

BUG= 800659 

Change-Id: Iad10ce5f12e3d09ad4edbefa55d660fda423450c
Reviewed-on: https://chromium-review.googlesource.com/861311
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Ke He <ke.he@intel.com>
Cr-Commit-Position: refs/heads/master@{#531422}
[modify] https://crrev.com/59131eef644c0002389c379bfddbee2728fb1ce5/components/autofill/content/browser/risk/fingerprint.cc
[modify] https://crrev.com/59131eef644c0002389c379bfddbee2728fb1ce5/components/language/content/browser/BUILD.gn
[modify] https://crrev.com/59131eef644c0002389c379bfddbee2728fb1ce5/components/language/content/browser/DEPS
[modify] https://crrev.com/59131eef644c0002389c379bfddbee2728fb1ce5/components/language/content/browser/geo_language_provider.h
[modify] https://crrev.com/59131eef644c0002389c379bfddbee2728fb1ce5/components/language/content/browser/geo_language_provider_unittest.cc
[modify] https://crrev.com/59131eef644c0002389c379bfddbee2728fb1ce5/content/browser/geolocation/geolocation_service_impl.h
[modify] https://crrev.com/59131eef644c0002389c379bfddbee2728fb1ce5/content/browser/geolocation/geolocation_service_impl_unittest.cc
[modify] https://crrev.com/59131eef644c0002389c379bfddbee2728fb1ce5/device/geolocation/geolocation_context.h
[modify] https://crrev.com/59131eef644c0002389c379bfddbee2728fb1ce5/device/geolocation/geolocation_impl.h
[modify] https://crrev.com/59131eef644c0002389c379bfddbee2728fb1ce5/device/geolocation/public/cpp/scoped_geolocation_overrider.h
[modify] https://crrev.com/59131eef644c0002389c379bfddbee2728fb1ce5/device/geolocation/public/interfaces/BUILD.gn
[modify] https://crrev.com/59131eef644c0002389c379bfddbee2728fb1ce5/services/device/device_service.h
[modify] https://crrev.com/59131eef644c0002389c379bfddbee2728fb1ce5/services/device/geolocation/public_ip_address_geolocation_provider.h
[modify] https://crrev.com/59131eef644c0002389c379bfddbee2728fb1ce5/services/device/geolocation/public_ip_address_geolocator.h
[modify] https://crrev.com/59131eef644c0002389c379bfddbee2728fb1ce5/services/device/public/interfaces/BUILD.gn
[rename] https://crrev.com/59131eef644c0002389c379bfddbee2728fb1ce5/services/device/public/interfaces/geolocation.mojom
[modify] https://crrev.com/59131eef644c0002389c379bfddbee2728fb1ce5/services/device/public/interfaces/geolocation_context.mojom
[modify] https://crrev.com/59131eef644c0002389c379bfddbee2728fb1ce5/services/device/public/interfaces/public_ip_address_geolocation_provider.mojom
[modify] https://crrev.com/59131eef644c0002389c379bfddbee2728fb1ce5/third_party/WebKit/Source/modules/geolocation/DEPS
[modify] https://crrev.com/59131eef644c0002389c379bfddbee2728fb1ce5/third_party/WebKit/Source/modules/geolocation/Geolocation.h
[modify] https://crrev.com/59131eef644c0002389c379bfddbee2728fb1ce5/third_party/WebKit/public/BUILD.gn
[modify] https://crrev.com/59131eef644c0002389c379bfddbee2728fb1ce5/third_party/WebKit/public/platform/modules/geolocation/geolocation_service.mojom

Project Member

Comment 7 by bugdroid1@chromium.org, Jan 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8cbc1c5d11a3991b14d9f2ed2504284ab20cd781

commit 8cbc1c5d11a3991b14d9f2ed2504284ab20cd781
Author: Ke He <ke.he@intel.com>
Date: Wed Jan 24 08:49:07 2018

Move geoposition.mojom from //device/ to //services

As part of the Device Service, all the geolocation related mojom
files need to be moved to //services.
This CL moves the geoposition.mojom.

BUG= 800659 

Change-Id: I1abe615f55453ea0ce2a1daff7e17830f21ab315
Reviewed-on: https://chromium-review.googlesource.com/873190
Commit-Queue: Ke He <ke.he@intel.com>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531481}
[modify] https://crrev.com/8cbc1c5d11a3991b14d9f2ed2504284ab20cd781/BUILD.gn
[modify] https://crrev.com/8cbc1c5d11a3991b14d9f2ed2504284ab20cd781/chrome/browser/geolocation/geolocation_browsertest.cc
[modify] https://crrev.com/8cbc1c5d11a3991b14d9f2ed2504284ab20cd781/chrome/test/BUILD.gn
[modify] https://crrev.com/8cbc1c5d11a3991b14d9f2ed2504284ab20cd781/chrome/test/base/ui_test_utils.cc
[modify] https://crrev.com/8cbc1c5d11a3991b14d9f2ed2504284ab20cd781/components/BUILD.gn
[modify] https://crrev.com/8cbc1c5d11a3991b14d9f2ed2504284ab20cd781/components/autofill/content/browser/BUILD.gn
[modify] https://crrev.com/8cbc1c5d11a3991b14d9f2ed2504284ab20cd781/components/autofill/content/browser/risk/fingerprint.cc
[modify] https://crrev.com/8cbc1c5d11a3991b14d9f2ed2504284ab20cd781/components/autofill/content/browser/risk/fingerprint_browsertest.cc
[modify] https://crrev.com/8cbc1c5d11a3991b14d9f2ed2504284ab20cd781/content/browser/BUILD.gn
[modify] https://crrev.com/8cbc1c5d11a3991b14d9f2ed2504284ab20cd781/content/browser/devtools/protocol/emulation_handler.cc
[modify] https://crrev.com/8cbc1c5d11a3991b14d9f2ed2504284ab20cd781/content/browser/geolocation/geolocation_service_impl_unittest.cc
[modify] https://crrev.com/8cbc1c5d11a3991b14d9f2ed2504284ab20cd781/content/shell/BUILD.gn
[modify] https://crrev.com/8cbc1c5d11a3991b14d9f2ed2504284ab20cd781/content/test/BUILD.gn
[modify] https://crrev.com/8cbc1c5d11a3991b14d9f2ed2504284ab20cd781/device/geolocation/BUILD.gn
[modify] https://crrev.com/8cbc1c5d11a3991b14d9f2ed2504284ab20cd781/device/geolocation/fake_location_provider.h
[modify] https://crrev.com/8cbc1c5d11a3991b14d9f2ed2504284ab20cd781/device/geolocation/geolocation_context.h
[modify] https://crrev.com/8cbc1c5d11a3991b14d9f2ed2504284ab20cd781/device/geolocation/geolocation_provider.h
[modify] https://crrev.com/8cbc1c5d11a3991b14d9f2ed2504284ab20cd781/device/geolocation/geolocation_provider_impl.h
[modify] https://crrev.com/8cbc1c5d11a3991b14d9f2ed2504284ab20cd781/device/geolocation/location_api_adapter_android.h
[modify] https://crrev.com/8cbc1c5d11a3991b14d9f2ed2504284ab20cd781/device/geolocation/location_arbitrator.h
[modify] https://crrev.com/8cbc1c5d11a3991b14d9f2ed2504284ab20cd781/device/geolocation/location_arbitrator_unittest.cc
[modify] https://crrev.com/8cbc1c5d11a3991b14d9f2ed2504284ab20cd781/device/geolocation/location_provider_android.h
[modify] https://crrev.com/8cbc1c5d11a3991b14d9f2ed2504284ab20cd781/device/geolocation/network_location_provider.h
[modify] https://crrev.com/8cbc1c5d11a3991b14d9f2ed2504284ab20cd781/device/geolocation/network_location_request.h
[modify] https://crrev.com/8cbc1c5d11a3991b14d9f2ed2504284ab20cd781/device/geolocation/public/cpp/BUILD.gn
[modify] https://crrev.com/8cbc1c5d11a3991b14d9f2ed2504284ab20cd781/device/geolocation/public/cpp/geoposition.h
[modify] https://crrev.com/8cbc1c5d11a3991b14d9f2ed2504284ab20cd781/device/geolocation/public/cpp/location_provider.h
[modify] https://crrev.com/8cbc1c5d11a3991b14d9f2ed2504284ab20cd781/device/geolocation/public/cpp/scoped_geolocation_overrider.h
[delete] https://crrev.com/f6d7a66d709fe816bbe0619456c01e3c867d9551/device/geolocation/public/interfaces/BUILD.gn
[delete] https://crrev.com/f6d7a66d709fe816bbe0619456c01e3c867d9551/device/geolocation/public/interfaces/OWNERS
[modify] https://crrev.com/8cbc1c5d11a3991b14d9f2ed2504284ab20cd781/services/device/BUILD.gn
[modify] https://crrev.com/8cbc1c5d11a3991b14d9f2ed2504284ab20cd781/services/device/geolocation/public_ip_address_geolocator.h
[modify] https://crrev.com/8cbc1c5d11a3991b14d9f2ed2504284ab20cd781/services/device/geolocation/public_ip_address_location_notifier.h
[modify] https://crrev.com/8cbc1c5d11a3991b14d9f2ed2504284ab20cd781/services/device/geolocation/public_ip_address_location_notifier_unittest.cc
[modify] https://crrev.com/8cbc1c5d11a3991b14d9f2ed2504284ab20cd781/services/device/public/interfaces/BUILD.gn
[modify] https://crrev.com/8cbc1c5d11a3991b14d9f2ed2504284ab20cd781/services/device/public/interfaces/geolocation.mojom
[modify] https://crrev.com/8cbc1c5d11a3991b14d9f2ed2504284ab20cd781/services/device/public/interfaces/geolocation_context.mojom
[rename] https://crrev.com/8cbc1c5d11a3991b14d9f2ed2504284ab20cd781/services/device/public/interfaces/geoposition.mojom
[modify] https://crrev.com/8cbc1c5d11a3991b14d9f2ed2504284ab20cd781/third_party/WebKit/Source/modules/BUILD.gn
[modify] https://crrev.com/8cbc1c5d11a3991b14d9f2ed2504284ab20cd781/third_party/WebKit/Source/modules/geolocation/BUILD.gn

Project Member

Comment 8 by bugdroid1@chromium.org, Feb 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c7f2b872b1ecd558dc1c99f99bd08b233ede8c1e

commit c7f2b872b1ecd558dc1c99f99bd08b233ede8c1e
Author: Ke He <ke.he@intel.com>
Date: Tue Feb 06 02:38:05 2018

Make SetRequestContextProducer and SetApiKey internal of DeviceService.

The geolocation will be moved into //services as its internal part.
The interfaces like SetRequestContextProducer and SetApiKey shouldn't
be called outside the Device Service.

BUG= 800659 

Change-Id: I8641e0b51f45d52aa14f28622508ce9571df6d76
Reviewed-on: https://chromium-review.googlesource.com/882666
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Ke He <ke.he@intel.com>
Cr-Commit-Position: refs/heads/master@{#534599}
[modify] https://crrev.com/c7f2b872b1ecd558dc1c99f99bd08b233ede8c1e/content/browser/service_manager/service_manager_context.cc
[modify] https://crrev.com/c7f2b872b1ecd558dc1c99f99bd08b233ede8c1e/device/geolocation/geolocation_provider.h
[modify] https://crrev.com/c7f2b872b1ecd558dc1c99f99bd08b233ede8c1e/device/geolocation/geolocation_provider_impl.cc
[modify] https://crrev.com/c7f2b872b1ecd558dc1c99f99bd08b233ede8c1e/device/geolocation/geolocation_provider_impl.h
[modify] https://crrev.com/c7f2b872b1ecd558dc1c99f99bd08b233ede8c1e/services/device/device_service.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Mar 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81d1533fbaf2edda5b015bc18b7334ed442c3554

commit 81d1533fbaf2edda5b015bc18b7334ed442c3554
Author: Ke He <ke.he@intel.com>
Date: Thu Mar 01 04:02:28 2018

Remove the usage of GeolocationContext in unittest of geolocationServiceImpl.

The unittest of GeolocationServiceImpl shouldn't include geolocation_context.h.
Instead, we add the ScopedGeolocationOverrider in it.
BUG= 800659 

Change-Id: I3597a9134eb79cd4354f14cc2e14ec95a716bf02
Reviewed-on: https://chromium-review.googlesource.com/911993
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Ke He <ke.he@intel.com>
Cr-Commit-Position: refs/heads/master@{#540037}
[modify] https://crrev.com/81d1533fbaf2edda5b015bc18b7334ed442c3554/content/browser/BUILD.gn
[modify] https://crrev.com/81d1533fbaf2edda5b015bc18b7334ed442c3554/content/browser/DEPS
[modify] https://crrev.com/81d1533fbaf2edda5b015bc18b7334ed442c3554/content/browser/geolocation/geolocation_service_impl_unittest.cc
[modify] https://crrev.com/81d1533fbaf2edda5b015bc18b7334ed442c3554/content/test/BUILD.gn

Comment 10 by ke...@intel.com, Apr 2 2018

Blockedon: 827934
Project Member

Comment 11 by bugdroid1@chromium.org, May 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21ee87ff88dcc072d00a9700400fe1ce410cd106

commit 21ee87ff88dcc072d00a9700400fe1ce410cd106
Author: Ke He <ke.he@intel.com>
Date: Wed May 30 02:35:32 2018

Remove the call site of "useGmsCoreLocationProvider()" in Java side.

Embedder like Chrome can call the useGmsCoreLocationProvider() to indicate
using the GMS core location provider. As the Geolocation will be moved
to //services/device/, embedder shouldn't directly do that function call.

We must make sure the useGmsCoreLocationProvider() is called (when embedder
indicates so) earlier than any clients of the Geolocation which tries to
consume the geolocation.mojom and geolocation_context.mojom. Otherwise an
Android system default location provider will be unexpectedly created.

Mojofy the "useGmsCoreLocationProvider()" is not a good option, because clients
use separate mojo pipes to connect, we can not guarantee the order of messages
between different mojo pipes. It is possible that the mojo call of
"useGmsCoreLocationProvider()" is fired first, but arrives later than other
mojo calls.

So, we get a bool value which indicates whether using the GMS Core Location
Provider from embedder, then pass it to the Device Service when it is created.

BUG= 800659 

Change-Id: Ib8d0e20a1a91d781175171bc98a63c45c27b5b59
Reviewed-on: https://chromium-review.googlesource.com/1068516
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Ke He <ke.he@intel.com>
Cr-Commit-Position: refs/heads/master@{#562704}
[modify] https://crrev.com/21ee87ff88dcc072d00a9700400fe1ce410cd106/chrome/android/java/src/org/chromium/chrome/browser/init/ProcessInitializationHandler.java
[modify] https://crrev.com/21ee87ff88dcc072d00a9700400fe1ce410cd106/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/21ee87ff88dcc072d00a9700400fe1ce410cd106/chrome/browser/chrome_content_browser_client.h
[modify] https://crrev.com/21ee87ff88dcc072d00a9700400fe1ce410cd106/content/browser/service_manager/service_manager_context.cc
[modify] https://crrev.com/21ee87ff88dcc072d00a9700400fe1ce410cd106/content/public/browser/content_browser_client.cc
[modify] https://crrev.com/21ee87ff88dcc072d00a9700400fe1ce410cd106/content/public/browser/content_browser_client.h
[modify] https://crrev.com/21ee87ff88dcc072d00a9700400fe1ce410cd106/device/geolocation/BUILD.gn
[modify] https://crrev.com/21ee87ff88dcc072d00a9700400fe1ce410cd106/device/geolocation/android/java/src/org/chromium/device/geolocation/LocationProviderFactory.java
[modify] https://crrev.com/21ee87ff88dcc072d00a9700400fe1ce410cd106/device/geolocation/geolocation_provider_impl.cc
[modify] https://crrev.com/21ee87ff88dcc072d00a9700400fe1ce410cd106/device/geolocation/geolocation_provider_impl.h
[modify] https://crrev.com/21ee87ff88dcc072d00a9700400fe1ce410cd106/services/device/device_service.cc
[modify] https://crrev.com/21ee87ff88dcc072d00a9700400fe1ce410cd106/services/device/device_service.h
[modify] https://crrev.com/21ee87ff88dcc072d00a9700400fe1ce410cd106/services/device/device_service_test_base.cc

Project Member

Comment 12 by bugdroid1@chromium.org, Jun 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/778900a4e3a018e21fef2be6811aae1c0277c629

commit 778900a4e3a018e21fef2be6811aae1c0277c629
Author: Ke He <ke.he@intel.com>
Date: Thu Jun 14 05:37:54 2018

Make all Java clients not to depend on "geolocation_java".

Before moving //device/geolocation into //services, we have to make
sure all the clients can only depends on //device/geolocation/public.
Clients shouldn't visit internal parts of the geolocation.

So, we move internal interface LocationProvider out of
LocationProviderFactory to public/java, as it is needed by clients
for testing purpose.

We also public the MockLocationProvider.java by moving it into
public/java, and add a LocationProviderOverrider.java to hide the
LocationProviderFactory.java.

In next step, we'll remove all external dependencies on
"//device/geolocation", after that the geolocation can be moved to
//services in a clean way.

BUG= 800659 

Change-Id: I0bdef4244fe77d0b611cebb195ada2121ee77c42
Reviewed-on: https://chromium-review.googlesource.com/1079857
Commit-Queue: Ke He <ke.he@intel.com>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567156}
[modify] https://crrev.com/778900a4e3a018e21fef2be6811aae1c0277c629/android_webview/BUILD.gn
[modify] https://crrev.com/778900a4e3a018e21fef2be6811aae1c0277c629/android_webview/javatests/DEPS
[modify] https://crrev.com/778900a4e3a018e21fef2be6811aae1c0277c629/android_webview/javatests/src/org/chromium/android_webview/test/GeolocationTest.java
[modify] https://crrev.com/778900a4e3a018e21fef2be6811aae1c0277c629/android_webview/test/BUILD.gn
[modify] https://crrev.com/778900a4e3a018e21fef2be6811aae1c0277c629/chrome/android/BUILD.gn
[modify] https://crrev.com/778900a4e3a018e21fef2be6811aae1c0277c629/chrome/android/java/DEPS
[modify] https://crrev.com/778900a4e3a018e21fef2be6811aae1c0277c629/chrome/android/javatests/DEPS
[modify] https://crrev.com/778900a4e3a018e21fef2be6811aae1c0277c629/chrome/android/javatests/src/org/chromium/chrome/browser/permissions/GeolocationTest.java
[modify] https://crrev.com/778900a4e3a018e21fef2be6811aae1c0277c629/chromecast/browser/android/BUILD.gn
[modify] https://crrev.com/778900a4e3a018e21fef2be6811aae1c0277c629/content/public/android/BUILD.gn
[modify] https://crrev.com/778900a4e3a018e21fef2be6811aae1c0277c629/content/public/android/javatests/src/org/chromium/content/browser/ContentViewLocationTest.java
[modify] https://crrev.com/778900a4e3a018e21fef2be6811aae1c0277c629/content/public/test/android/BUILD.gn
[modify] https://crrev.com/778900a4e3a018e21fef2be6811aae1c0277c629/content/shell/android/BUILD.gn
[modify] https://crrev.com/778900a4e3a018e21fef2be6811aae1c0277c629/content/test/BUILD.gn
[modify] https://crrev.com/778900a4e3a018e21fef2be6811aae1c0277c629/device/BUILD.gn
[modify] https://crrev.com/778900a4e3a018e21fef2be6811aae1c0277c629/device/geolocation/BUILD.gn
[modify] https://crrev.com/778900a4e3a018e21fef2be6811aae1c0277c629/device/geolocation/android/java/src/org/chromium/device/geolocation/LocationProviderAdapter.java
[modify] https://crrev.com/778900a4e3a018e21fef2be6811aae1c0277c629/device/geolocation/android/java/src/org/chromium/device/geolocation/LocationProviderAndroid.java
[modify] https://crrev.com/778900a4e3a018e21fef2be6811aae1c0277c629/device/geolocation/android/java/src/org/chromium/device/geolocation/LocationProviderFactory.java
[modify] https://crrev.com/778900a4e3a018e21fef2be6811aae1c0277c629/device/geolocation/android/java/src/org/chromium/device/geolocation/LocationProviderGmsCore.java
[add] https://crrev.com/778900a4e3a018e21fef2be6811aae1c0277c629/device/geolocation/public/java/BUILD.gn
[add] https://crrev.com/778900a4e3a018e21fef2be6811aae1c0277c629/device/geolocation/public/java/src/org/chromium/device/geolocation/LocationProvider.java
[add] https://crrev.com/778900a4e3a018e21fef2be6811aae1c0277c629/device/geolocation/public/java/src/org/chromium/device/geolocation/LocationProviderOverrider.java
[rename] https://crrev.com/778900a4e3a018e21fef2be6811aae1c0277c629/device/geolocation/public/java/src/org/chromium/device/geolocation/MockLocationProvider.java

Project Member

Comment 13 by bugdroid1@chromium.org, Jun 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c9c46534104d508b161450e8808ba747ad51c53

commit 4c9c46534104d508b161450e8808ba747ad51c53
Author: Ke He <ke.he@intel.com>
Date: Thu Jun 14 06:50:57 2018

Change //device/geolocation gn target from component to source_set

Before moving //device/geolocation into //services, we have to make sure
all the clients do not depend on //device/geolocation directly.

Now the chrome/browser:browser depends on //device/geolocation, to
remove that dependency, we have to change the geolocation target from
"component" to "source_set". The reason is:

When building libchrome.so, linker tries to find the symbol:
"Java_org_chromium_device_geolocation_LocationProviderAdapter_nativeNew
ErrorAvailable" as there are native functions being declared in
LocationProviderAdapter.java. Without depending on
"//device/geolocation" in chrome/browser:browser, linker will complain
error that symbol cannot be found. Note that there is no *actual*
dependency from //chrome to //device/geolocation, the Java code that is
using the native function will be moved into Device Service as an
internal implementation.

So we change the "component" to "source_set" to let the symbols inside
the //device/geolocation can be propagated up to target which builds the
libchrome.so. At the same time, the geolocation_export.h is removed.

Because the //device/geolocation will be moved into //services/device
and be hidden, sooner or later it will be changed to type of source_set.

BUG= 800659 

Change-Id: I3e581f9a0e5c492528a85a07e97e93af48ab7eb1
Reviewed-on: https://chromium-review.googlesource.com/1086490
Commit-Queue: Ke He <ke.he@intel.com>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567176}
[modify] https://crrev.com/4c9c46534104d508b161450e8808ba747ad51c53/chrome/browser/BUILD.gn
[modify] https://crrev.com/4c9c46534104d508b161450e8808ba747ad51c53/device/geolocation/BUILD.gn
[modify] https://crrev.com/4c9c46534104d508b161450e8808ba747ad51c53/device/geolocation/geolocation_config.h
[modify] https://crrev.com/4c9c46534104d508b161450e8808ba747ad51c53/device/geolocation/geolocation_context.h
[delete] https://crrev.com/4d4b94246e31a5504128112fa3f35758b62086b4/device/geolocation/geolocation_export.h
[modify] https://crrev.com/4c9c46534104d508b161450e8808ba747ad51c53/device/geolocation/geolocation_provider.h
[modify] https://crrev.com/4c9c46534104d508b161450e8808ba747ad51c53/device/geolocation/geolocation_provider_impl.h
[modify] https://crrev.com/4c9c46534104d508b161450e8808ba747ad51c53/device/geolocation/location_arbitrator.h
[modify] https://crrev.com/4c9c46534104d508b161450e8808ba747ad51c53/device/geolocation/network_location_provider.h
[modify] https://crrev.com/4c9c46534104d508b161450e8808ba747ad51c53/device/geolocation/network_location_request.h
[modify] https://crrev.com/4c9c46534104d508b161450e8808ba747ad51c53/device/geolocation/wifi_data.h
[modify] https://crrev.com/4c9c46534104d508b161450e8808ba747ad51c53/device/geolocation/wifi_data_provider.h
[modify] https://crrev.com/4c9c46534104d508b161450e8808ba747ad51c53/device/geolocation/wifi_data_provider_chromeos.h
[modify] https://crrev.com/4c9c46534104d508b161450e8808ba747ad51c53/device/geolocation/wifi_data_provider_common.h
[modify] https://crrev.com/4c9c46534104d508b161450e8808ba747ad51c53/device/geolocation/wifi_data_provider_linux.h
[modify] https://crrev.com/4c9c46534104d508b161450e8808ba747ad51c53/device/geolocation/wifi_data_provider_manager.h
[modify] https://crrev.com/4c9c46534104d508b161450e8808ba747ad51c53/device/geolocation/wifi_data_provider_win.h
[modify] https://crrev.com/4c9c46534104d508b161450e8808ba747ad51c53/device/geolocation/wifi_polling_policy.h

Project Member

Comment 14 by bugdroid1@chromium.org, Jun 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ffd899b3117fb06d1cdc2fce88f883d68ec3aa1

commit 7ffd899b3117fb06d1cdc2fce88f883d68ec3aa1
Author: Ke He <ke.he@intel.com>
Date: Fri Jun 15 02:48:34 2018

Remove stale dependencies on //device/geolocation.

Before moving //device/geolocation into //services, we have to make sure
all the clients can only depends on //device/geolocation/public. Clients
shouldn't visit internal parts of the geolocation.

After this, we can move geolocation into //service in a clean way in
next step.

BUG= 800659 

Change-Id: I1886e88bece4e20308e3e59a247d51b71a33ebac
Reviewed-on: https://chromium-review.googlesource.com/1100550
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Ke He <ke.he@intel.com>
Cr-Commit-Position: refs/heads/master@{#567523}
[modify] https://crrev.com/7ffd899b3117fb06d1cdc2fce88f883d68ec3aa1/android_webview/browser/DEPS
[modify] https://crrev.com/7ffd899b3117fb06d1cdc2fce88f883d68ec3aa1/chrome/browser/DEPS
[modify] https://crrev.com/7ffd899b3117fb06d1cdc2fce88f883d68ec3aa1/chromecast/browser/BUILD.gn
[modify] https://crrev.com/7ffd899b3117fb06d1cdc2fce88f883d68ec3aa1/chromecast/browser/DEPS
[modify] https://crrev.com/7ffd899b3117fb06d1cdc2fce88f883d68ec3aa1/components/autofill/content/browser/DEPS
[modify] https://crrev.com/7ffd899b3117fb06d1cdc2fce88f883d68ec3aa1/content/app/BUILD.gn
[modify] https://crrev.com/7ffd899b3117fb06d1cdc2fce88f883d68ec3aa1/content/app/DEPS
[modify] https://crrev.com/7ffd899b3117fb06d1cdc2fce88f883d68ec3aa1/content/public/android/DEPS
[modify] https://crrev.com/7ffd899b3117fb06d1cdc2fce88f883d68ec3aa1/content/public/browser/BUILD.gn
[modify] https://crrev.com/7ffd899b3117fb06d1cdc2fce88f883d68ec3aa1/content/public/test/DEPS
[modify] https://crrev.com/7ffd899b3117fb06d1cdc2fce88f883d68ec3aa1/content/shell/browser/DEPS
[modify] https://crrev.com/7ffd899b3117fb06d1cdc2fce88f883d68ec3aa1/content/test/BUILD.gn

Project Member

Comment 15 by bugdroid1@chromium.org, Jun 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b5d9935c8e8d132e385f9874ec9a5f5d4427c864

commit b5d9935c8e8d132e385f9874ec9a5f5d4427c864
Author: Ke He <ke.he@intel.com>
Date: Fri Jun 15 02:50:44 2018

Move geolocation junit_tests from //device to //services.

This is one step of "moving //device/geolocation into //services".

BUG= 800659 

Change-Id: I40f3c1f1b534027132e9eeb17ac5671cad398731
Reviewed-on: https://chromium-review.googlesource.com/1100680
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Ke He <ke.he@intel.com>
Cr-Commit-Position: refs/heads/master@{#567524}
[modify] https://crrev.com/b5d9935c8e8d132e385f9874ec9a5f5d4427c864/device/BUILD.gn
[modify] https://crrev.com/b5d9935c8e8d132e385f9874ec9a5f5d4427c864/services/BUILD.gn
[rename] https://crrev.com/b5d9935c8e8d132e385f9874ec9a5f5d4427c864/services/device/geolocation/android/junit/src/org/chromium/device/geolocation/LocationProviderTest.java

Project Member

Comment 16 by bugdroid1@chromium.org, Jun 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c45ec0a7c26af6e7e3b2ed3942bd516169d50ee4

commit c45ec0a7c26af6e7e3b2ed3942bd516169d50ee4
Author: Ke He <ke.he@intel.com>
Date: Tue Jun 19 03:44:16 2018

Move geolocation unittests from //device to //services

This is one step of "moving //device/geolocation into //services".

BUG= 800659 

Change-Id: I041329923b2cbedab1afd51cc865b278a6a1523a
Reviewed-on: https://chromium-review.googlesource.com/1100694
Reviewed-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Ke He <ke.he@intel.com>
Cr-Commit-Position: refs/heads/master@{#568322}
[modify] https://crrev.com/c45ec0a7c26af6e7e3b2ed3942bd516169d50ee4/device/BUILD.gn
[modify] https://crrev.com/c45ec0a7c26af6e7e3b2ed3942bd516169d50ee4/device/geolocation/BUILD.gn
[modify] https://crrev.com/c45ec0a7c26af6e7e3b2ed3942bd516169d50ee4/services/device/BUILD.gn
[modify] https://crrev.com/c45ec0a7c26af6e7e3b2ed3942bd516169d50ee4/services/device/geolocation/DEPS
[rename] https://crrev.com/c45ec0a7c26af6e7e3b2ed3942bd516169d50ee4/services/device/geolocation/geolocation_provider_impl_unittest.cc
[rename] https://crrev.com/c45ec0a7c26af6e7e3b2ed3942bd516169d50ee4/services/device/geolocation/location_arbitrator_unittest.cc
[rename] https://crrev.com/c45ec0a7c26af6e7e3b2ed3942bd516169d50ee4/services/device/geolocation/network_location_provider_unittest.cc
[modify] https://crrev.com/c45ec0a7c26af6e7e3b2ed3942bd516169d50ee4/services/device/geolocation/public_ip_address_location_notifier_unittest.cc
[rename] https://crrev.com/c45ec0a7c26af6e7e3b2ed3942bd516169d50ee4/services/device/geolocation/wifi_data_provider_chromeos_unittest.cc
[rename] https://crrev.com/c45ec0a7c26af6e7e3b2ed3942bd516169d50ee4/services/device/geolocation/wifi_data_provider_common_unittest.cc
[rename] https://crrev.com/c45ec0a7c26af6e7e3b2ed3942bd516169d50ee4/services/device/geolocation/wifi_data_provider_linux_unittest.cc
[rename] https://crrev.com/c45ec0a7c26af6e7e3b2ed3942bd516169d50ee4/services/device/geolocation/wifi_data_provider_win_unittest.cc
[rename] https://crrev.com/c45ec0a7c26af6e7e3b2ed3942bd516169d50ee4/services/device/geolocation/wifi_polling_policy_unittest.cc

Project Member

Comment 17 by bugdroid1@chromium.org, Jun 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce24c5ff65e56f968d03d66ec61095dcc74f93da

commit ce24c5ff65e56f968d03d66ec61095dcc74f93da
Author: Marc Treib <treib@chromium.org>
Date: Tue Jun 19 10:43:58 2018

Revert "Move geolocation unittests from //device to //services"

This reverts commit c45ec0a7c26af6e7e3b2ed3942bd516169d50ee4.

Reason for revert: Seems to have broken services_unittests on Android CFI, see:
https://findit-for-me.appspot.com/waterfall/build-failure?url=https://build.chromium.org/p/chromium.memory/builders/Android%20CFI/builds/1747

Note that the bot says it timed out, but looking at the failed shard, GeolocationProviderTest.OnPermissionGrantedWithoutObservers and .StartStop fail with:
I  212.843s run_tests_on_device(00f19e674463a218)  [ RUN      ] GeolocationProviderTest.OnPermissionGrantedWithoutObservers
I  212.843s run_tests_on_device(00f19e674463a218)  ../../services/device/geolocation/geolocation_provider_impl_unittest.cc:177: Failure
I  212.843s run_tests_on_device(00f19e674463a218)  Value of: provider()->user_did_opt_into_location_services_for_testing()
I  212.843s run_tests_on_device(00f19e674463a218)    Actual: true
I  212.843s run_tests_on_device(00f19e674463a218)  Expected: false
I  212.843s run_tests_on_device(00f19e674463a218)  Stack trace:
I  212.843s run_tests_on_device(00f19e674463a218)  #00 0xde3c6599 /data/app/org.chromium.native_test-1/lib/arm/lib_services_unittests__library.so+0x017c5599
I  212.843s run_tests_on_device(00f19e674463a218)  #01 0xde0321af /data/app/org.chromium.native_test-1/lib/arm/lib_services_unittests__library.so+0x014311af
I  212.843s run_tests_on_device(00f19e674463a218)  #02 0xde3c92a3 /data/app/org.chromium.native_test-1/lib/arm/lib_services_unittests__library.so+0x017c82a3
I  212.843s run_tests_on_device(00f19e674463a218)  
I  212.844s run_tests_on_device(00f19e674463a218)  [  FAILED  ] GeolocationProviderTest.OnPermissionGrantedWithoutObservers (32 ms)
I  212.844s run_tests_on_device(00f19e674463a218)  [ RUN      ] GeolocationProviderTest.StartStop
I  212.844s run_tests_on_device(00f19e674463a218)  ../../services/device/geolocation/geolocation_provider_impl_unittest.cc:183: Failure
I  212.844s run_tests_on_device(00f19e674463a218)  Value of: provider()->IsRunning()
I  212.844s run_tests_on_device(00f19e674463a218)    Actual: true
I  212.844s run_tests_on_device(00f19e674463a218)  Expected: false
I  212.844s run_tests_on_device(00f19e674463a218)  Stack trace:
I  212.844s run_tests_on_device(00f19e674463a218)  #00 0xde3c6599 /data/app/org.chromium.native_test-1/lib/arm/lib_services_unittests__library.so+0x017c5599
I  212.844s run_tests_on_device(00f19e674463a218)  #01 0xde0323b7 /data/app/org.chromium.native_test-1/lib/arm/lib_services_unittests__library.so+0x014313b7
I  212.844s run_tests_on_device(00f19e674463a218)  #02 0xde3c92a3 /data/app/org.chromium.native_test-1/lib/arm/lib_services_unittests__library.so+0x017c82a3
I  212.844s run_tests_on_device(00f19e674463a218)  
I  212.844s run_tests_on_device(00f19e674463a218)  [  FAILED  ] GeolocationProviderTest.StartStop (29 ms)

Original change's description:
> Move geolocation unittests from //device to //services
> 
> This is one step of "moving //device/geolocation into //services".
> 
> BUG= 800659 
> 
> Change-Id: I041329923b2cbedab1afd51cc865b278a6a1523a
> Reviewed-on: https://chromium-review.googlesource.com/1100694
> Reviewed-by: Ben Chan <benchan@chromium.org>
> Reviewed-by: Ken Rockot <rockot@chromium.org>
> Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> Commit-Queue: Ke He <ke.he@intel.com>
> Cr-Commit-Position: refs/heads/master@{#568322}

TBR=stevenjb@chromium.org,benchan@chromium.org,rockot@chromium.org,ke.he@intel.com

Change-Id: I6527e0a42788d033ff8047b9d38ff16102050a55
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  800659 
Reviewed-on: https://chromium-review.googlesource.com/1105877
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568395}
[modify] https://crrev.com/ce24c5ff65e56f968d03d66ec61095dcc74f93da/device/BUILD.gn
[modify] https://crrev.com/ce24c5ff65e56f968d03d66ec61095dcc74f93da/device/geolocation/BUILD.gn
[rename] https://crrev.com/ce24c5ff65e56f968d03d66ec61095dcc74f93da/device/geolocation/geolocation_provider_impl_unittest.cc
[rename] https://crrev.com/ce24c5ff65e56f968d03d66ec61095dcc74f93da/device/geolocation/location_arbitrator_unittest.cc
[rename] https://crrev.com/ce24c5ff65e56f968d03d66ec61095dcc74f93da/device/geolocation/network_location_provider_unittest.cc
[rename] https://crrev.com/ce24c5ff65e56f968d03d66ec61095dcc74f93da/device/geolocation/wifi_data_provider_chromeos_unittest.cc
[rename] https://crrev.com/ce24c5ff65e56f968d03d66ec61095dcc74f93da/device/geolocation/wifi_data_provider_common_unittest.cc
[rename] https://crrev.com/ce24c5ff65e56f968d03d66ec61095dcc74f93da/device/geolocation/wifi_data_provider_linux_unittest.cc
[rename] https://crrev.com/ce24c5ff65e56f968d03d66ec61095dcc74f93da/device/geolocation/wifi_data_provider_win_unittest.cc
[rename] https://crrev.com/ce24c5ff65e56f968d03d66ec61095dcc74f93da/device/geolocation/wifi_polling_policy_unittest.cc
[modify] https://crrev.com/ce24c5ff65e56f968d03d66ec61095dcc74f93da/services/device/BUILD.gn
[modify] https://crrev.com/ce24c5ff65e56f968d03d66ec61095dcc74f93da/services/device/geolocation/DEPS
[modify] https://crrev.com/ce24c5ff65e56f968d03d66ec61095dcc74f93da/services/device/geolocation/public_ip_address_location_notifier_unittest.cc

Project Member

Comment 18 by bugdroid1@chromium.org, Jun 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1082a6ac05ff32f0a47b0941032ab092ec676fd9

commit 1082a6ac05ff32f0a47b0941032ab092ec676fd9
Author: Ke He <ke.he@intel.com>
Date: Fri Jun 29 03:23:56 2018

Reland: Move geolocation unittests from //device to //services

This is one step of "moving //device/geolocation into //services".

TBR=benchan@chromium.org
BUG= 800659 

Change-Id: I566db835e7df596374cd341048d9734bf82398f6
Reviewed-on: https://chromium-review.googlesource.com/1107637
Reviewed-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Ke He <ke.he@intel.com>
Cr-Commit-Position: refs/heads/master@{#571374}
[modify] https://crrev.com/1082a6ac05ff32f0a47b0941032ab092ec676fd9/device/BUILD.gn
[modify] https://crrev.com/1082a6ac05ff32f0a47b0941032ab092ec676fd9/device/geolocation/BUILD.gn
[modify] https://crrev.com/1082a6ac05ff32f0a47b0941032ab092ec676fd9/device/geolocation/geolocation_provider_impl.h
[modify] https://crrev.com/1082a6ac05ff32f0a47b0941032ab092ec676fd9/services/device/BUILD.gn
[modify] https://crrev.com/1082a6ac05ff32f0a47b0941032ab092ec676fd9/services/device/geolocation/DEPS
[rename] https://crrev.com/1082a6ac05ff32f0a47b0941032ab092ec676fd9/services/device/geolocation/geolocation_provider_impl_unittest.cc
[modify] https://crrev.com/1082a6ac05ff32f0a47b0941032ab092ec676fd9/services/device/geolocation/geolocation_service_unittest.cc
[rename] https://crrev.com/1082a6ac05ff32f0a47b0941032ab092ec676fd9/services/device/geolocation/location_arbitrator_unittest.cc
[rename] https://crrev.com/1082a6ac05ff32f0a47b0941032ab092ec676fd9/services/device/geolocation/network_location_provider_unittest.cc
[modify] https://crrev.com/1082a6ac05ff32f0a47b0941032ab092ec676fd9/services/device/geolocation/public_ip_address_location_notifier_unittest.cc
[rename] https://crrev.com/1082a6ac05ff32f0a47b0941032ab092ec676fd9/services/device/geolocation/wifi_data_provider_chromeos_unittest.cc
[rename] https://crrev.com/1082a6ac05ff32f0a47b0941032ab092ec676fd9/services/device/geolocation/wifi_data_provider_common_unittest.cc
[rename] https://crrev.com/1082a6ac05ff32f0a47b0941032ab092ec676fd9/services/device/geolocation/wifi_data_provider_linux_unittest.cc
[rename] https://crrev.com/1082a6ac05ff32f0a47b0941032ab092ec676fd9/services/device/geolocation/wifi_data_provider_win_unittest.cc
[rename] https://crrev.com/1082a6ac05ff32f0a47b0941032ab092ec676fd9/services/device/geolocation/wifi_polling_policy_unittest.cc

Project Member

Comment 19 by bugdroid1@chromium.org, Jun 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7

commit f417339214f2f9fcb26191adf0ca95ad8cd0e7e7
Author: Ke He <ke.he@intel.com>
Date: Fri Jun 29 07:44:15 2018

Move //device/geolocation to //services/device

This is the last step of servicification of geolocation.

The whole //device/geolocation folder is moved to //services/device.
The public files in //device/geolocation/public are moved to
//service/device/public accordingly.

BUG= 800659 

Change-Id: Id0413058874e20158f733e77c2eaed62f168f8ff
Reviewed-on: https://chromium-review.googlesource.com/1102190
Commit-Queue: Ke He <ke.he@intel.com>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571421}
[modify] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/android_webview/javatests/DEPS
[modify] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/android_webview/test/BUILD.gn
[modify] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/chrome/android/BUILD.gn
[modify] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/chrome/android/javatests/DEPS
[modify] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/chrome/browser/DEPS
[modify] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/chrome/browser/apps/guest_view/web_view_browsertest.cc
[modify] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/chrome/browser/extensions/extension_geolocation_apitest.cc
[modify] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/chrome/browser/geolocation/geolocation_browsertest.cc
[modify] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/chrome/browser/permissions/permission_delegation_browsertest.cc
[modify] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest_base.cc
[modify] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/chrome/test/BUILD.gn
[modify] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/components/BUILD.gn
[modify] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/components/autofill/content/browser/BUILD.gn
[modify] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/components/autofill/content/browser/DEPS
[modify] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/components/autofill/content/browser/risk/fingerprint.cc
[modify] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/components/autofill/content/browser/risk/fingerprint_browsertest.cc
[modify] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/content/browser/BUILD.gn
[modify] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/content/browser/DEPS
[modify] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/content/browser/devtools/protocol/emulation_handler.cc
[modify] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/content/browser/geolocation/geolocation_service_impl_unittest.cc
[modify] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/content/public/android/BUILD.gn
[modify] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/content/public/android/DEPS
[modify] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/content/public/browser/BUILD.gn
[modify] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/content/public/browser/DEPS
[modify] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/content/public/browser/content_browser_client.cc
[modify] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/content/shell/BUILD.gn
[modify] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/content/shell/browser/DEPS
[modify] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/content/shell/browser/layout_test/layout_test_browser_context.cc
[modify] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/content/test/BUILD.gn
[delete] https://crrev.com/00f4cd27096ff62ca4aed94b45420b8a7ec84bc0/device/geolocation/BUILD.gn
[delete] https://crrev.com/00f4cd27096ff62ca4aed94b45420b8a7ec84bc0/device/geolocation/DEPS
[delete] https://crrev.com/00f4cd27096ff62ca4aed94b45420b8a7ec84bc0/device/geolocation/public/cpp/BUILD.gn
[delete] https://crrev.com/00f4cd27096ff62ca4aed94b45420b8a7ec84bc0/device/geolocation/public/java/BUILD.gn
[modify] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/BUILD.gn
[modify] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/BUILD.gn
[modify] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/device_service.cc
[modify] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/device_service.h
[modify] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/device_service_test_base.cc
[modify] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/geolocation/BUILD.gn
[modify] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/geolocation/DEPS
[rename] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/geolocation/OWNERS
[rename] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/geolocation/android/java/src/org/chromium/device/geolocation/LocationProviderAdapter.java
[rename] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/geolocation/android/java/src/org/chromium/device/geolocation/LocationProviderAndroid.java
[rename] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/geolocation/android/java/src/org/chromium/device/geolocation/LocationProviderFactory.java
[rename] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/geolocation/android/java/src/org/chromium/device/geolocation/LocationProviderGmsCore.java
[rename] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/geolocation/empty_wifi_data_provider.cc
[rename] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/geolocation/empty_wifi_data_provider.h
[rename] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/geolocation/fake_location_provider.cc
[rename] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/geolocation/fake_location_provider.h
[rename] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/geolocation/geolocation_config.cc
[rename] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/geolocation/geolocation_config.h
[rename] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/geolocation/geolocation_context.cc
[rename] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/geolocation/geolocation_context.h
[rename] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/geolocation/geolocation_impl.cc
[rename] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/geolocation/geolocation_impl.h
[rename] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/geolocation/geolocation_provider.h
[rename] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/geolocation/geolocation_provider_impl.cc
[rename] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/geolocation/geolocation_provider_impl.h
[modify] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/geolocation/geolocation_provider_impl_unittest.cc
[modify] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/geolocation/geolocation_service_unittest.cc
[rename] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/geolocation/location_api_adapter_android.cc
[rename] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/geolocation/location_api_adapter_android.h
[rename] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/geolocation/location_arbitrator.cc
[rename] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/geolocation/location_arbitrator.h
[modify] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/geolocation/location_arbitrator_unittest.cc
[rename] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/geolocation/location_provider_android.cc
[rename] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/geolocation/location_provider_android.h
[rename] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/geolocation/network_location_provider.cc
[rename] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/geolocation/network_location_provider.h
[modify] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/geolocation/network_location_provider_unittest.cc
[rename] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/geolocation/network_location_request.cc
[rename] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/geolocation/network_location_request.h
[modify] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/geolocation/public_ip_address_location_notifier.cc
[modify] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/geolocation/public_ip_address_location_notifier.h
[modify] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/geolocation/public_ip_address_location_notifier_unittest.cc
[rename] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/geolocation/wifi_data.cc
[rename] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/geolocation/wifi_data.h
[rename] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/geolocation/wifi_data_provider.cc
[rename] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/geolocation/wifi_data_provider.h
[rename] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/geolocation/wifi_data_provider_chromeos.cc
[rename] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/geolocation/wifi_data_provider_chromeos.h
[modify] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/geolocation/wifi_data_provider_chromeos_unittest.cc
[rename] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/geolocation/wifi_data_provider_common.cc
[rename] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/geolocation/wifi_data_provider_common.h
[modify] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/geolocation/wifi_data_provider_common_unittest.cc
[rename] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/geolocation/wifi_data_provider_common_win.cc
[rename] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/geolocation/wifi_data_provider_common_win.h
[rename] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/geolocation/wifi_data_provider_linux.cc
[rename] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/geolocation/wifi_data_provider_linux.h
[modify] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/geolocation/wifi_data_provider_linux_unittest.cc
[rename] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/geolocation/wifi_data_provider_mac.h
[rename] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/geolocation/wifi_data_provider_mac.mm
[rename] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/geolocation/wifi_data_provider_manager.cc
[rename] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/geolocation/wifi_data_provider_manager.h
[rename] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/geolocation/wifi_data_provider_win.cc
[rename] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/geolocation/wifi_data_provider_win.h
[modify] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/geolocation/wifi_data_provider_win_unittest.cc
[rename] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/geolocation/wifi_polling_policy.cc
[rename] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/geolocation/wifi_polling_policy.h
[modify] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/geolocation/wifi_polling_policy_unittest.cc
[add] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/public/cpp/geolocation/BUILD.gn
[rename] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/public/cpp/geolocation/geoposition.cc
[rename] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/public/cpp/geolocation/geoposition.h
[rename] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/public/cpp/geolocation/location_provider.h
[modify] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/public/cpp/test/BUILD.gn
[rename] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/public/cpp/test/scoped_geolocation_overrider.cc
[rename] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/public/cpp/test/scoped_geolocation_overrider.h
[modify] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/public/java/BUILD.gn
[rename] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/public/java/src/org/chromium/device/geolocation/LocationProvider.java
[rename] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/public/java/src/org/chromium/device/geolocation/LocationProviderOverrider.java
[rename] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/services/device/public/java/src/org/chromium/device/geolocation/MockLocationProvider.java
[modify] https://crrev.com/f417339214f2f9fcb26191adf0ca95ad8cd0e7e7/tools/traffic_annotation/summary/annotations.xml

Comment 20 by ke...@intel.com, Jun 29 2018

Status: Fixed (was: Started)

Sign in to add a comment