New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 800653 link

Starred by 7 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 2
Type: Bug



Sign in to add a comment

Remove enable_webrtc=false (i.e. the possibility to build Chromium without WebRTC)

Reported by kaustubh...@gmail.com, Jan 10 2018

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.132 Safari/537.36

Steps to reproduce the problem:
Build chromium with flag enable_webrtc=false

What is the expected behavior?
Build should be successful.

What went wrong?
Unable to build chromium with flag enable_webrtc=false.

Did this work before? N/A 

Chrome version: 63.0.3239.132  Channel: stable
OS Version: 10.0
Flash Version:
 
Components: -Platform>DevTools Build

Comment 2 Deleted

Comment 3 Deleted

Comment 4 Deleted

Cc: vamshi.k...@techmahindra.com
Labels: Triaged-ET TE-NeedsTriageHelp
Thanks for filing the issue!

As this issue seems to be related to build which is out of scope for ET team to triage, hence adding label TE-NeedsTriageHelp for further investigation.
Cc: grunell@chromium.org tommi@chromium.org
Components: Blink>WebRTC
Labels: OS-Linux
Owner: sergeyu@chromium.org
Status: Untriaged (was: Unconfirmed)
On Linux a number of compile errors are generated, such as:

[13633/26694] CXX obj/chrome/browser/browser/native_desktop_media_list.o
FAILED: obj/chrome/browser/browser/native_desktop_media_list.o
In file included from ../../chrome/browser/media/webrtc/native_desktop_media_list.cc:16:
../../third_party/webrtc/modules/desktop_capture/desktop_capturer.h:22:10: fatal error: 'modules/desktop_capture/desktop_frame.h' file not found
#include "modules/desktop_capture/desktop_frame.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

[13977/26694] CXX obj/chrome/browser/browser/window_icon_util_x11.o
FAILED: obj/chrome/browser/browser/window_icon_util_x11.o
In file included from ../../chrome/browser/media/webrtc/window_icon_util_x11.cc:5:
In file included from ../../chrome/browser/media/webrtc/window_icon_util.h:9:
../../third_party/webrtc/modules/desktop_capture/desktop_capture_options.h:13:10: fatal error: 'rtc_base/constructormagic.h' file not found
#include "rtc_base/constructormagic.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

[14609/26694] CXX obj/chrome/browser/browser/desktop_capture_access_handler.o
FAILED: obj/chrome/browser/browser/desktop_capture_access_handler.o
In file included from ../../chrome/browser/media/webrtc/desktop_capture_access_handler.cc:37:
../../third_party/webrtc/modules/desktop_capture/desktop_capture_types.h:16:10: fatal error: 'typedefs.h' file not found
#include "typedefs.h"  // NOLINT(build/include)
         ^~~~~~~~~~~~
1 error generated.

Comment 7 by guidou@chromium.org, Jan 16 2018

Cc: phoglund@chromium.org

Comment 8 by guidou@chromium.org, Jan 16 2018

Cc: niklase@chromium.org

Comment 9 by guidou@chromium.org, Jan 18 2018

Status: Assigned (was: Untriaged)
Changing status to assigned, since the issue has an owner.

Comment 10 by lzj12...@gmail.com, Jan 21 2018

some undefined-symbol link errors occurred after add includes to //chrome/browser/BUILD.gn
 Issue 809971  has been merged into this issue.
I've implemented a bot that looks for this:

https://build.chromium.org/deprecated/chromium.webrtc/waterfall?builder=Linux%20Builder%20(Chromium%20w%2Fo%20WebRTC)

Do we actually have a commitment from somebody to fix this?

Current errors:

../../third_party/webrtc/rtc_base/platform_thread_types.h:38:1: error: unknown type name 'PlatformThreadId'; did you mean 'base::PlatformThreadId'?
PlatformThreadId CurrentThreadId();
^~~~~~~~~~~~~~~~
base::PlatformThreadId
../../base/threading/platform_thread.h:40:15: note: 'base::PlatformThreadId' declared here
typedef pid_t PlatformThreadId;
              ^
In file included from ../../chrome/browser/media/webrtc/native_desktop_media_list.cc:16:
In file included from ../../third_party/webrtc/modules/desktop_capture/desktop_capturer.h:22:
In file included from ../../third_party/webrtc/modules/desktop_capture/desktop_frame.h:19:
In file included from ../../third_party/webrtc/modules/desktop_capture/shared_memory.h:23:
In file included from ../../third_party/webrtc/rtc_base/thread_checker.h:25:
In file included from ../../third_party/webrtc/rtc_base/thread_checker_impl.h:16:
In file included from ../../third_party/webrtc/rtc_base/criticalsection.h:16:
../../third_party/webrtc/rtc_base/platform_thread_types.h:43:1: error: unknown type name 'PlatformThreadRef'; did you mean 'base::PlatformThreadRef'?
PlatformThreadRef CurrentThreadRef();
^~~~~~~~~~~~~~~~~
base::PlatformThreadRef
../../base/threading/platform_thread.h:51:7: note: 'base::PlatformThreadRef' declared here
class PlatformThreadRef {
      ^
In file included from ../../chrome/browser/media/webrtc/native_desktop_media_list.cc:16:
In file included from ../../third_party/webrtc/modules/desktop_capture/desktop_capturer.h:22:
In file included from ../../third_party/webrtc/modules/desktop_capture/desktop_frame.h:19:
In file included from ../../third_party/webrtc/modules/desktop_capture/shared_memory.h:23:
In file included from ../../third_party/webrtc/rtc_base/thread_checker.h:25:
In file included from ../../third_party/webrtc/rtc_base/thread_checker_impl.h:16:
In file included from ../../third_party/webrtc/rtc_base/criticalsection.h:16:
../../third_party/webrtc/rtc_base/platform_thread_types.h:46:29: error: unknown type name 'PlatformThreadRef'; did you mean 'base::PlatformThreadRef'?
bool IsThreadRefEqual(const PlatformThreadRef& a, const PlatformThreadRef& b);
                            ^~~~~~~~~~~~~~~~~
                            base::PlatformThreadRef
../../base/threading/platform_thread.h:51:7: note: 'base::PlatformThreadRef' declared here
class PlatformThreadRef {
      ^
In file included from ../../chrome/browser/media/webrtc/native_desktop_media_list.cc:16:
In file included from ../../third_party/webrtc/modules/desktop_capture/desktop_capturer.h:22:
In file included from ../../third_party/webrtc/modules/desktop_capture/desktop_frame.h:19:
In file included from ../../third_party/webrtc/modules/desktop_capture/shared_memory.h:23:
In file included from ../../third_party/webrtc/rtc_base/thread_checker.h:25:
In file included from ../../third_party/webrtc/rtc_base/thread_checker_impl.h:16:
In file included from ../../third_party/webrtc/rtc_base/criticalsection.h:16:
../../third_party/webrtc/rtc_base/platform_thread_types.h:46:57: error: unknown type name 'PlatformThreadRef'; did you mean 'base::PlatformThreadRef'?
bool IsThreadRefEqual(const PlatformThreadRef& a, const PlatformThreadRef& b);
                                                        ^~~~~~~~~~~~~~~~~
                                                        base::PlatformThreadRef
../../base/threading/platform_thread.h:51:7: note: 'base::PlatformThreadRef' declared here
class PlatformThreadRef {
      ^
In file included from ../../chrome/browser/media/webrtc/native_desktop_media_list.cc:16:
In file included from ../../third_party/webrtc/modules/desktop_capture/desktop_capturer.h:22:
In file included from ../../third_party/webrtc/modules/desktop_capture/desktop_frame.h:19:
In file included from ../../third_party/webrtc/modules/desktop_capture/shared_memory.h:23:
In file included from ../../third_party/webrtc/rtc_base/thread_checker.h:25:
In file included from ../../third_party/webrtc/rtc_base/thread_checker_impl.h:16:
../../third_party/webrtc/rtc_base/criticalsection.h:88:3: error: Unsupported platform.
# error Unsupported platform.
  ^
../../third_party/webrtc/rtc_base/criticalsection.h:119:3: error: Unsupported platform.
# error Unsupported platform.
  ^
In file included from ../../chrome/browser/media/webrtc/native_desktop_media_list.cc:16:
In file included from ../../third_party/webrtc/modules/desktop_capture/desktop_capturer.h:22:
In file included from ../../third_party/webrtc/modules/desktop_capture/desktop_frame.h:19:
In file included from ../../third_party/webrtc/modules/desktop_capture/shared_memory.h:23:
In file included from ../../third_party/webrtc/rtc_base/thread_checker.h:25:
../../third_party/webrtc/rtc_base/thread_checker_impl.h:43:11: error: unknown type name 'PlatformThreadRef'; did you mean 'base::PlatformThreadRef'?
  mutable PlatformThreadRef valid_thread_;
          ^~~~~~~~~~~~~~~~~
          base::PlatformThreadRef
../../base/threading/platform_thread.h:51:7: note: 'base::PlatformThreadRef' declared here
class PlatformThreadRef {

I don't think we can fix this properly without a clear definition of what this flag should do, is there such a definition?
Well, there should be no dependency on //third_party/webrtc I suppose.
That will be more and more complex to maintain imo, since more and more dependencies are coming from other APIs than PeerConnection (chromoting, AEC in audio process etc). Is there still a reason for excluding this dependency?
All right, then I guess we should remove enable_webrtc altogether.
Summary: Remove enable_webrtc=false (i.e. the possibility to build Chromium without WebRTC) (was: Chrome build fails when building with flag enable_webrtc=false)
Project Member

Comment 18 by bugdroid1@chromium.org, May 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6d201bf57dab8c8c53470325bbe19deca1523f4

commit c6d201bf57dab8c8c53470325bbe19deca1523f4
Author: Wez <wez@chromium.org>
Date: Thu May 03 17:04:59 2018

Remove |enable_webrtc| exception for Cast Audio builds.

- Remove |enable_webrtc=false| from the Cast Audio bot configuration.
- Set |enable_webrtc=true| by default, rather than based on whether
  |is_cast_audio_only| is set.

This requires a roll of OpenH264 to pick up changes that fix it not to
use pthreads APIs that are not present under Fuchsia.

Bug:  800653 
Change-Id: Ieaa5b10bd64aab421db8163dd260b1283068d362
Reviewed-on: https://chromium-review.googlesource.com/1039766
Reviewed-by: Henrik Boström <hbos@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Stephen Lanham <slan@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555773}
[modify] https://crrev.com/c6d201bf57dab8c8c53470325bbe19deca1523f4/DEPS
[modify] https://crrev.com/c6d201bf57dab8c8c53470325bbe19deca1523f4/media/media_options.gni
[modify] https://crrev.com/c6d201bf57dab8c8c53470325bbe19deca1523f4/third_party/openh264/README.chromium
[modify] https://crrev.com/c6d201bf57dab8c8c53470325bbe19deca1523f4/tools/mb/mb_config.pyl

Owner: phoglund@chromium.org
CL that removes enable_webrtc: https://chromium-review.googlesource.com/c/chromium/src/+/1044220

I'll dry run it and then find reviewers.
Ok, done and reviewed, it's going in now...
Project Member

Comment 21 by bugdroid1@chromium.org, May 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d98b020fe1f0cb85de21de5313261a66ad9c9fe4

commit d98b020fe1f0cb85de21de5313261a66ad9c9fe4
Author: Patrik Höglund <phoglund@chromium.org>
Date: Mon May 07 12:17:44 2018

Remove enable_webrtc and treat it as always true from now on.

enable_webrtc=false has been broken for months and no one has noticed,
so let's get rid of this complexity. WebRTC will now be a part of
Chromium until the serpent Nidhoggr ascends into the sky and ushers
in Ragnarök.

Next step: remove #ifdef'd code that depends on defines that
were set by enable_webrtc.

Bug:  chromium:800653 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I1661fc56b8005fdae92c3441bb9d7204944bd7c5
Reviewed-on: https://chromium-review.googlesource.com/1044220
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556420}
[modify] https://crrev.com/d98b020fe1f0cb85de21de5313261a66ad9c9fe4/chrome/browser/BUILD.gn
[modify] https://crrev.com/d98b020fe1f0cb85de21de5313261a66ad9c9fe4/chrome/browser/extensions/BUILD.gn
[delete] https://crrev.com/931c6c067b2891c89c9cbd2d3831e38f5d3e0b80/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api_stub.cc
[modify] https://crrev.com/d98b020fe1f0cb85de21de5313261a66ad9c9fe4/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/d98b020fe1f0cb85de21de5313261a66ad9c9fe4/chrome/common/BUILD.gn
[modify] https://crrev.com/d98b020fe1f0cb85de21de5313261a66ad9c9fe4/chrome/common/extensions/api/BUILD.gn
[modify] https://crrev.com/d98b020fe1f0cb85de21de5313261a66ad9c9fe4/chrome/common/features.gni
[modify] https://crrev.com/d98b020fe1f0cb85de21de5313261a66ad9c9fe4/chrome/renderer/BUILD.gn
[modify] https://crrev.com/d98b020fe1f0cb85de21de5313261a66ad9c9fe4/chrome/test/BUILD.gn
[modify] https://crrev.com/d98b020fe1f0cb85de21de5313261a66ad9c9fe4/chrome/tools/service_discovery_sniffer/BUILD.gn
[modify] https://crrev.com/d98b020fe1f0cb85de21de5313261a66ad9c9fe4/components/BUILD.gn
[modify] https://crrev.com/d98b020fe1f0cb85de21de5313261a66ad9c9fe4/components/webrtc_logging/browser/BUILD.gn
[modify] https://crrev.com/d98b020fe1f0cb85de21de5313261a66ad9c9fe4/components/webrtc_logging/common/BUILD.gn
[modify] https://crrev.com/d98b020fe1f0cb85de21de5313261a66ad9c9fe4/content/browser/BUILD.gn
[modify] https://crrev.com/d98b020fe1f0cb85de21de5313261a66ad9c9fe4/content/common/BUILD.gn
[modify] https://crrev.com/d98b020fe1f0cb85de21de5313261a66ad9c9fe4/content/public/browser/BUILD.gn
[modify] https://crrev.com/d98b020fe1f0cb85de21de5313261a66ad9c9fe4/content/public/common/BUILD.gn
[modify] https://crrev.com/d98b020fe1f0cb85de21de5313261a66ad9c9fe4/content/public/renderer/BUILD.gn
[modify] https://crrev.com/d98b020fe1f0cb85de21de5313261a66ad9c9fe4/content/renderer/BUILD.gn
[delete] https://crrev.com/931c6c067b2891c89c9cbd2d3831e38f5d3e0b80/content/renderer/media/webrtc_logging_noop.cc
[modify] https://crrev.com/d98b020fe1f0cb85de21de5313261a66ad9c9fe4/content/test/BUILD.gn
[modify] https://crrev.com/d98b020fe1f0cb85de21de5313261a66ad9c9fe4/jingle/BUILD.gn
[modify] https://crrev.com/d98b020fe1f0cb85de21de5313261a66ad9c9fe4/media/BUILD.gn
[modify] https://crrev.com/d98b020fe1f0cb85de21de5313261a66ad9c9fe4/media/audio/BUILD.gn
[modify] https://crrev.com/d98b020fe1f0cb85de21de5313261a66ad9c9fe4/media/gpu/BUILD.gn
[modify] https://crrev.com/d98b020fe1f0cb85de21de5313261a66ad9c9fe4/media/media_options.gni
[modify] https://crrev.com/d98b020fe1f0cb85de21de5313261a66ad9c9fe4/remoting/BUILD.gn
[modify] https://crrev.com/d98b020fe1f0cb85de21de5313261a66ad9c9fe4/remoting/host/BUILD.gn
[modify] https://crrev.com/d98b020fe1f0cb85de21de5313261a66ad9c9fe4/remoting/host/it2me/BUILD.gn
[modify] https://crrev.com/d98b020fe1f0cb85de21de5313261a66ad9c9fe4/remoting/host/win/BUILD.gn
[modify] https://crrev.com/d98b020fe1f0cb85de21de5313261a66ad9c9fe4/remoting/remoting_enable.gni

Status: Fixed (was: Assigned)
Status: Assigned (was: Fixed)
Or actually, there's some more code I can remove.
Project Member

Comment 24 by bugdroid1@chromium.org, May 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b564859b890058765c3f92839c71ba0c6595398c

commit b564859b890058765c3f92839c71ba0c6595398c
Author: Patrik Höglund <phoglund@chromium.org>
Date: Thu May 17 11:17:16 2018

Removed BUILDFLAG(ENABLE_WEBRTC).

The enable_webrtc gn variable has been removed, so ENABLE_WEBRTC is
always true now; we may as well remove it.

Bug:  chromium:800653 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ie739a5ddb740a87f434bb12f8a451cd1040596a5
Reviewed-on: https://chromium-review.googlesource.com/1059408
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559492}
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/android_webview/lib/aw_main_delegate.cc
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/chrome/browser/about_flags.cc
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/chrome/browser/browser_process.h
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/chrome/browser/browser_process_impl.cc
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/chrome/browser/browser_process_impl.h
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/chrome/browser/browser_resources.grd
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/chrome/browser/chrome_browser_field_trials_desktop.cc
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/chrome/browser/chrome_content_browser_client.h
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/chrome/browser/chrome_content_browser_client_unittest.cc
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/chrome/browser/chromeos/login/chrome_restart_request.cc
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/chrome/browser/extensions/api/preference/preference_api.cc
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/chrome/browser/extensions/api/preference/preference_apitest.cc
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.h
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/chrome/browser/policy/policy_browsertest.cc
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/chrome/browser/renderer_preferences_util.cc
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/chrome/browser/ui/browser_ui_prefs.cc
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/chrome/browser/ui/prefs/prefs_tab_helper.cc
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/chrome/browser/ui/startup/bad_flags_prompt.cc
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/chrome/common/common_message_generator.h
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/chrome/common/features.gni
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/chrome/common/pref_names.cc
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/chrome/common/pref_names.h
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/chrome/common/webui_url_constants.cc
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/chrome/common/webui_url_constants.h
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/chrome/renderer/chrome_content_renderer_client.cc
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/chrome/renderer/chrome_content_renderer_client.h
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/chrome/test/base/testing_browser_process.cc
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/chrome/test/base/testing_browser_process.h
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/content/app/content_main_runner_impl.cc
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/content/browser/browser_context.cc
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/content/browser/browser_main_loop.cc
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/content/browser/renderer_host/media/in_process_launched_video_capture_device.cc
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/content/browser/renderer_host/media/in_process_video_capture_device_launcher.cc
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/content/browser/renderer_host/render_process_host_browsertest.cc
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/content/browser/renderer_host/render_process_host_impl.h
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/content/browser/webrtc/webrtc_internals.cc
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/content/browser/webrtc/webrtc_internals.h
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/content/browser/webui/content_web_ui_controller_factory.cc
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/content/common/content_message_generator.h
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/content/public/browser/render_process_host.h
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/content/public/browser/webrtc_log.h
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/content/public/common/content_switches.cc
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/content/public/common/content_switches.h
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/content/public/test/mock_render_process_host.cc
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/content/public/test/mock_render_process_host.h
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/content/renderer/media/media_factory.cc
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/content/renderer/media/webrtc/rtc_certificate_generator.cc
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/content/renderer/pepper/content_renderer_pepper_host_factory.cc
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/content/renderer/pepper/pepper_media_device_manager.cc
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/content/renderer/pepper/resource_converter.cc
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/content/renderer/render_thread_impl.h
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/content/renderer/render_view_impl.cc
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/content/renderer/renderer_main.cc
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/content/renderer/speech_recognition_dispatcher.cc
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/content/shell/browser/shell.cc
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/content/shell/renderer/layout_test/blink_test_runner.cc
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/content/shell/renderer/layout_test/layout_test_content_renderer_client.cc
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/content/shell/renderer/layout_test/test_media_stream_renderer_factory.cc
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/content/test/test_blink_web_unit_test_support.cc
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/media/BUILD.gn
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/media/audio/audio_manager.cc
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/media/audio/audio_manager_base.cc
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/media/gpu/gpu_video_encode_accelerator_factory.cc
[modify] https://crrev.com/b564859b890058765c3f92839c71ba0c6595398c/tools/ipc_fuzzer/message_tools/message_list.cc

Status: Fixed (was: Assigned)
[bulk-edit: disregard if N/A] Can the owner please set milestone to this bug if applicable?

Sign in to add a comment