New issue
Advanced search Search tips

Issue 800648 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Jan 2018
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

The RenderTextTest.TextDoesntClip/HarfBuzz case in gfx_unittests failed on Loongson.

Reported by wangqing...@loongson.cn, Jan 10 2018

Issue description

UserAgent: Mozilla/5.0 (X11; Linux mips64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3096.2 Safari/537.36

Steps to reproduce the problem:
1. build gfx_unittests
2. run gfx_unittests
3. 

What is the expected behavior?
passed this test case.

What went wrong?
Note: Google Test filter = RenderTextTest.TextDoesntClip/HarfBuzz
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from RenderTextTest
[ RUN      ] RenderTextTest.TextDoesntClip/HarfBuzz
../../ui/gfx/render_text_unittest.cc:409: Failure
Value of: buffer_color
  Actual: 4294243572
Expected: color
Which is: 4294967295
gAXAXAXAXAXAXA at 10, 23
Google Test trace:
../../ui/gfx/render_text_unittest.cc:3864: TextDoesntClip Bottom Side
………………
………………
../../ui/gfx/render_text_unittest.cc:409: Failure
Value of: buffer_color
  Actual: 4291217094
Expected: color
Which is: 4294967295
ههههمرحبا at 65, 23
Google Test trace:
../../ui/gfx/render_text_unittest.cc:3864: TextDoesntClip Bottom Side
[  FAILED  ] RenderTextTest.TextDoesntClip/HarfBuzz, where GetParam() = 0 (611 ms)
[----------] 1 test from RenderTextTest (613 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (613 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] RenderTextTest.TextDoesntClip/HarfBuzz, where GetParam() = 0
 1 FAILED TEST

Did this work before? N/A 

Does this work in other browsers? N/A

Chrome version: 60.0.3096.2  Channel: n/a
OS Version: 
Flash Version:
 
Initial patch that [MIPS] Fix render text test: RenderTextTest.TextDoesntClip/HarfBuzz failed on Loongson has just been submitted for a review.

It can be viewed at:
https://chromium-review.googlesource.com/c/chromium/src/+/858799
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/de4f624c6f96e5569ad55901008d28a3e44af83a

commit de4f624c6f96e5569ad55901008d28a3e44af83a
Author: Wang Qing <wangqing-hf@loongson.cn>
Date: Thu Jan 11 01:15:49 2018

[MIPS] Fix render text test: RenderTextTest.TextDoesntClip/HarfBuzz failed on Loongson.

The bug comes from test unit: gfx_unittest
The failed case: RenderTextTest.TextDoesntClip/HarfBuzz

Draws 1 pixel to the display rect according to Windows to
fix gfx_unittests failed on Loongson.

Bugs:  800648 

R= msw@chromium.org

Bug:  3 
Change-Id: I8529abc3c3c27537527d09c3b9b5b029dc4bb542
Reviewed-on: https://chromium-review.googlesource.com/858799
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: 汪 清 <wangqing-hf@loongson.cn>
Cr-Commit-Position: refs/heads/master@{#528515}
[modify] https://crrev.com/de4f624c6f96e5569ad55901008d28a3e44af83a/ui/gfx/render_text_unittest.cc

Status: Fixed (was: Unconfirmed)

Sign in to add a comment