[Missing Tests]: Migrate geolocation interfaces from being hosted by //content/browser to being hosted by the Device Service |
|||||
Issue descriptionAutomated tests for the below commit have been missing.Would it be possible to add test coverage to avoid regressions in future? CL: === https://chromium.googlesource.com/chromium/src.git/+/95e51a93db90cddbc7ba0e3b81af13ea1a9d4c81 Ref Bug: ======== https://bugs.chromium.org/p/chromium/issues/detail?id=725065 Thank You!
,
Feb 2 2018
,
Feb 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/40b0b56557b0ceaf9fa058281efa9b2e1e92a367 commit 40b0b56557b0ceaf9fa058281efa9b2e1e92a367 Author: Ke He <ke.he@intel.com> Date: Wed Feb 07 02:05:32 2018 Add service unittest for geolocation-config. Automated test missing was found when moving geolocation-config related codes. Add a service unittest against it. BUG= 800633 Change-Id: I99332c942626f8acf2e8ced1387c259024c2a2c3 Reviewed-on: https://chromium-review.googlesource.com/885913 Reviewed-by: Dan Erat <derat@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Ke He <ke.he@intel.com> Cr-Commit-Position: refs/heads/master@{#534876} [modify] https://crrev.com/40b0b56557b0ceaf9fa058281efa9b2e1e92a367/services/device/geolocation/DEPS [modify] https://crrev.com/40b0b56557b0ceaf9fa058281efa9b2e1e92a367/services/device/geolocation/geolocation_service_unittest.cc [modify] https://crrev.com/40b0b56557b0ceaf9fa058281efa9b2e1e92a367/services/device/unittest_manifest.json
,
Aug 17
iOS does not use Blink
,
Aug 22
The assigned owner "ke.he@intel.com" is not able to receive e-mails, please re-triage. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 22
Test coverage appears to have been added. Closing. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by ke...@intel.com
, Jan 10 2018