New issue
Advanced search Search tips

Issue 800618 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Allow '.' in package names

Project Member Reported by vadimsh@chromium.org, Jan 10 2018

Issue description

So we can have package named go/cmd/github.com/golang/dep/linux-amd64
 
Owner: vadimsh@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/40574c593b5be5cc8f8cbd5fb7c27a7d2e7f6911

commit 40574c593b5be5cc8f8cbd5fb7c27a7d2e7f6911
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Wed Jan 10 23:51:08 2018

[cipd] Allow '.' in package names.

Forbid '.' and '..' though since they have a potential for maliciousness if
package names are ever mapped to a file system paths.

R=iannucci@chromium.org
BUG= 800618 

Change-Id: Id1fca776c41e75282c86854da890c502b7cf77b7
Reviewed-on: https://chromium-review.googlesource.com/860983
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/40574c593b5be5cc8f8cbd5fb7c27a7d2e7f6911/appengine/chrome_infra_packages/cipd/test/impl_test.py
[modify] https://crrev.com/40574c593b5be5cc8f8cbd5fb7c27a7d2e7f6911/appengine/chrome_infra_packages/cipd/impl.py

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/94f59dfc7055cde0f89c170af4977419d3b55996

commit 94f59dfc7055cde0f89c170af4977419d3b55996
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Wed Jan 10 23:58:46 2018

[cipd] Allow '.' in package names.

Forbid '.' and '..' though since they have a potential for maliciousness if
package names are ever mapped to a file system paths.

R=iannucci@chromium.org
BUG= 800618 

Change-Id: Ie3e4e93a2efecca6dd32a8fef972333a46002748
Reviewed-on: https://chromium-review.googlesource.com/860881
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/94f59dfc7055cde0f89c170af4977419d3b55996/cipd/client/cipd/client.go
[modify] https://crrev.com/94f59dfc7055cde0f89c170af4977419d3b55996/cipd/client/cipd/common/common.go
[modify] https://crrev.com/94f59dfc7055cde0f89c170af4977419d3b55996/cipd/client/cipd/common/common_test.go

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/a1f61935faa60feb73e37556fdf791262c2dedce

commit a1f61935faa60feb73e37556fdf791262c2dedce
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Thu Jan 11 00:13:38 2018

Roll luci-go DEPS.

infra/go/src/go.chromium.org/luci:
94f59dfc7 [cipd] Allow '.' in package names.
1437ba241 [Machine Database] Ensure ip addresses match the config
40a6f58f8 [git] change commit ids from []byte to hex strings

TBR=iannucci@chromium.org
BUG= 800618 

Change-Id: Icf1744b20218b9a076dde902d49150580cb6c26d
Reviewed-on: https://chromium-review.googlesource.com/861246
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

[modify] https://crrev.com/a1f61935faa60feb73e37556fdf791262c2dedce/DEPS

Project Member

Comment 5 by bugdroid1@chromium.org, Jan 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/957ac42f7e39ab4df71c842df2fd3ffe9d8a3154

commit 957ac42f7e39ab4df71c842df2fd3ffe9d8a3154
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Thu Jan 11 00:33:55 2018

[swarming] Allow '.' in cipd package names.

R=iannucci@chromium.org
BUG= 800618 

Change-Id: I7c297fec30029d3d9fe680c661e2ab6b5c1354b4
Reviewed-on: https://chromium-review.googlesource.com/861245
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

[modify] https://crrev.com/957ac42f7e39ab4df71c842df2fd3ffe9d8a3154/appengine/swarming/cipd.py
[modify] https://crrev.com/957ac42f7e39ab4df71c842df2fd3ffe9d8a3154/appengine/swarming/cipd_test.py

Project Member

Comment 6 by bugdroid1@chromium.org, Jan 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/0766aab2ab81eb4760520576a39178498e553f26

commit 0766aab2ab81eb4760520576a39178498e553f26
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Thu Jan 11 00:57:19 2018

Update cipd client version.

Brings support for '.' in package names.

R=iannucci@chromium.org
BUG= 800618 

Change-Id: I36fd31b0576e002da8d58d7e611742c0aa0b0b57
Reviewed-on: https://chromium-review.googlesource.com/861259
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

[modify] https://crrev.com/0766aab2ab81eb4760520576a39178498e553f26/cipd_client_version

Project Member

Comment 7 by bugdroid1@chromium.org, Jan 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/14bf7946f168816ebadf88a99ea843f3f3f90f0c

commit 14bf7946f168816ebadf88a99ea843f3f3f90f0c
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Thu Jan 11 01:01:39 2018

Update cipd client staging version.

R=iannucci@chromium.org
BUG= 800618 

Change-Id: Icfdee79eaac8e1acfd15c43721bf1e4fa7b3a654
Reviewed-on: https://chromium-review.googlesource.com/861260
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

[modify] https://crrev.com/14bf7946f168816ebadf88a99ea843f3f3f90f0c/scripts/slave/cipd_bootstrap_v2.py

Project Member

Comment 8 by bugdroid1@chromium.org, Jan 11 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/a98de7a6d5bb18df822fac903f16ba1cb6c758b9

commit a98de7a6d5bb18df822fac903f16ba1cb6c758b9
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Thu Jan 11 01:07:38 2018

Project Member

Comment 9 by bugdroid1@chromium.org, Jan 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0dbc7606b3a0fa3a15889ca53dff0d6030fb434f

commit 0dbc7606b3a0fa3a15889ca53dff0d6030fb434f
Author: depot-tools-roller@chromium.org <depot-tools-roller@chromium.org>
Date: Thu Jan 11 02:23:16 2018

Roll src/third_party/depot_tools/ 31c14787e..0766aab2a (1 commit)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/31c14787e48c..0766aab2ab81

$ git log 31c14787e..0766aab2a --date=short --no-merges --format='%ad %ae %s'
2018-01-10 vadimsh Update cipd client version.

Created with:
  roll-dep src/third_party/depot_tools
BUG= 800618 


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=phajdan.jr@chromium.org

Change-Id: Ieefeee2dc55ff2fafc97717361e755548f246663
Reviewed-on: https://chromium-review.googlesource.com/860960
Reviewed-by: depot-tools-roller . <depot-tools-roller@chromium.org>
Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528535}
[modify] https://crrev.com/0dbc7606b3a0fa3a15889ca53dff0d6030fb434f/DEPS

Project Member

Comment 10 by bugdroid1@chromium.org, Jan 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/ce9f3acf7f3d3cc8622453b549a5f05b1a34187a

commit ce9f3acf7f3d3cc8622453b549a5f05b1a34187a
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Fri Jan 12 00:50:24 2018

Bump cipd stable client version to match canary.

R=iannucci@chromium.org
BUG= 800618 

Change-Id: I520774db6c94d395897da5d10d6b601d8208d3cf
Reviewed-on: https://chromium-review.googlesource.com/862602
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/ce9f3acf7f3d3cc8622453b549a5f05b1a34187a/scripts/slave/cipd_bootstrap_v2.py

Status: Fixed (was: Assigned)

Sign in to add a comment