The PartitionAllocTest.GenericAllocGetSize case in base_unittests failed on Loongson.
Reported by
wangqing...@loongson.cn,
Jan 10 2018
|
||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux mips64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3096.2 Safari/537.36 Steps to reproduce the problem: 1. build base_unittests 2. run base_unittests What is the expected behavior? passed this test case. What went wrong? Note: Google Test filter = PartitionAllocTest.GenericAllocGetSize [==========] Running 1 test from 1 test case. [----------] Global test environment set-up. [----------] 1 test from PartitionAllocTest [ RUN ] PartitionAllocTest.GenericAllocGetSize ../../base/allocator/partition_allocator/partition_alloc_unittest.cc:727: Failure Value of: actualSize Actual: 245760 Expected: requestedSize + kSystemPageSize Which is: 262144 [ FAILED ] PartitionAllocTest.GenericAllocGetSize (1 ms) [----------] 1 test from PartitionAllocTest (1 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test case ran. (2 ms total) [ PASSED ] 0 tests. [ FAILED ] 1 test, listed below: [ FAILED ] PartitionAllocTest.GenericAllocGetSize 1 FAILED TEST Did this work before? N/A Does this work in other browsers? N/A Chrome version: 60.0.3096.2 Channel: n/a OS Version: Flash Version:
,
Jan 11 2018
abandon before patch, currently it can be viewed at: https://chromium-review.googlesource.com/c/chromium/src/+/861318
,
Jan 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8321ac4292ace5c323bb51054e79c469530b3078 commit 8321ac4292ace5c323bb51054e79c469530b3078 Author: Wang Qing <wangqing-hf@loongson.cn> Date: Wed Jan 17 02:58:40 2018 Fix PartitionAlloc test: PartitionAllocTest.GenericAllocGetSize failed on Loongson. The bug comes from test unit: base_unittests The failed case: PartitionAllocTest.GenericAllocGetSize When running on systems with a page size of 16k, error will occurred on the value of sub_order_index in PartitionGenericSizeToBucket function. Bug: 800614 R= haraken@chromium.org Change-Id: Ic78e9bc85966349549987d883143049ee9e9a054 Reviewed-on: https://chromium-review.googlesource.com/861318 Reviewed-by: Chris Palmer <palmer@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#529558} [modify] https://crrev.com/8321ac4292ace5c323bb51054e79c469530b3078/base/allocator/partition_allocator/partition_alloc_unittest.cc
,
Jan 22 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by wangqing...@loongson.cn
, Jan 10 2018