New issue
Advanced search Search tips

Issue 800613 link

Starred by 2 users
Status: Fixed
Owner:
pfeldman@chromium.org
Closed: Jan 2018
Cc:
wfh@chromium.org
creis@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug

Blocking:
issue 800893



Sign in to add a comment

DevTools [OOPIF]: iframes in site isolation mode should be rendered inline on Elements panel.

Project Member Reported by pfeldman@chromium.org, Jan 10 2018 
What steps will reproduce the problem?
(1) Launch Chrome with --site-per-process or --isolate-origins=https://csreis.github.io and a clean profile
(2) Navigate to https://csreis.github.io
(3) Open DevTools
(4) Click Go cross-site (simple page)
(5) Observe original iframe content under its node (#document, etc).

Comment 1 by lukasza@chromium.org, Jan 10 2018

Blocking: 800893
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d16260bf91889bb7ead1fe490d087bc2ed02d58b

commit d16260bf91889bb7ead1fe490d087bc2ed02d58b
Author: Pavel Feldman <pfeldman@chromium.org>
Date: Fri Jan 12 02:25:32 2018

DevTools: align iframe contentDocument handling with template and imported ones.

Bug:  800613 
Change-Id: I344870d19a69eaf5fddb742a945a9ace451c0852
Reviewed-on: https://chromium-review.googlesource.com/862605
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528852}
[modify] https://crrev.com/d16260bf91889bb7ead1fe490d087bc2ed02d58b/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/d16260bf91889bb7ead1fe490d087bc2ed02d58b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-panel-rewrite-href-expected.txt
[modify] https://crrev.com/d16260bf91889bb7ead1fe490d087bc2ed02d58b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-panel-selection-after-delete.js
[modify] https://crrev.com/d16260bf91889bb7ead1fe490d087bc2ed02d58b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/event-listener-sidebar-expected.txt
[modify] https://crrev.com/d16260bf91889bb7ead1fe490d087bc2ed02d58b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/event-listener-sidebar-jquery1-expected.txt
[modify] https://crrev.com/d16260bf91889bb7ead1fe490d087bc2ed02d58b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/event-listener-sidebar-jquery2-expected.txt
[modify] https://crrev.com/d16260bf91889bb7ead1fe490d087bc2ed02d58b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/selected-element-changes-execution-context-expected.txt
[modify] https://crrev.com/d16260bf91889bb7ead1fe490d087bc2ed02d58b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/selected-element-changes-execution-context.js
[modify] https://crrev.com/d16260bf91889bb7ead1fe490d087bc2ed02d58b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/metrics-box-sizing-expected.txt
[modify] https://crrev.com/d16260bf91889bb7ead1fe490d087bc2ed02d58b/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/metrics-box-sizing.js
[modify] https://crrev.com/d16260bf91889bb7ead1fe490d087bc2ed02d58b/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js
[modify] https://crrev.com/d16260bf91889bb7ead1fe490d087bc2ed02d58b/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js
[modify] https://crrev.com/d16260bf91889bb7ead1fe490d087bc2ed02d58b/third_party/WebKit/Source/devtools/front_end/elements_test_runner/ElementsTestRunner.js
[modify] https://crrev.com/d16260bf91889bb7ead1fe490d087bc2ed02d58b/third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js

Comment 4 by pfeldman@chromium.org, Jan 12 2018

Summary: DevTools [OOPIF]: iframes in site isolation mode should be rendered inline on Elements panel. (was: DevTools [OOPIF]: navigating from local iframe to oopif does not update <iframe> element content)
I'll generalize this change.
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6e736e6eb72fdca06d0e415b935ed7d2a663334

commit c6e736e6eb72fdca06d0e415b935ed7d2a663334
Author: Pavel Feldman <pfeldman@chromium.org>
Date: Sat Jan 13 02:09:24 2018

DevTools: expose devtools frame token on remote frames as well.

This change generalizes devtools_frame_token to be available on
Frame rather than LocalFrame. This is essential for traceability
from the remote frame owners to the actual targets containing the
local frames.

Bug:  800613 , 800112
Change-Id: Ic615515f64d140b8868c7a007c2954786f751a73
Reviewed-on: https://chromium-review.googlesource.com/864631
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529146}
[modify] https://crrev.com/c6e736e6eb72fdca06d0e415b935ed7d2a663334/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/c6e736e6eb72fdca06d0e415b935ed7d2a663334/content/renderer/render_frame_impl.h
[modify] https://crrev.com/c6e736e6eb72fdca06d0e415b935ed7d2a663334/content/renderer/render_frame_proxy.cc
[modify] https://crrev.com/c6e736e6eb72fdca06d0e415b935ed7d2a663334/content/renderer/render_frame_proxy.h
[modify] https://crrev.com/c6e736e6eb72fdca06d0e415b935ed7d2a663334/content/renderer/service_worker/embedded_worker_instance_client_impl.cc
[modify] https://crrev.com/c6e736e6eb72fdca06d0e415b935ed7d2a663334/third_party/WebKit/Source/core/exported/LocalFrameClientImpl.cpp
[modify] https://crrev.com/c6e736e6eb72fdca06d0e415b935ed7d2a663334/third_party/WebKit/Source/core/exported/LocalFrameClientImpl.h
[modify] https://crrev.com/c6e736e6eb72fdca06d0e415b935ed7d2a663334/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.cpp
[modify] https://crrev.com/c6e736e6eb72fdca06d0e415b935ed7d2a663334/third_party/WebKit/Source/core/exported/WebSharedWorkerImpl.cpp
[modify] https://crrev.com/c6e736e6eb72fdca06d0e415b935ed7d2a663334/third_party/WebKit/Source/core/exported/WebSharedWorkerImpl.h
[modify] https://crrev.com/c6e736e6eb72fdca06d0e415b935ed7d2a663334/third_party/WebKit/Source/core/exported/WorkerShadowPage.cpp
[modify] https://crrev.com/c6e736e6eb72fdca06d0e415b935ed7d2a663334/third_party/WebKit/Source/core/exported/WorkerShadowPage.h
[modify] https://crrev.com/c6e736e6eb72fdca06d0e415b935ed7d2a663334/third_party/WebKit/Source/core/frame/Frame.cpp
[modify] https://crrev.com/c6e736e6eb72fdca06d0e415b935ed7d2a663334/third_party/WebKit/Source/core/frame/Frame.h
[modify] https://crrev.com/c6e736e6eb72fdca06d0e415b935ed7d2a663334/third_party/WebKit/Source/core/frame/FrameClient.h
[modify] https://crrev.com/c6e736e6eb72fdca06d0e415b935ed7d2a663334/third_party/WebKit/Source/core/frame/LocalFrame.cpp
[modify] https://crrev.com/c6e736e6eb72fdca06d0e415b935ed7d2a663334/third_party/WebKit/Source/core/frame/LocalFrame.h
[modify] https://crrev.com/c6e736e6eb72fdca06d0e415b935ed7d2a663334/third_party/WebKit/Source/core/frame/LocalFrameClient.h
[modify] https://crrev.com/c6e736e6eb72fdca06d0e415b935ed7d2a663334/third_party/WebKit/Source/core/frame/RemoteFrameClientImpl.cpp
[modify] https://crrev.com/c6e736e6eb72fdca06d0e415b935ed7d2a663334/third_party/WebKit/Source/core/frame/RemoteFrameClientImpl.h
[modify] https://crrev.com/c6e736e6eb72fdca06d0e415b935ed7d2a663334/third_party/WebKit/Source/core/inspector/IdentifiersFactory.cpp
[modify] https://crrev.com/c6e736e6eb72fdca06d0e415b935ed7d2a663334/third_party/WebKit/Source/core/inspector/IdentifiersFactory.h
[modify] https://crrev.com/c6e736e6eb72fdca06d0e415b935ed7d2a663334/third_party/WebKit/Source/core/inspector/InspectedFrames.cpp
[modify] https://crrev.com/c6e736e6eb72fdca06d0e415b935ed7d2a663334/third_party/WebKit/Source/core/inspector/InspectedFrames.h
[modify] https://crrev.com/c6e736e6eb72fdca06d0e415b935ed7d2a663334/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp
[modify] https://crrev.com/c6e736e6eb72fdca06d0e415b935ed7d2a663334/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp
[modify] https://crrev.com/c6e736e6eb72fdca06d0e415b935ed7d2a663334/third_party/WebKit/Source/core/inspector/InspectorStyleSheet.cpp
[modify] https://crrev.com/c6e736e6eb72fdca06d0e415b935ed7d2a663334/third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.cpp
[modify] https://crrev.com/c6e736e6eb72fdca06d0e415b935ed7d2a663334/third_party/WebKit/Source/core/loader/EmptyClients.h
[modify] https://crrev.com/c6e736e6eb72fdca06d0e415b935ed7d2a663334/third_party/WebKit/Source/modules/exported/WebEmbeddedWorkerImpl.cpp
[modify] https://crrev.com/c6e736e6eb72fdca06d0e415b935ed7d2a663334/third_party/WebKit/Source/modules/exported/WebEmbeddedWorkerImpl.h
[modify] https://crrev.com/c6e736e6eb72fdca06d0e415b935ed7d2a663334/third_party/WebKit/public/web/WebEmbeddedWorkerStartData.h
[modify] https://crrev.com/c6e736e6eb72fdca06d0e415b935ed7d2a663334/third_party/WebKit/public/web/WebFrameClient.h
[modify] https://crrev.com/c6e736e6eb72fdca06d0e415b935ed7d2a663334/third_party/WebKit/public/web/WebRemoteFrameClient.h
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b2818f1fe9d638d1f17d29e814edd6946f8b15e

commit 4b2818f1fe9d638d1f17d29e814edd6946f8b15e
Author: Matt Falkenhagen <falken@chromium.org>
Date: Tue Jan 16 01:25:15 2018

Revert "DevTools: expose devtools frame token on remote frames as well."

This reverts commit c6e736e6eb72fdca06d0e415b935ed7d2a663334.

Reason for revert: It seems this caused a crash bug which is blocking the Dev channel release. See crbug/801993. Probably |client_| is null
in blink::Frame::GetDevToolsFrameToken.

Thread 0 (id: 16076) CRASHED [EXCEPTION_ACCESS_VIOLATION_READ @ 0x00000000 ] MAGIC SIGNATURE THREAD
0x00007fff8da91edc	(chrome_child.dll -Frame.cpp:265 )	blink::Frame::GetDevToolsFrameToken()
0x00007fff8db9a2c7	(chrome_child.dll -IdentifiersFactory.cpp:60 )	blink::IdentifiersFactory::FrameId(blink::Frame *)
0x00007fff8e86e5eb	(chrome_child.dll -InspectorNetworkAgent.cpp:1543 )	blink::InspectorNetworkAgent::FrameClearedScheduledClientNavigation(blink::LocalFrame *)
0x00007fff8dcde67a	(chrome_child.dll -CoreProbesImpl.cpp:1301 )	blink::probe::frameClearedScheduledClientNavigationImpl(blink::LocalFrame *)

Original change's description:
> DevTools: expose devtools frame token on remote frames as well.
>
> This change generalizes devtools_frame_token to be available on
> Frame rather than LocalFrame. This is essential for traceability
> from the remote frame owners to the actual targets containing the
> local frames.
>
> Bug:  800613 , 800112
> Change-Id: Ic615515f64d140b8868c7a007c2954786f751a73
> Reviewed-on: https://chromium-review.googlesource.com/864631
> Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#529146}

TBR=dgozman@chromium.org,dcheng@chromium.org,pfeldman@chromium.org

Skipping CQ due to urgency of merging to release branch per release team.

Bug:  800613 , 800112, 801993
Change-Id: I06826e36d72cd6e266e25c3ccea5bb73e065d04a
NOTRY: true
Reviewed-on: https://chromium-review.googlesource.com/867690
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529351}
[modify] https://crrev.com/4b2818f1fe9d638d1f17d29e814edd6946f8b15e/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/4b2818f1fe9d638d1f17d29e814edd6946f8b15e/content/renderer/render_frame_impl.h
[modify] https://crrev.com/4b2818f1fe9d638d1f17d29e814edd6946f8b15e/content/renderer/render_frame_proxy.cc
[modify] https://crrev.com/4b2818f1fe9d638d1f17d29e814edd6946f8b15e/content/renderer/render_frame_proxy.h
[modify] https://crrev.com/4b2818f1fe9d638d1f17d29e814edd6946f8b15e/content/renderer/service_worker/embedded_worker_instance_client_impl.cc
[modify] https://crrev.com/4b2818f1fe9d638d1f17d29e814edd6946f8b15e/third_party/WebKit/Source/core/exported/LocalFrameClientImpl.cpp
[modify] https://crrev.com/4b2818f1fe9d638d1f17d29e814edd6946f8b15e/third_party/WebKit/Source/core/exported/LocalFrameClientImpl.h
[modify] https://crrev.com/4b2818f1fe9d638d1f17d29e814edd6946f8b15e/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.cpp
[modify] https://crrev.com/4b2818f1fe9d638d1f17d29e814edd6946f8b15e/third_party/WebKit/Source/core/exported/WebSharedWorkerImpl.cpp
[modify] https://crrev.com/4b2818f1fe9d638d1f17d29e814edd6946f8b15e/third_party/WebKit/Source/core/exported/WebSharedWorkerImpl.h
[modify] https://crrev.com/4b2818f1fe9d638d1f17d29e814edd6946f8b15e/third_party/WebKit/Source/core/exported/WorkerShadowPage.cpp
[modify] https://crrev.com/4b2818f1fe9d638d1f17d29e814edd6946f8b15e/third_party/WebKit/Source/core/exported/WorkerShadowPage.h
[modify] https://crrev.com/4b2818f1fe9d638d1f17d29e814edd6946f8b15e/third_party/WebKit/Source/core/frame/Frame.cpp
[modify] https://crrev.com/4b2818f1fe9d638d1f17d29e814edd6946f8b15e/third_party/WebKit/Source/core/frame/Frame.h
[modify] https://crrev.com/4b2818f1fe9d638d1f17d29e814edd6946f8b15e/third_party/WebKit/Source/core/frame/FrameClient.h
[modify] https://crrev.com/4b2818f1fe9d638d1f17d29e814edd6946f8b15e/third_party/WebKit/Source/core/frame/LocalFrame.cpp
[modify] https://crrev.com/4b2818f1fe9d638d1f17d29e814edd6946f8b15e/third_party/WebKit/Source/core/frame/LocalFrame.h
[modify] https://crrev.com/4b2818f1fe9d638d1f17d29e814edd6946f8b15e/third_party/WebKit/Source/core/frame/LocalFrameClient.h
[modify] https://crrev.com/4b2818f1fe9d638d1f17d29e814edd6946f8b15e/third_party/WebKit/Source/core/frame/RemoteFrameClientImpl.cpp
[modify] https://crrev.com/4b2818f1fe9d638d1f17d29e814edd6946f8b15e/third_party/WebKit/Source/core/frame/RemoteFrameClientImpl.h
[modify] https://crrev.com/4b2818f1fe9d638d1f17d29e814edd6946f8b15e/third_party/WebKit/Source/core/inspector/IdentifiersFactory.cpp
[modify] https://crrev.com/4b2818f1fe9d638d1f17d29e814edd6946f8b15e/third_party/WebKit/Source/core/inspector/IdentifiersFactory.h
[modify] https://crrev.com/4b2818f1fe9d638d1f17d29e814edd6946f8b15e/third_party/WebKit/Source/core/inspector/InspectedFrames.cpp
[modify] https://crrev.com/4b2818f1fe9d638d1f17d29e814edd6946f8b15e/third_party/WebKit/Source/core/inspector/InspectedFrames.h
[modify] https://crrev.com/4b2818f1fe9d638d1f17d29e814edd6946f8b15e/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp
[modify] https://crrev.com/4b2818f1fe9d638d1f17d29e814edd6946f8b15e/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp
[modify] https://crrev.com/4b2818f1fe9d638d1f17d29e814edd6946f8b15e/third_party/WebKit/Source/core/inspector/InspectorStyleSheet.cpp
[modify] https://crrev.com/4b2818f1fe9d638d1f17d29e814edd6946f8b15e/third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.cpp
[modify] https://crrev.com/4b2818f1fe9d638d1f17d29e814edd6946f8b15e/third_party/WebKit/Source/core/loader/EmptyClients.h
[modify] https://crrev.com/4b2818f1fe9d638d1f17d29e814edd6946f8b15e/third_party/WebKit/Source/modules/exported/WebEmbeddedWorkerImpl.cpp
[modify] https://crrev.com/4b2818f1fe9d638d1f17d29e814edd6946f8b15e/third_party/WebKit/Source/modules/exported/WebEmbeddedWorkerImpl.h
[modify] https://crrev.com/4b2818f1fe9d638d1f17d29e814edd6946f8b15e/third_party/WebKit/public/web/WebEmbeddedWorkerStartData.h
[modify] https://crrev.com/4b2818f1fe9d638d1f17d29e814edd6946f8b15e/third_party/WebKit/public/web/WebFrameClient.h
[modify] https://crrev.com/4b2818f1fe9d638d1f17d29e814edd6946f8b15e/third_party/WebKit/public/web/WebRemoteFrameClient.h
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 16 2018

Labels: merge-merged-3322
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9edbb11a56655b992af3e9477bb2449363d6550

commit a9edbb11a56655b992af3e9477bb2449363d6550
Author: Matt Falkenhagen <falken@chromium.org>
Date: Tue Jan 16 01:33:19 2018

Revert "DevTools: expose devtools frame token on remote frames as well."

This reverts commit c6e736e6eb72fdca06d0e415b935ed7d2a663334.

Reason for revert: It seems this caused a crash bug which is blocking the Dev channel release. See crbug/801993. Probably |client_| is null
in blink::Frame::GetDevToolsFrameToken.

Thread 0 (id: 16076) CRASHED [EXCEPTION_ACCESS_VIOLATION_READ @ 0x00000000 ] MAGIC SIGNATURE THREAD
0x00007fff8da91edc	(chrome_child.dll -Frame.cpp:265 )	blink::Frame::GetDevToolsFrameToken()
0x00007fff8db9a2c7	(chrome_child.dll -IdentifiersFactory.cpp:60 )	blink::IdentifiersFactory::FrameId(blink::Frame *)
0x00007fff8e86e5eb	(chrome_child.dll -InspectorNetworkAgent.cpp:1543 )	blink::InspectorNetworkAgent::FrameClearedScheduledClientNavigation(blink::LocalFrame *)
0x00007fff8dcde67a	(chrome_child.dll -CoreProbesImpl.cpp:1301 )	blink::probe::frameClearedScheduledClientNavigationImpl(blink::LocalFrame *)

Original change's description:
> DevTools: expose devtools frame token on remote frames as well.
>
> This change generalizes devtools_frame_token to be available on
> Frame rather than LocalFrame. This is essential for traceability
> from the remote frame owners to the actual targets containing the
> local frames.
>
> Bug:  800613 , 800112
> Change-Id: Ic615515f64d140b8868c7a007c2954786f751a73
> Reviewed-on: https://chromium-review.googlesource.com/864631
> Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#529146}

TBR=dgozman@chromium.org,dcheng@chromium.org,pfeldman@chromium.org

Skipping CQ due to urgency of merging to release branch per release team.

Bug:  800613 , 800112, 801993
Change-Id: I06826e36d72cd6e266e25c3ccea5bb73e065d04a
NOTRY: true
Reviewed-on: https://chromium-review.googlesource.com/867690
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#529351}(cherry picked from commit 4b2818f1fe9d638d1f17d29e814edd6946f8b15e)
Reviewed-on: https://chromium-review.googlesource.com/867710
Cr-Commit-Position: refs/branch-heads/3322@{#5}
Cr-Branched-From: 4522efba74e35026b0f62cb1c97d793a92a0d5da-refs/heads/master@{#529187}
[modify] https://crrev.com/a9edbb11a56655b992af3e9477bb2449363d6550/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/a9edbb11a56655b992af3e9477bb2449363d6550/content/renderer/render_frame_impl.h
[modify] https://crrev.com/a9edbb11a56655b992af3e9477bb2449363d6550/content/renderer/render_frame_proxy.cc
[modify] https://crrev.com/a9edbb11a56655b992af3e9477bb2449363d6550/content/renderer/render_frame_proxy.h
[modify] https://crrev.com/a9edbb11a56655b992af3e9477bb2449363d6550/content/renderer/service_worker/embedded_worker_instance_client_impl.cc
[modify] https://crrev.com/a9edbb11a56655b992af3e9477bb2449363d6550/third_party/WebKit/Source/core/exported/LocalFrameClientImpl.cpp
[modify] https://crrev.com/a9edbb11a56655b992af3e9477bb2449363d6550/third_party/WebKit/Source/core/exported/LocalFrameClientImpl.h
[modify] https://crrev.com/a9edbb11a56655b992af3e9477bb2449363d6550/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.cpp
[modify] https://crrev.com/a9edbb11a56655b992af3e9477bb2449363d6550/third_party/WebKit/Source/core/exported/WebSharedWorkerImpl.cpp
[modify] https://crrev.com/a9edbb11a56655b992af3e9477bb2449363d6550/third_party/WebKit/Source/core/exported/WebSharedWorkerImpl.h
[modify] https://crrev.com/a9edbb11a56655b992af3e9477bb2449363d6550/third_party/WebKit/Source/core/exported/WorkerShadowPage.cpp
[modify] https://crrev.com/a9edbb11a56655b992af3e9477bb2449363d6550/third_party/WebKit/Source/core/exported/WorkerShadowPage.h
[modify] https://crrev.com/a9edbb11a56655b992af3e9477bb2449363d6550/third_party/WebKit/Source/core/frame/Frame.cpp
[modify] https://crrev.com/a9edbb11a56655b992af3e9477bb2449363d6550/third_party/WebKit/Source/core/frame/Frame.h
[modify] https://crrev.com/a9edbb11a56655b992af3e9477bb2449363d6550/third_party/WebKit/Source/core/frame/FrameClient.h
[modify] https://crrev.com/a9edbb11a56655b992af3e9477bb2449363d6550/third_party/WebKit/Source/core/frame/LocalFrame.cpp
[modify] https://crrev.com/a9edbb11a56655b992af3e9477bb2449363d6550/third_party/WebKit/Source/core/frame/LocalFrame.h
[modify] https://crrev.com/a9edbb11a56655b992af3e9477bb2449363d6550/third_party/WebKit/Source/core/frame/LocalFrameClient.h
[modify] https://crrev.com/a9edbb11a56655b992af3e9477bb2449363d6550/third_party/WebKit/Source/core/frame/RemoteFrameClientImpl.cpp
[modify] https://crrev.com/a9edbb11a56655b992af3e9477bb2449363d6550/third_party/WebKit/Source/core/frame/RemoteFrameClientImpl.h
[modify] https://crrev.com/a9edbb11a56655b992af3e9477bb2449363d6550/third_party/WebKit/Source/core/inspector/IdentifiersFactory.cpp
[modify] https://crrev.com/a9edbb11a56655b992af3e9477bb2449363d6550/third_party/WebKit/Source/core/inspector/IdentifiersFactory.h
[modify] https://crrev.com/a9edbb11a56655b992af3e9477bb2449363d6550/third_party/WebKit/Source/core/inspector/InspectedFrames.cpp
[modify] https://crrev.com/a9edbb11a56655b992af3e9477bb2449363d6550/third_party/WebKit/Source/core/inspector/InspectedFrames.h
[modify] https://crrev.com/a9edbb11a56655b992af3e9477bb2449363d6550/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp
[modify] https://crrev.com/a9edbb11a56655b992af3e9477bb2449363d6550/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp
[modify] https://crrev.com/a9edbb11a56655b992af3e9477bb2449363d6550/third_party/WebKit/Source/core/inspector/InspectorStyleSheet.cpp
[modify] https://crrev.com/a9edbb11a56655b992af3e9477bb2449363d6550/third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.cpp
[modify] https://crrev.com/a9edbb11a56655b992af3e9477bb2449363d6550/third_party/WebKit/Source/core/loader/EmptyClients.h
[modify] https://crrev.com/a9edbb11a56655b992af3e9477bb2449363d6550/third_party/WebKit/Source/modules/exported/WebEmbeddedWorkerImpl.cpp
[modify] https://crrev.com/a9edbb11a56655b992af3e9477bb2449363d6550/third_party/WebKit/Source/modules/exported/WebEmbeddedWorkerImpl.h
[modify] https://crrev.com/a9edbb11a56655b992af3e9477bb2449363d6550/third_party/WebKit/public/web/WebEmbeddedWorkerStartData.h
[modify] https://crrev.com/a9edbb11a56655b992af3e9477bb2449363d6550/third_party/WebKit/public/web/WebFrameClient.h
[modify] https://crrev.com/a9edbb11a56655b992af3e9477bb2449363d6550/third_party/WebKit/public/web/WebRemoteFrameClient.h
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 17 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f4f48aa0dcbb1658d98098dc29a448b6fd97996

commit 5f4f48aa0dcbb1658d98098dc29a448b6fd97996
Author: Pavel Feldman <pfeldman@chromium.org>
Date: Wed Jan 17 05:15:34 2018

DevTools: expose devtools frame token on remote frames as well.

TBR: dgozman (reland)
Bug:  800613 , 800112
Change-Id: I7f5a740725a4c8e83d0394766c3d8e698a874720
Reviewed-on: https://chromium-review.googlesource.com/868828
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529619}
[modify] https://crrev.com/5f4f48aa0dcbb1658d98098dc29a448b6fd97996/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/5f4f48aa0dcbb1658d98098dc29a448b6fd97996/content/renderer/render_frame_impl.h
[modify] https://crrev.com/5f4f48aa0dcbb1658d98098dc29a448b6fd97996/content/renderer/render_frame_proxy.cc
[modify] https://crrev.com/5f4f48aa0dcbb1658d98098dc29a448b6fd97996/content/renderer/render_frame_proxy.h
[modify] https://crrev.com/5f4f48aa0dcbb1658d98098dc29a448b6fd97996/content/renderer/service_worker/embedded_worker_instance_client_impl.cc
[modify] https://crrev.com/5f4f48aa0dcbb1658d98098dc29a448b6fd97996/third_party/WebKit/Source/core/exported/LocalFrameClientImpl.cpp
[modify] https://crrev.com/5f4f48aa0dcbb1658d98098dc29a448b6fd97996/third_party/WebKit/Source/core/exported/LocalFrameClientImpl.h
[modify] https://crrev.com/5f4f48aa0dcbb1658d98098dc29a448b6fd97996/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.cpp
[modify] https://crrev.com/5f4f48aa0dcbb1658d98098dc29a448b6fd97996/third_party/WebKit/Source/core/exported/WebSharedWorkerImpl.cpp
[modify] https://crrev.com/5f4f48aa0dcbb1658d98098dc29a448b6fd97996/third_party/WebKit/Source/core/exported/WebSharedWorkerImpl.h
[modify] https://crrev.com/5f4f48aa0dcbb1658d98098dc29a448b6fd97996/third_party/WebKit/Source/core/exported/WorkerShadowPage.cpp
[modify] https://crrev.com/5f4f48aa0dcbb1658d98098dc29a448b6fd97996/third_party/WebKit/Source/core/exported/WorkerShadowPage.h
[modify] https://crrev.com/5f4f48aa0dcbb1658d98098dc29a448b6fd97996/third_party/WebKit/Source/core/frame/Frame.cpp
[modify] https://crrev.com/5f4f48aa0dcbb1658d98098dc29a448b6fd97996/third_party/WebKit/Source/core/frame/Frame.h
[modify] https://crrev.com/5f4f48aa0dcbb1658d98098dc29a448b6fd97996/third_party/WebKit/Source/core/frame/FrameClient.h
[modify] https://crrev.com/5f4f48aa0dcbb1658d98098dc29a448b6fd97996/third_party/WebKit/Source/core/frame/LocalFrame.cpp
[modify] https://crrev.com/5f4f48aa0dcbb1658d98098dc29a448b6fd97996/third_party/WebKit/Source/core/frame/LocalFrame.h
[modify] https://crrev.com/5f4f48aa0dcbb1658d98098dc29a448b6fd97996/third_party/WebKit/Source/core/frame/LocalFrameClient.h
[modify] https://crrev.com/5f4f48aa0dcbb1658d98098dc29a448b6fd97996/third_party/WebKit/Source/core/frame/RemoteFrameClientImpl.cpp
[modify] https://crrev.com/5f4f48aa0dcbb1658d98098dc29a448b6fd97996/third_party/WebKit/Source/core/frame/RemoteFrameClientImpl.h
[modify] https://crrev.com/5f4f48aa0dcbb1658d98098dc29a448b6fd97996/third_party/WebKit/Source/core/inspector/IdentifiersFactory.cpp
[modify] https://crrev.com/5f4f48aa0dcbb1658d98098dc29a448b6fd97996/third_party/WebKit/Source/core/inspector/IdentifiersFactory.h
[modify] https://crrev.com/5f4f48aa0dcbb1658d98098dc29a448b6fd97996/third_party/WebKit/Source/core/inspector/InspectedFrames.cpp
[modify] https://crrev.com/5f4f48aa0dcbb1658d98098dc29a448b6fd97996/third_party/WebKit/Source/core/inspector/InspectedFrames.h
[modify] https://crrev.com/5f4f48aa0dcbb1658d98098dc29a448b6fd97996/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp
[modify] https://crrev.com/5f4f48aa0dcbb1658d98098dc29a448b6fd97996/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp
[modify] https://crrev.com/5f4f48aa0dcbb1658d98098dc29a448b6fd97996/third_party/WebKit/Source/core/inspector/InspectorStyleSheet.cpp
[modify] https://crrev.com/5f4f48aa0dcbb1658d98098dc29a448b6fd97996/third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.cpp
[modify] https://crrev.com/5f4f48aa0dcbb1658d98098dc29a448b6fd97996/third_party/WebKit/Source/core/loader/EmptyClients.h
[modify] https://crrev.com/5f4f48aa0dcbb1658d98098dc29a448b6fd97996/third_party/WebKit/Source/modules/exported/WebEmbeddedWorkerImpl.cpp
[modify] https://crrev.com/5f4f48aa0dcbb1658d98098dc29a448b6fd97996/third_party/WebKit/Source/modules/exported/WebEmbeddedWorkerImpl.h
[modify] https://crrev.com/5f4f48aa0dcbb1658d98098dc29a448b6fd97996/third_party/WebKit/public/web/WebEmbeddedWorkerStartData.h
[modify] https://crrev.com/5f4f48aa0dcbb1658d98098dc29a448b6fd97996/third_party/WebKit/public/web/WebFrameClient.h
[modify] https://crrev.com/5f4f48aa0dcbb1658d98098dc29a448b6fd97996/third_party/WebKit/public/web/WebRemoteFrameClient.h
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed9388054c24171adc1c1ac5e9795f1832e8f179

commit ed9388054c24171adc1c1ac5e9795f1832e8f179
Author: Pavel Feldman <pfeldman@chromium.org>
Date: Thu Jan 18 01:38:10 2018

DevTools: introduce UI-level undo stack to be used across several DOM models.

Bug:  800613 
Change-Id: I8647bb3de532f309169f552684523522b9b1f5ad
Reviewed-on: https://chromium-review.googlesource.com/871841
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530006}
[modify] https://crrev.com/ed9388054c24171adc1c1ac5e9795f1832e8f179/third_party/WebKit/LayoutTests/http/tests/devtools/elements/edit/perform-undo-undo.js
[modify] https://crrev.com/ed9388054c24171adc1c1ac5e9795f1832e8f179/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-2/perform-undo-perform-of-mergable-action.js
[modify] https://crrev.com/ed9388054c24171adc1c1ac5e9795f1832e8f179/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-keyframes.js
[modify] https://crrev.com/ed9388054c24171adc1c1ac5e9795f1832e8f179/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/undo-add-new-rule.js
[modify] https://crrev.com/ed9388054c24171adc1c1ac5e9795f1832e8f179/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/undo-add-property.js
[modify] https://crrev.com/ed9388054c24171adc1c1ac5e9795f1832e8f179/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/undo-add-rule-crash.js
[modify] https://crrev.com/ed9388054c24171adc1c1ac5e9795f1832e8f179/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/undo-after-cancelled-editing.js
[modify] https://crrev.com/ed9388054c24171adc1c1ac5e9795f1832e8f179/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/undo-change-property.js
[modify] https://crrev.com/ed9388054c24171adc1c1ac5e9795f1832e8f179/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/undo-property-toggle.js
[modify] https://crrev.com/ed9388054c24171adc1c1ac5e9795f1832e8f179/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/undo-set-selector-text.js
[modify] https://crrev.com/ed9388054c24171adc1c1ac5e9795f1832e8f179/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js
[modify] https://crrev.com/ed9388054c24171adc1c1ac5e9795f1832e8f179/third_party/WebKit/Source/devtools/front_end/elements_test_runner/ElementsTestRunner.js
[modify] https://crrev.com/ed9388054c24171adc1c1ac5e9795f1832e8f179/third_party/WebKit/Source/devtools/front_end/elements_test_runner/SetOuterHTMLTestRunner.js
[modify] https://crrev.com/ed9388054c24171adc1c1ac5e9795f1832e8f179/third_party/WebKit/Source/devtools/front_end/sdk/CSSModel.js
[modify] https://crrev.com/ed9388054c24171adc1c1ac5e9795f1832e8f179/third_party/WebKit/Source/devtools/front_end/sdk/CSSProperty.js
[modify] https://crrev.com/ed9388054c24171adc1c1ac5e9795f1832e8f179/third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js

Comment 11 by krajshree@chromium.org, Jan 19 2018

Labels: TE-Verified-M65 TE-Verified-65.0.3325.0
Verified the fix on Ubuntu 14.04 using latest chrome version #65.0.3325.0 as per the comment #0 and #2.
Attaching screen cast for reference.
Observed that iframes in site isolation mode rendered inline on Elements panel.
Hence, the fix is working as expected. 
Adding the verified labels.

Thanks...!!
800613.ogv
1.7 MB View Download

Comment 12 by nasko@chromium.org, Jan 19 2018 

Hmm, is the video verifying the correct behavior? The frame content is still under the main document and the inline display of the iframe in the main document does not inline its contents.

Either I don't understand the intent of this fix or the verification is not complete.

Comment 13 by pfeldman@chromium.org, Jan 19 2018 

I'm just starting, it'll take a handful of patches to complete this one.

Comment 14 by creis@chromium.org, Jan 19 2018

Labels: -TE-Verified-M65 -TE-Verified-65.0.3325.0
Thanks.  I'll remove the verified labels.
Project Member

Comment 15 by bugdroid1@chromium.org, Jan 20 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64059ff3638365ea0b9dbf2ba8b1fa576aa446a6

commit 64059ff3638365ea0b9dbf2ba8b1fa576aa446a6
Author: Pavel Feldman <pfeldman@chromium.org>
Date: Sat Jan 20 04:32:35 2018

DevTools: allow fetching iframe owner for given out-of-process target id.

Bug:  800613 
Change-Id: I57c3cb407d210359b3aa1a1418b920690b10fb1b
Reviewed-on: https://chromium-review.googlesource.com/874525
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530749}
[modify] https://crrev.com/64059ff3638365ea0b9dbf2ba8b1fa576aa446a6/content/browser/devtools/devtools_agent_host_impl.cc
[modify] https://crrev.com/64059ff3638365ea0b9dbf2ba8b1fa576aa446a6/content/browser/devtools/devtools_agent_host_impl.h
[modify] https://crrev.com/64059ff3638365ea0b9dbf2ba8b1fa576aa446a6/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/64059ff3638365ea0b9dbf2ba8b1fa576aa446a6/content/browser/devtools/render_frame_devtools_agent_host.h
[add] https://crrev.com/64059ff3638365ea0b9dbf2ba8b1fa576aa446a6/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/dom/dom-getFrameOwner-expected.txt
[add] https://crrev.com/64059ff3638365ea0b9dbf2ba8b1fa576aa446a6/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/dom/dom-getFrameOwner.js
[modify] https://crrev.com/64059ff3638365ea0b9dbf2ba8b1fa576aa446a6/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp
[modify] https://crrev.com/64059ff3638365ea0b9dbf2ba8b1fa576aa446a6/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h
[modify] https://crrev.com/64059ff3638365ea0b9dbf2ba8b1fa576aa446a6/third_party/WebKit/Source/core/inspector/browser_protocol.json
[modify] https://crrev.com/64059ff3638365ea0b9dbf2ba8b1fa576aa446a6/third_party/WebKit/Source/core/inspector/browser_protocol.pdl
Project Member

Comment 16 by bugdroid1@chromium.org, Jan 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/862205e268c77eefa884c9677b6b74a8f58cb06e

commit 862205e268c77eefa884c9677b6b74a8f58cb06e
Author: Pavel Feldman <pfeldman@chromium.org>
Date: Tue Jan 23 22:46:10 2018

DevTools: simplify document update workflow on the front-end side.

Bug:  800613 
Change-Id: I5549e2027929480b23c3a8d9ad05fecbe37bbfba
Reviewed-on: https://chromium-review.googlesource.com/881549
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531378}
[modify] https://crrev.com/862205e268c77eefa884c9677b6b74a8f58cb06e/third_party/WebKit/LayoutTests/http/tests/devtools/elements/dom-search-crash.js
[modify] https://crrev.com/862205e268c77eefa884c9677b6b74a8f58cb06e/third_party/WebKit/LayoutTests/http/tests/devtools/elements/elements-panel-search.js
[modify] https://crrev.com/862205e268c77eefa884c9677b6b74a8f58cb06e/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js
[modify] https://crrev.com/862205e268c77eefa884c9677b6b74a8f58cb06e/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js
[modify] https://crrev.com/862205e268c77eefa884c9677b6b74a8f58cb06e/third_party/WebKit/Source/devtools/front_end/elements_test_runner/ElementsTestRunner.js
[modify] https://crrev.com/862205e268c77eefa884c9677b6b74a8f58cb06e/third_party/WebKit/Source/devtools/front_end/sdk/DOMDebuggerModel.js
[modify] https://crrev.com/862205e268c77eefa884c9677b6b74a8f58cb06e/third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js
[modify] https://crrev.com/862205e268c77eefa884c9677b6b74a8f58cb06e/third_party/WebKit/Source/devtools/front_end/sdk/OverlayModel.js

Comment 17 by pfeldman@chromium.org, Jan 29 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment