New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 800600 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

HWTest suite links from builders are broken

Project Member Reported by pprabhu@chromium.org, Jan 10 2018

Issue description

Cc: jrbarnette@chromium.org davidri...@chromium.org
+deputy, +reporter.

This just looks like the bug that was fixed by https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/838309 and was pushed-to-prod this morning.

The fact that one of the links is broken makes me think that one of the swarming_bot servers didn't get updated (that's where run_suite runs) in this morning's push to prod.
Nope: all got pushed this morning: http://shortn/_Lh3S3UEw1w
I got it wrong. The builds _after_ that build have the broken links: https://luci-milo.appspot.com/buildbot/chromeos/kevin-paladin/3527

So that build was running while the push was underway, and the push actually broke the links.
Actually, I take it back. run_suite shouldn't try to hide user error here.
The correct fix is: https://chrome-internal-review.googlesource.com/c/chromeos/chromeos-admin/+/542995
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 10 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-admin/+/cbe45bb74423e82ddd7c0bf775c69d84c1f39da1

commit cbe45bb74423e82ddd7c0bf775c69d84c1f39da1
Author: Prathmesh Prabhu <pprabhu@chromium.org>
Date: Wed Jan 10 22:05:41 2018

My quickfix was useless (it only changed AFE as used by swarming_bot_manager, not what run_suite reads).

Anyway, real fix is: https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/861095 but that needs a push-to-prod.
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/686615421e004b3a8566f562e2537ea2b58f1f0d

commit 686615421e004b3a8566f562e2537ea2b58f1f0d
Author: Prathmesh Prabhu <pprabhu@chromium.org>
Date: Fri Jan 12 06:22:45 2018

autotest: Always add protocol before printling links to suite jobs.

BUG= chromium:800600 
TEST=None

Change-Id: I201d0804b672a031ba30696bddc697ecdf538355
Reviewed-on: https://chromium-review.googlesource.com/861095
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Prathmesh Prabhu <pprabhu@chromium.org>
Reviewed-by: Richard Barnette <jrbarnette@google.com>

[modify] https://crrev.com/686615421e004b3a8566f562e2537ea2b58f1f0d/server/cros/dynamic_suite/reporting_utils.py

Fixed pending push-to-prod, me hopes.
Cc: shuqianz@chromium.org akes...@chromium.org
Any update on this?  Adding current deputies.
Cc: -akes...@chromium.org
Owner: akes...@chromium.org
This needs a push to prod, assigned to secondary to do the push.


The prod-next branch has been updated to include this CL, a lab push is enough, no need to wait for a successful testing push.
Cc: -jrbarnette@chromium.org
Status: Fixed (was: Started)

Sign in to add a comment