Alignment errors in Timezone settings |
|||||||||||||||
Issue descriptionWhen going to the new fine-grained timezone settings, there are a couple alignment issues: 1) The dropdowns should be aligned to the text of the radio buttons. See dropdown_alignment.png 2) The enterprise icon should be on the right of the dropdown, not on the left. That way it does not affect the alignment of the dropdown.
,
Jan 23 2018
The UI has been updated, though it still has some alignment issues. I'll re-use this bug for those :-)
,
Jan 23 2018
,
Jan 31 2018
,
Feb 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f62250003409d3c36030381021a9b492b595251f commit f62250003409d3c36030381021a9b492b595251f Author: Alexander Alekseev <alemate@chromium.org> Date: Tue Feb 06 02:10:17 2018 Update alignment of time zone settings. This CL aligns time zone dropdowns to match the radio buttons labels. Bug: 800597 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I231f970d90ff3d6fd47d97aeded2ec58ecd31173 Reviewed-on: https://chromium-review.googlesource.com/898398 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#534587} [modify] https://crrev.com/f62250003409d3c36030381021a9b492b595251f/chrome/browser/resources/settings/date_time_page/timezone_subpage.html
,
Feb 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2f443737157dd2989b0c41d14b29c8032da0b127 commit 2f443737157dd2989b0c41d14b29c8032da0b127 Author: Alexander Alekseev <alemate@chromium.org> Date: Tue Feb 06 04:59:39 2018 Chrome OS: Move policy indicator in time zone settings UI. This CL adds --settings-dropdown-menu-policy-order css variable to settings-dropdown-menu to customize policy indicator position, and applies "display last" order to time zone UI dropdowns. Bug: 800597 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I45cae7018e4c9f7cc01712daf870472aaf24768d Reviewed-on: https://chromium-review.googlesource.com/898567 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#534628} [modify] https://crrev.com/2f443737157dd2989b0c41d14b29c8032da0b127/chrome/browser/resources/settings/controls/settings_dropdown_menu.html [modify] https://crrev.com/2f443737157dd2989b0c41d14b29c8032da0b127/chrome/browser/resources/settings/date_time_page/timezone_selector.html [modify] https://crrev.com/2f443737157dd2989b0c41d14b29c8032da0b127/chrome/browser/resources/settings/date_time_page/timezone_subpage.html
,
Feb 6 2018
Requesting merge for both CLs. They are independent though, we can merge any.
,
Feb 7 2018
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cf523acd5fdfea7c50b86e63a162528b2c6255f0 commit cf523acd5fdfea7c50b86e63a162528b2c6255f0 Author: Alexander Alekseev <alemate@chromium.org> Date: Wed Feb 07 23:15:18 2018 Update alignment of time zone settings. This CL aligns time zone dropdowns to match the radio buttons labels. TBR=alemate@chromium.org (cherry picked from commit f62250003409d3c36030381021a9b492b595251f) Bug: 800597 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I231f970d90ff3d6fd47d97aeded2ec58ecd31173 Reviewed-on: https://chromium-review.googlesource.com/898398 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#534587} Reviewed-on: https://chromium-review.googlesource.com/907740 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#374} Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369} [modify] https://crrev.com/cf523acd5fdfea7c50b86e63a162528b2c6255f0/chrome/browser/resources/settings/date_time_page/timezone_subpage.html
,
Feb 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2109e18a2724c65251138366a1a033f0a284b3cd commit 2109e18a2724c65251138366a1a033f0a284b3cd Author: Alexander Alekseev <alemate@chromium.org> Date: Wed Feb 07 23:16:39 2018 Chrome OS: Move policy indicator in time zone settings UI. This CL adds --settings-dropdown-menu-policy-order css variable to settings-dropdown-menu to customize policy indicator position, and applies "display last" order to time zone UI dropdowns. TBR=alemate@chromium.org (cherry picked from commit 2f443737157dd2989b0c41d14b29c8032da0b127) Bug: 800597 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I45cae7018e4c9f7cc01712daf870472aaf24768d Reviewed-on: https://chromium-review.googlesource.com/898567 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#534628} Reviewed-on: https://chromium-review.googlesource.com/907741 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#375} Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369} [modify] https://crrev.com/2109e18a2724c65251138366a1a033f0a284b3cd/chrome/browser/resources/settings/controls/settings_dropdown_menu.html [modify] https://crrev.com/2109e18a2724c65251138366a1a033f0a284b3cd/chrome/browser/resources/settings/date_time_page/timezone_selector.html [modify] https://crrev.com/2109e18a2724c65251138366a1a033f0a284b3cd/chrome/browser/resources/settings/date_time_page/timezone_subpage.html
,
Feb 14 2018
Hi Alemate, alignment errors are fixed. But, the appearance of enterprise icon on the RHS keeps varying. In some cases, I'm seeing two enterprise icons on the RHS. Attached screenshots of timezone settings UI for different values of SystemTimezoneAutomaticDetection policy (set to 0, 1, 2) on an enrolled device. Please confirm if the displays are expected?
,
Feb 14 2018
Yes, this is expected. We display Enterprise-managed for every control element in the settings UI. So it matches other behavior.
,
Feb 14 2018
Thank you for your confirmation @alemate. Closing this bug as verified on Chrome OS 10323.30.0, 65.0.3325.65 dev channel kevin. |
|||||||||||||||
►
Sign in to add a comment |
|||||||||||||||
Comment 1 by michae...@chromium.org
, Jan 10 2018Status: Assigned (was: Untriaged)