TA/DA edit links not showing up when they should |
|||
Issue descriptionhttps://screenshot.googleplex.com/GrgB1gk85NV I suspect it has to do with some of the tests not already appearing in expectation files. For instance, the test that correctly has an edit link appears: https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/TestExpectations?q=accessibility/name-calc-img.html&sq=package:chromium&dr=C&l=1679 But compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-clipped.html (and others like it) do not already appear in expectations files. IIUC, we should be able to add tests to an expectations file if they don't already appear in one. Determining which file is the correct destination may be tricky though.
,
Jan 10 2018
,
Feb 17 2018
Is this bug actually a P1? Adding tests to expectations files if they don't have one already seems like a reasonable solution. But as you said, we'd need a scheme for coming up with the correct destination. How reasonable would it be to let people pick out of existing expectations files (or maybe out of a few guesses)?
,
Feb 17 2018
P2 sgtm. I'm not sure we should guess or even offer the user a choice of files. The sheriff probably doesn't have the best idea of which test expectation file it should be, because they typically aren't very familiar with the failing test or the code that it tests. |
|||
►
Sign in to add a comment |
|||
Comment 1 by seanmccullough@chromium.org
, Jan 10 2018