There are a lot of websocket WPT with the following meta tags:
<meta name="variant" content="">
<meta name="variant" content="?wss">
This configuration will lead to two test entries under the file in manifest, e.g.
"websockets/binary/001.html": [
[
"/websockets/binary/001.html",
{}
],
[
"/websockets/binary/001.html?wss",
{}
]
],
Now the two test names are websockets/binary/001.html and websockets/binary/001.html?wss. The latter, unfortunately, breaks a few presumptions in our infra, namely how to derive actual/expected output filenames from a test name. We currently simply take the basename of the test name, and append -expected.txt or -actual.txt. So both tests resolve to websockets/binary/001-{expected,actual}.txt.
Two tools are known to have problems:
1. test result viewer https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/fast/harness/results.html?q=results.html&sq=package:chromium&l=437
2. webkit-patch rebaseline https://cs.chromium.org/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py?type=cs&q=_test_root&l=83
The actual output files in the result directory have names like 001.html_wss-actual.txt. Presumably, the name mangling of the output files is done differently.
We shall decide on a consistent naming convention for this case, and then go over all the places that need to mangle test names.
Comment 1 by robertma@chromium.org
, Jan 9 2018