New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 800557 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 812784
Owner:
Last visit > 30 days ago
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug

Blocked on:
issue 774301



Sign in to add a comment

Lack of Mac10.13 trybots breaks rebaseline

Project Member Reported by robertma@chromium.org, Jan 9 2018

Issue description

In  issue 774301 , definitions of Mac10.13 are added to webkitpy (https://chromium-review.googlesource.com/717500), but we still haven't got Mac10.13 trybots running.

The awkward current situation breaks webkit-patch rebaseline{-cl} in the following scenario:
1. A test used to fail on all platforms and was marked as so in TestExpectations:
Bug test [ Failure ]
2. The test is fixed. Now run `webkit-patch rebaseline-cl`, which triggers a series of trybots except Mac10.13 since we don't have one.
3. `webkit-patch rebaseline-cl` successfully rebaselines the test from all the trybots and removes their platforms from the expectation, but Mac10.13 will linger around. Hence, we end up with
Bug [ Mac10.13 ] test [ Failure ]
 
Blockedon: 774301
Marked as blocked on 774301.

The issue will go away once we deploy Mac10.13 trybots. Or, we can hack webkitpy to add a special case.
Status: Available (was: Untriaged)
Labels: OS-Mac
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/446adea8688f3a89836a7eb6b807f87fd5053d46

commit 446adea8688f3a89836a7eb6b807f87fd5053d46
Author: Robert Ma <robertma@chromium.org>
Date: Wed Jan 10 00:51:04 2018

Remove all lingering Mac10.13 test expectations

We don't have Mac10.13 try/CQ bots yet. These test expectations are
caused by  issue 800557 ; the example scenario described in that issue
happened during automatic rebaseline done by wpt-import.

Bug:  800557 
Change-Id: If27136d573dda56cb7323c8c8315c6c88019f9fa
Reviewed-on: https://chromium-review.googlesource.com/857698
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528190}
[modify] https://crrev.com/446adea8688f3a89836a7eb6b807f87fd5053d46/third_party/WebKit/LayoutTests/TestExpectations

Cc: linds...@chromium.org
Is this still a valid issue? 
I think so -- last week skobes tried to fix this by marking the mac10.13 try bot as a rebaselining try bot, but this was reverted (https://chromium-review.googlesource.com/c/chromium/src/+/923781).
Cc: sergeybe...@chromium.org
Owner: shenghua...@chromium.org
Status: Assigned (was: Available)
Hi Sarah, Dirk and Sergey,
With the migration of the Mac CQ to 10.13, are there now enough trybots on 10.13 as well?
Thanks,
Mergedinto: 812784
Status: Duplicate (was: Assigned)
This is in fact the same as  issue 812784 , which has just been fixed. Duping this to that one as the other issue has more interesting commit history.

As for the capacity issue/concern, please track it in another issue.

Sign in to add a comment