window was snapped to new position when reposition started. We should avoid it. And while roposition window, the reticle should stick on the same place in the window.
Biao has a CL out, but he's OOO for a while, so I expect somebody will have to pick this up? (https://chromium-review.googlesource.com/c/chromium/src/+/857426)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/618bf8fcfac14a5c3ff82b9b5d06432d792cdd8d commit 618bf8fcfac14a5c3ff82b9b5d06432d792cdd8d Author: Ian Vollick <vollick@chromium.org> Date: Thu Feb 01 00:56:41 2018 [vr] Avoid snap at the onset of window repositioning With this change, we begin repositioning based on laser direction deltas once repositioning is enabled. Also adds a scrim to the content quad while repositioning is happening. We also update controller labels. Bug: 800563 , 800556 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I19bdc286c7b7be2dc5df8a6690b965098959559e Reviewed-on: https://chromium-review.googlesource.com/894902 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#533498} [modify] https://crrev.com/618bf8fcfac14a5c3ff82b9b5d06432d792cdd8d/chrome/app/generated_resources.grd [modify] https://crrev.com/618bf8fcfac14a5c3ff82b9b5d06432d792cdd8d/chrome/browser/vr/elements/repositioner.cc [modify] https://crrev.com/618bf8fcfac14a5c3ff82b9b5d06432d792cdd8d/chrome/browser/vr/elements/repositioner.h [modify] https://crrev.com/618bf8fcfac14a5c3ff82b9b5d06432d792cdd8d/chrome/browser/vr/elements/repositioner_unittest.cc [modify] https://crrev.com/618bf8fcfac14a5c3ff82b9b5d06432d792cdd8d/chrome/browser/vr/elements/ui_element_name.cc [modify] https://crrev.com/618bf8fcfac14a5c3ff82b9b5d06432d792cdd8d/chrome/browser/vr/elements/ui_element_name.h [modify] https://crrev.com/618bf8fcfac14a5c3ff82b9b5d06432d792cdd8d/chrome/browser/vr/model/color_scheme.cc [modify] https://crrev.com/618bf8fcfac14a5c3ff82b9b5d06432d792cdd8d/chrome/browser/vr/model/color_scheme.h [modify] https://crrev.com/618bf8fcfac14a5c3ff82b9b5d06432d792cdd8d/chrome/browser/vr/testapp/vr_test_context.cc [modify] https://crrev.com/618bf8fcfac14a5c3ff82b9b5d06432d792cdd8d/chrome/browser/vr/ui_scene.cc [modify] https://crrev.com/618bf8fcfac14a5c3ff82b9b5d06432d792cdd8d/chrome/browser/vr/ui_scene.h [modify] https://crrev.com/618bf8fcfac14a5c3ff82b9b5d06432d792cdd8d/chrome/browser/vr/ui_scene_constants.h [modify] https://crrev.com/618bf8fcfac14a5c3ff82b9b5d06432d792cdd8d/chrome/browser/vr/ui_scene_creator.cc [modify] https://crrev.com/618bf8fcfac14a5c3ff82b9b5d06432d792cdd8d/chrome/browser/vr/ui_unittest.cc
Comment 1 by bshe@chromium.org
, Jan 9 2018