New issue
Advanced search Search tips

Issue 800553 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Gn bootstrap fails

Reported by juanka85...@gmail.com, Jan 9 2018

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.108 Safari/537.36

Steps to reproduce the problem:
1. Download cromium tarball
2. Compile ninja
3. 

What is the expected behavior?
Build it  

What went wrong?
https://p.teknik.io/Raw/CfpoJ

Did this work before? N/A 

Chrome version: 65.0.3315.3  Channel: dev
OS Version: 65.0.3315.3
Flash Version: 

add this file at base/synchronization/synchronization_flags.h

https://raw.githubusercontent.com/bn0785ac/in-dev/master/synchronization_flags.h
 
it worked at last dev version
if somebody wants add regression tag
Labels: -Type-Bug Type-Bug-Regression
Owner: thomasanderson@chromium.org
Status: Started (was: Unconfirmed)
Summary: Gn bootstrap fails (was: Build ninja its impossible)

Comment 4 by sl1pk...@gmail.com, Jan 10 2018

seems that file is never store in the repo. is a autogenerated file, but how is generate?, what is the sintax of the build/write_buildflag_header.py [1] script for generate this file?


in the base/BUILD.gn show this[2]


greetings

[1] https://chromium.googlesource.com/chromium/src/+/master/build/write_buildflag_header.py
[2] https://chromium.googlesource.com/chromium/src/+/master/base/BUILD.gn#1767
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47b25a1f83f8166c6cd5cf1f13bf6dcce125511a

commit 47b25a1f83f8166c6cd5cf1f13bf6dcce125511a
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Wed Jan 10 01:39:11 2018

Fix gn bootstrap

BUG= 800553 
R=dpranke@chromium.org

Change-Id: I5c1cfeb7542bf990c59451aabcae7c120cbf09c0
Reviewed-on: https://chromium-review.googlesource.com/858276
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528197}
[modify] https://crrev.com/47b25a1f83f8166c6cd5cf1f13bf6dcce125511a/tools/gn/bootstrap/bootstrap.py

Status: Fixed (was: Started)

Sign in to add a comment