New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 800550 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Prune Herb variants

Project Member Reported by k...@chromium.org, Jan 9 2018

Issue description

As we decided not to proceed with Herb, we should clean up our Herb variants, keeping today's behavior.
 
Cc: bauerb@chromium.org yus...@chromium.org
@bauerb, @yusufo - FYI.
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64953ee1b0093f5c0f60773f4ca803224281f23a

commit 64953ee1b0093f5c0f60773f4ca803224281f23a
Author: Ted Choc <tedchoc@google.com>
Date: Wed Jan 17 03:44:39 2018

Trim Herb experiment from the code.

From a product standpoint, this is no longer something we wish
to pursue.

BUG= 800550 

Change-Id: Icded2f568fe60b021f1f46b8c41b3e184c111c7a
Reviewed-on: https://chromium-review.googlesource.com/861194
Commit-Queue: Ted Choc (back but slow, ping me) <tedchoc@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529582}
[modify] https://crrev.com/64953ee1b0093f5c0f60773f4ca803224281f23a/chrome/android/java/src/org/chromium/chrome/browser/ChromeSwitches.java
[modify] https://crrev.com/64953ee1b0093f5c0f60773f4ca803224281f23a/chrome/android/java/src/org/chromium/chrome/browser/LaunchIntentDispatcher.java
[modify] https://crrev.com/64953ee1b0093f5c0f60773f4ca803224281f23a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
[modify] https://crrev.com/64953ee1b0093f5c0f60773f4ca803224281f23a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java
[modify] https://crrev.com/64953ee1b0093f5c0f60773f4ca803224281f23a/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java
[modify] https://crrev.com/64953ee1b0093f5c0f60773f4ca803224281f23a/chrome/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceManager.java
[modify] https://crrev.com/64953ee1b0093f5c0f60773f4ca803224281f23a/chrome/android/java/src/org/chromium/chrome/browser/util/FeatureUtilities.java
[modify] https://crrev.com/64953ee1b0093f5c0f60773f4ca803224281f23a/chrome/android/javatests/src/org/chromium/chrome/browser/contextmenu/ContextMenuTest.java
[modify] https://crrev.com/64953ee1b0093f5c0f60773f4ca803224281f23a/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTestRule.java
[modify] https://crrev.com/64953ee1b0093f5c0f60773f4ca803224281f23a/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabFromChromeExternalNavigationTest.java
[modify] https://crrev.com/64953ee1b0093f5c0f60773f4ca803224281f23a/chrome/browser/about_flags.cc
[modify] https://crrev.com/64953ee1b0093f5c0f60773f4ca803224281f23a/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/64953ee1b0093f5c0f60773f4ca803224281f23a/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/64953ee1b0093f5c0f60773f4ca803224281f23a/chrome/common/chrome_switches.cc
[modify] https://crrev.com/64953ee1b0093f5c0f60773f4ca803224281f23a/chrome/common/chrome_switches.h
[modify] https://crrev.com/64953ee1b0093f5c0f60773f4ca803224281f23a/testing/variations/fieldtrial_testing_config.json
[modify] https://crrev.com/64953ee1b0093f5c0f60773f4ca803224281f23a/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Assigned)

Sign in to add a comment