[root layer scrolls] AccessibilityHitTestingBrowserTest fails |
|||
Issue descriptionThe following test fails in the content_browsertests step on ten trybots: AccessibilityHitTestingBrowserTest.CachingAsyncHitTestingInIframes On some bots the same test is run by other recipe steps, such as: mus_content_browsertests viz_content_browsertests network_service_content_browsertests site_per_process_content_browsertests The affected bots are: https://ci.chromium.org/buildbot/tryserver.chromium.linux/linux_chromium_rel_ng/620275 https://ci.chromium.org/buildbot/tryserver.chromium.linux/linux_chromium_asan_rel_ng/521864 https://ci.chromium.org/buildbot/tryserver.chromium.linux/linux_chromium_tsan_rel_ng/227446 https://ci.chromium.org/buildbot/tryserver.chromium.linux/cast_shell_linux/517283 https://ci.chromium.org/buildbot/tryserver.chromium.mac/mac_chromium_rel_ng/623932 https://ci.chromium.org/buildbot/tryserver.chromium.win/win10_chromium_x64_rel_ng/58124 https://ci.chromium.org/buildbot/tryserver.chromium.win/win7_chromium_rel_ng/76819 https://ci.chromium.org/buildbot/tryserver.chromium.chromiumos/linux-chromeos-rel/34722 https://ci.chromium.org/buildbot/tryserver.chromium.android/android_n5x_swarming_rel/336788 https://ci.chromium.org/buildbot/tryserver.chromium.android/linux_android_rel_ng/464058 The output includes: ../../content/browser/accessibility/hit_testing_browsertest.cc:216: Failure Expected equality of these values: ui::AX_ROLE_BUTTON Which is: 11 hit_node->GetRole() Which is: 46
,
Jan 17 2018
,
Jan 17 2018
,
Jan 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/98f17c6ef1426ccf152ba1f474b295b969a1e4c8 commit 98f17c6ef1426ccf152ba1f474b295b969a1e4c8 Author: David Bokan <bokan@chromium.org> Date: Wed Jan 17 18:06:11 2018 Fix AXObject::GetRelativeBounds for root-layer-scrolls This method computes the object's bounds within its container. If the container is scrollable the method adjust the local bounds by the scroll offset. LayoutView is/was exceptional because it doesn't itself scroll; thus, objects contained by the LayoutView mustn't adjust by the scroll offset. However, LayoutView does report itself as scrollable and returns a ScrollableArea (the FrameView, which is used for scrolling) so there exists an exception in this code to avoid the scroll offset adjustment. root-layer-scrolling removes the exception in how LayoutView works and uses the regular PaintLayerScrollableArea machinery to scroll frames. This means objects whose container is LayoutView need to be adjusted by the scroll offset to be relative to their container. This CL removes the exceptional case if the RLS flag is enabled. Bug: 800542 Change-Id: I16ecc5789ae93fed107d2bbf5776b2fbd5358793 Reviewed-on: https://chromium-review.googlesource.com/869170 Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: Steve Kobes <skobes@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#529801} [modify] https://crrev.com/98f17c6ef1426ccf152ba1f474b295b969a1e4c8/third_party/WebKit/Source/modules/accessibility/AXObject.cpp
,
Jan 17 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bokan@chromium.org
, Jan 16 2018Owner: bokan@chromium.org