New issue
Advanced search Search tips

Issue 800542 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 800527



Sign in to add a comment

[root layer scrolls] AccessibilityHitTestingBrowserTest fails

Project Member Reported by skobes@chromium.org, Jan 9 2018

Issue description

Comment 1 by bokan@chromium.org, Jan 16 2018

Cc: -bokan@chromium.org
Owner: bokan@chromium.org

Comment 2 by bokan@chromium.org, Jan 17 2018

Status: Started (was: Available)

Comment 3 by bokan@chromium.org, Jan 17 2018

Cc: bokan@chromium.org
 Issue 800555  has been merged into this issue.
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98f17c6ef1426ccf152ba1f474b295b969a1e4c8

commit 98f17c6ef1426ccf152ba1f474b295b969a1e4c8
Author: David Bokan <bokan@chromium.org>
Date: Wed Jan 17 18:06:11 2018

Fix AXObject::GetRelativeBounds for root-layer-scrolls

This method computes the object's bounds within its container. If the
container is scrollable the method adjust the local bounds by the scroll
offset. LayoutView is/was exceptional because it doesn't itself scroll;
thus, objects contained by the LayoutView mustn't adjust by the scroll
offset. However, LayoutView does report itself as scrollable and returns
a ScrollableArea (the FrameView, which is used for scrolling) so there
exists an exception in this code to avoid the scroll offset adjustment.

root-layer-scrolling removes the exception in how LayoutView works and
uses the regular PaintLayerScrollableArea machinery to scroll frames.
This means objects whose container is LayoutView need to be adjusted by
the scroll offset to be relative to their container. This CL removes the
exceptional case if the RLS flag is enabled.

Bug:  800542 
Change-Id: I16ecc5789ae93fed107d2bbf5776b2fbd5358793
Reviewed-on: https://chromium-review.googlesource.com/869170
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529801}
[modify] https://crrev.com/98f17c6ef1426ccf152ba1f474b295b969a1e4c8/third_party/WebKit/Source/modules/accessibility/AXObject.cpp

Comment 5 by bokan@chromium.org, Jan 17 2018

Status: Fixed (was: Started)

Sign in to add a comment