New issue
Advanced search Search tips

Issue 800524 link

Starred by 1 user
Status: Fixed
Owner:
katie@chromium.org
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug
Team-Accessibility



Sign in to add a comment

Select-to-Speak integration tests

Project Member Reported by katie@chromium.org, Jan 9 2018 
More integrations! More tests!


Tests are being added to select_to_speak/*.extjs under the build target select_to_speak_extension_tests.

More detailed tests need to be added!

And here's a comment from Dominic on other ways to test:

<body>
  <p>Here is some text</p>
  <script>
    var p = document.querySelector('p');
    var range = document.createRange();
    range.selectNodeContents(document.querySelector('p'););
    window.getSelection().addRange(range);
  </script>
</body>
Basically I think there are some ranges you could get via the DOM
or via selecting with the mouse or keyboard that wouldn't be possible
to select using chrome.automation.setDocumentSelection, and we should
be able to test them all.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 6 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ac210b255a1c76a0e48a7665fc5160f237b12cd

commit 4ac210b255a1c76a0e48a7665fc5160f237b12cd
Author: Katie D <katie@chromium.org>
Date: Tue Feb 06 21:45:01 2018

Adds some integration tests for select-to-speak search+mouse selection.

This increases test coverage in select-to-speak by creating a class to
be responsible for JS extension end-to-end tests for search+mouse.

Bug:  800524 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I81cbe9eee1965e5bb5c58dea8deee8eecffeda45
Reviewed-on: https://chromium-review.googlesource.com/898251
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534801}
[modify] https://crrev.com/4ac210b255a1c76a0e48a7665fc5160f237b12cd/chrome/browser/resources/chromeos/select_to_speak/BUILD.gn
[modify] https://crrev.com/4ac210b255a1c76a0e48a7665fc5160f237b12cd/chrome/browser/resources/chromeos/select_to_speak/mock_tts.js
[modify] https://crrev.com/4ac210b255a1c76a0e48a7665fc5160f237b12cd/chrome/browser/resources/chromeos/select_to_speak/select_to_speak.js
[modify] https://crrev.com/4ac210b255a1c76a0e48a7665fc5160f237b12cd/chrome/browser/resources/chromeos/select_to_speak/select_to_speak_e2e_test_base.js
[modify] https://crrev.com/4ac210b255a1c76a0e48a7665fc5160f237b12cd/chrome/browser/resources/chromeos/select_to_speak/select_to_speak_keystroke_selection_test.extjs
[add] https://crrev.com/4ac210b255a1c76a0e48a7665fc5160f237b12cd/chrome/browser/resources/chromeos/select_to_speak/select_to_speak_mouse_selection_test.extjs

Comment 2 by katie@chromium.org, Feb 7 2018

Status: Fixed (was: Started)
►

Sign in to add a comment