New issue
Advanced search Search tips

Issue 800518 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jan 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression

Blocking:
issue 762073



Sign in to add a comment

0.4% regression in sizes at 528011:528011

Project Member Reported by benjhayden@google.com, Jan 9 2018

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=800518

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=c7d1a862ab3a42c22930d418d0f51e6036b9240e11ab3c64fd3c3a94f6ee5325


Bot(s) for this bug's original alert(s):

win

Comment 2 by thakis@chromium.org, Jan 10 2018

I'm guessing this is assigned to me because of https://chromium-review.googlesource.com/c/853243/

As mentioned in the Cl description, it's true that this increases mini_installer size -- but not the one we ship to users, which gets uncab'd, signed, and re-cab'd, and I didn't change the re-cab'ing step. The signing is done on an internal server, so the perf bot doesn't measure what we ship here.

So probably fine to WontFix?
Status: WontFix (was: Assigned)
Rationale in #2 for WontFix sgtm. Thanks for the explanation!

Comment 4 by thakis@chromium.org, Jan 10 2018

Blocking: 762073

Sign in to add a comment