Chrome Version: M66 OS: Win Once crbug.com/793381 is fully launched, we can remove all logic corresponding to persisting if the Cleanup card needs to be shown at the top of the Settings page.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ac431fda478ace0ba6af428e07d278a485b7c89e commit ac431fda478ace0ba6af428e07d278a485b7c89e Author: Fabio Tirelo <ftirelo@chromium.org> Date: Tue Feb 20 17:22:37 2018 Add user-initiated cleanups field trial to testing config BUG: 800507 Change-Id: I979dc51418f494bc1aa11fcf6954b78ceffdc075 Reviewed-on: https://chromium-review.googlesource.com/924319 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#537807} [modify] https://crrev.com/ac431fda478ace0ba6af428e07d278a485b7c89e/testing/variations/fieldtrial_testing_config.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e5145cb7e2d152448c69df2bfdcaf64b2c03fe9a commit e5145cb7e2d152448c69df2bfdcaf64b2c03fe9a Author: Fabio Tirelo <ftirelo@chromium.org> Date: Mon Mar 19 21:34:27 2018 Chrome Cleaner UI: Enable user-initiated cleanups by default Bug: 800507 Change-Id: I650e3289a9348a9e350cc5a071fd9fac87aa1e88 Reviewed-on: https://chromium-review.googlesource.com/969581 Reviewed-by: Joe Mason <joenotcharles@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#544166} [modify] https://crrev.com/e5145cb7e2d152448c69df2bfdcaf64b2c03fe9a/chrome/browser/safe_browsing/chrome_cleaner/srt_field_trial_win.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d17fdfbca5658d147f6126b2662948d3ff9d4f9e commit d17fdfbca5658d147f6126b2662948d3ff9d4f9e Author: Hans Wennborg <hans@chromium.org> Date: Fri Mar 23 14:35:58 2018 Revert "Chrome Cleaner UI: Enable user-initiated cleanups by default" This reverts commit e5145cb7e2d152448c69df2bfdcaf64b2c03fe9a. Reason for revert: This broke browser_tests SettingsAccessibilityTest.EDIT_DICTIONARY_aria_valid_attr_value in Chrome-branded builds (see bug). Original change's description: > Chrome Cleaner UI: Enable user-initiated cleanups by default > > Bug: 800507 > Change-Id: I650e3289a9348a9e350cc5a071fd9fac87aa1e88 > Reviewed-on: https://chromium-review.googlesource.com/969581 > Reviewed-by: Joe Mason <joenotcharles@chromium.org> > Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#544166} TBR=joenotcharles@chromium.org,ftirelo@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 800507 , 824494 Change-Id: Id59344fc7ebf03c6d8d7370067b9fea10192ea3c Reviewed-on: https://chromium-review.googlesource.com/977907 Reviewed-by: Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#545438} [modify] https://crrev.com/d17fdfbca5658d147f6126b2662948d3ff9d4f9e/chrome/browser/safe_browsing/chrome_cleaner/srt_field_trial_win.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8a798e91d36750367fc72a92edaf6ee80e535639 commit 8a798e91d36750367fc72a92edaf6ee80e535639 Author: Fabio Tirelo <ftirelo@chromium.org> Date: Tue Mar 27 16:09:40 2018 Reland: Enable user-initiated cleanups by default Bug: 800507 Change-Id: I6c519b8e83a8875eba17e80559e31817498ecd16 Reviewed-on: https://chromium-review.googlesource.com/982094 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#546125} [modify] https://crrev.com/8a798e91d36750367fc72a92edaf6ee80e535639/chrome/browser/safe_browsing/chrome_cleaner/srt_field_trial_win.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/21b577114d8016e7fcec4dd4c5b43de56d26d98f commit 21b577114d8016e7fcec4dd4c5b43de56d26d98f Author: Fabio Tirelo <ftirelo@chromium.org> Date: Thu Apr 19 15:00:22 2018 Remove user-initiated cleanup feature The feature was launched to 100% and this removes occurrences of the feature variable as well as corresponding dependencies. The most important change here is that we no longer show the cleanup card at the top of the Settings page (the feature enabled it to be shown on its own card), and we could get rid of all the corresponding complexity. Bug: 800507 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8fdf4b6beca6bd4f287bb10fe88a4b0a1d39dc36 Reviewed-on: https://chromium-review.googlesource.com/994184 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by: Jialiu Lin <jialiul@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#552016} [modify] https://crrev.com/21b577114d8016e7fcec4dd4c5b43de56d26d98f/chrome/browser/resources/settings/basic_page/basic_page.html [modify] https://crrev.com/21b577114d8016e7fcec4dd4c5b43de56d26d98f/chrome/browser/resources/settings/basic_page/basic_page.js [modify] https://crrev.com/21b577114d8016e7fcec4dd4c5b43de56d26d98f/chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.html [modify] https://crrev.com/21b577114d8016e7fcec4dd4c5b43de56d26d98f/chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.js [modify] https://crrev.com/21b577114d8016e7fcec4dd4c5b43de56d26d98f/chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_proxy.js [modify] https://crrev.com/21b577114d8016e7fcec4dd4c5b43de56d26d98f/chrome/browser/resources/settings/chrome_cleanup_page/items_to_remove_list.html [modify] https://crrev.com/21b577114d8016e7fcec4dd4c5b43de56d26d98f/chrome/browser/resources/settings/chrome_cleanup_page/items_to_remove_list.js [modify] https://crrev.com/21b577114d8016e7fcec4dd4c5b43de56d26d98f/chrome/browser/resources/settings/reset_page/reset_page.html [modify] https://crrev.com/21b577114d8016e7fcec4dd4c5b43de56d26d98f/chrome/browser/resources/settings/reset_page/reset_page.js [modify] https://crrev.com/21b577114d8016e7fcec4dd4c5b43de56d26d98f/chrome/browser/resources/settings/route.js [modify] https://crrev.com/21b577114d8016e7fcec4dd4c5b43de56d26d98f/chrome/browser/safe_browsing/BUILD.gn [modify] https://crrev.com/21b577114d8016e7fcec4dd4c5b43de56d26d98f/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_impl_win.cc [modify] https://crrev.com/21b577114d8016e7fcec4dd4c5b43de56d26d98f/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_impl_win.h [modify] https://crrev.com/21b577114d8016e7fcec4dd4c5b43de56d26d98f/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_impl_win_unittest.cc [modify] https://crrev.com/21b577114d8016e7fcec4dd4c5b43de56d26d98f/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_win.h [modify] https://crrev.com/21b577114d8016e7fcec4dd4c5b43de56d26d98f/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_navigation_util_win.cc [modify] https://crrev.com/21b577114d8016e7fcec4dd4c5b43de56d26d98f/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_reboot_dialog_controller_impl_browsertest_win.cc [delete] https://crrev.com/1a7230270bf548cf31e8d53122b559db3eb023ec/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_state_change_observer_win.cc [delete] https://crrev.com/1a7230270bf548cf31e8d53122b559db3eb023ec/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_state_change_observer_win.h [modify] https://crrev.com/21b577114d8016e7fcec4dd4c5b43de56d26d98f/chrome/browser/safe_browsing/chrome_cleaner/mock_chrome_cleaner_controller_win.h [modify] https://crrev.com/21b577114d8016e7fcec4dd4c5b43de56d26d98f/chrome/browser/safe_browsing/chrome_cleaner/reporter_runner_browsertest_win.cc [modify] https://crrev.com/21b577114d8016e7fcec4dd4c5b43de56d26d98f/chrome/browser/safe_browsing/chrome_cleaner/srt_field_trial_win.h [modify] https://crrev.com/21b577114d8016e7fcec4dd4c5b43de56d26d98f/chrome/browser/ui/webui/settings/chrome_cleanup_handler.cc [modify] https://crrev.com/21b577114d8016e7fcec4dd4c5b43de56d26d98f/chrome/browser/ui/webui/settings/chrome_cleanup_handler.h [modify] https://crrev.com/21b577114d8016e7fcec4dd4c5b43de56d26d98f/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/21b577114d8016e7fcec4dd4c5b43de56d26d98f/chrome/browser/ui/webui/settings/md_settings_ui.cc [modify] https://crrev.com/21b577114d8016e7fcec4dd4c5b43de56d26d98f/chrome/browser/ui/webui/settings/md_settings_ui.h [modify] https://crrev.com/21b577114d8016e7fcec4dd4c5b43de56d26d98f/chrome/test/data/webui/settings/chrome_cleanup_page_test.js
Comment 1 by bugdroid1@chromium.org
, Feb 20 2018