New issue
Advanced search Search tips

Issue 800504 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature

Blocking:
issue 725683


Participants' hotlists:
Fixing-touch


Sign in to add a comment

Cros splitscreen - Support Arc App windows in split screen.

Project Member Reported by x...@chromium.org, Jan 9 2018

Issue description

Chrome Version: 65.0.3316.0
OS: Chrome

What steps will reproduce the problem?
(1) Enter tablet mode
(2) Open a resizable Arc app window
(3) Enter overview mode
(4) Try to snap the Arc app window to one side of the screen 

What is the expected result?
It should snapped successfully. Press on the split divider bar should resize the Arc app window smoothly.

 
Labels: Hotlist-Fixing-touch

Comment 2 by x...@chromium.org, Feb 8 2018

Oops. Forgot link the CL https://chromium-review.googlesource.com/c/chromium/src/+/854763 to this issue. Chrome side CL has been landed. I'll land Android side CLs once we have a green Chrome PFQ.

Comment 3 by x...@chromium.org, Feb 8 2018

Cc: x...@chromium.org osh...@chromium.org
 Issue 800480  has been merged into this issue.
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/645f8b491a3e7d1db5cf82150858de1cc80b81cf

commit 645f8b491a3e7d1db5cf82150858de1cc80b81cf
Author: xdai <xdai@chromium.org>
Date: Thu Feb 08 18:32:19 2018

Cros splitscreen: Set Arc App windows not draggable in tablet mode.

It's the case for Chrome browser/App windows, we should make it the same for Arc App windows.
If we do not disable the drag ability for resizable Arc App windows, it may be possible that
user can press on the edge of the window and resize it directly in splitscreen, other than
resize it using the split divider bar.

Bug:  800504 
Change-Id: I773fc9512893a5203fae69dc3c308a56b7ab31e2
Reviewed-on: https://chromium-review.googlesource.com/887801
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535449}
[modify] https://crrev.com/645f8b491a3e7d1db5cf82150858de1cc80b81cf/ash/wm/tablet_mode/tablet_mode_window_manager_unittest.cc
[modify] https://crrev.com/645f8b491a3e7d1db5cf82150858de1cc80b81cf/ash/wm/tablet_mode/tablet_mode_window_state.cc
[modify] https://crrev.com/645f8b491a3e7d1db5cf82150858de1cc80b81cf/ash/wm/window_state.cc
[modify] https://crrev.com/645f8b491a3e7d1db5cf82150858de1cc80b81cf/ash/wm/window_state.h
[modify] https://crrev.com/645f8b491a3e7d1db5cf82150858de1cc80b81cf/ash/wm/wm_toplevel_window_event_handler.cc
[modify] https://crrev.com/645f8b491a3e7d1db5cf82150858de1cc80b81cf/ash/wm/workspace/workspace_window_resizer.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Feb 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b15ad719b4b0fabf786dc95d850d53d59acfe1e4

commit b15ad719b4b0fabf786dc95d850d53d59acfe1e4
Author: Xiaoqian Dai <xdai@chromium.org>
Date: Wed Feb 21 21:43:33 2018

Cros splitscreen: Smooth resize for Arc Apps.

It works well for single Arc apps in split screen. But with two Arc apps in split screen,
only one Arc app can be smoothly resized (currently it's always the window that was stacked
above the other).

Bug: 725683,  800504 
Change-Id: I862627c7b078c29da43b61a13885002371da595a
Reviewed-on: https://chromium-review.googlesource.com/917043
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538216}
[modify] https://crrev.com/b15ad719b4b0fabf786dc95d850d53d59acfe1e4/ash/wm/splitview/split_view_controller.cc
[modify] https://crrev.com/b15ad719b4b0fabf786dc95d850d53d59acfe1e4/ash/wm/splitview/split_view_controller.h

Comment 6 by x...@chromium.org, Mar 2 2018

Status: Fixed (was: Assigned)

Sign in to add a comment