[MD Extensions] Turn on MD Extensions by default on ToT |
|||||||||
Issue descriptionAs we are preparing for a Stable launch, it seems like a good idea (similar to what other MD WebUI pages did), to make MD Extensions the default on ToT builds. Note that quite a few test fail when doing so, since they expect the old page. So the feature needs to be turned off within the context of such tests. Will post a list of failing tests shortly.
,
Jan 10 2018
Pasting list of failing tests below (from https://build.chromium.org/deprecated/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/620502) ExtensionSettingsWebUITest.testChromeSendHandled LazyBackgroundPageApiTest.UpdateExtensionsPage BasicExtensionSettingsWebUITest.testNonEmptyExtensionList InstallGoodExtensionSettingsWebUITest.showOptions BasicExtensionSettingsWebUITest.testEnable ExtensionSettingsWebUITest.testEmptyExtensionList ManagedExtensionSettingsWebUITest.testAccessibility BasicExtensionSettingsWebUITest.testUninstall BasicExtensionSettingsWebUITest.testDeveloperModeManyExtensions BasicExtensionSettingsWebUITest.testDisable SettingsCommandsExtensionSettingsWebUITest.extensionSettingsUri OptionsDialogExtensionSettingsWebUITest.testAccessibility InstallGoodExtensionSettingsWebUITest.testAccessibility DownloadTest.ChromeURLAfterDownload SettingsCommandsExtensionSettingsWebUITest.testChromeSendHandler PolicyTest.DeveloperToolsDisabledExtensionsDevMode AutoScrollExtensionSettingsWebUITest.testAutoScroll
,
Jan 10 2018
,
Jan 10 2018
,
Jan 10 2018
,
Jan 13 2018
Additional failing tests discovered, ChromeOS only KioskAppSettingsWebUITest.testAddKioskAppByDoneButton KioskAppSettingsWebUITest.testEnableDisableAutoLaunch KioskAppSettingsWebUITest.testCheckDisableBailout KioskAppSettingsWebUITest.testRemoveKioskApp KioskAppSettingsWebUITest.testUpdateApp KioskAppSettingsWebUITest.testAddKioskApp NoConsumerKioskWebUITest.settingsHidden KioskAppSettingsWebUITest.testOpenKioskAppSettings KioskAppSettingsWebUITest.testAddKioskAppByAddButton KioskAppSettingsWebUITest.testAllowDisableBailout KioskAppSettingsWebUITest.testShowError KioskAppSettingsWebUITest.testHideDisableBailout
,
Jan 13 2018
,
Jan 18 2018
,
Jan 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7c5e8d9314992f511b349f0db9663a29261cebf6 commit 7c5e8d9314992f511b349f0db9663a29261cebf6 Author: dpapad <dpapad@chromium.org> Date: Fri Jan 19 22:16:15 2018 Extensions UI: Make DownloadTest.ChromeURLAfterDownload agnostic to the UI. TBR=dtrainor Bug: 800502 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie8c3da370937be820ac0622947f4693c68e03fea Reviewed-on: https://chromium-review.googlesource.com/871570 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#530631} [modify] https://crrev.com/7c5e8d9314992f511b349f0db9663a29261cebf6/chrome/browser/download/download_browsertest.cc [modify] https://crrev.com/7c5e8d9314992f511b349f0db9663a29261cebf6/chrome/browser/resources/extensions/extensions.js
,
Jan 24 2018
,
Jan 25 2018
,
Jan 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8d170b8707234ed6415a470c39aeb43a396cdd53 commit 8d170b8707234ed6415a470c39aeb43a396cdd53 Author: dpapad <dpapad@chromium.org> Date: Tue Jan 30 01:18:06 2018 MD Extensions: Port LazyBackgroundPageApiTest.UpdateExtensionsPage to new UI. Bug: 800502 Change-Id: I059c10360312df02b040e3e87667b8a39abce09c Reviewed-on: https://chromium-review.googlesource.com/891627 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#532714} [modify] https://crrev.com/8d170b8707234ed6415a470c39aeb43a396cdd53/chrome/browser/extensions/lazy_background_page_apitest.cc
,
Jan 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/243daae82c765221c4ed7f344bf66d2698136b1d commit 243daae82c765221c4ed7f344bf66d2698136b1d Author: Makoto Shimazu <shimazu@chromium.org> Date: Tue Jan 30 05:23:04 2018 Revert "MD Extensions: Port LazyBackgroundPageApiTest.UpdateExtensionsPage to new UI." This reverts commit 8d170b8707234ed6415a470c39aeb43a396cdd53. Reason for revert: The test added by this CL is flaky. Original change's description: > MD Extensions: Port LazyBackgroundPageApiTest.UpdateExtensionsPage to new UI. > > Bug: 800502 > Change-Id: I059c10360312df02b040e3e87667b8a39abce09c > Reviewed-on: https://chromium-review.googlesource.com/891627 > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#532714} TBR=rdevlin.cronin@chromium.org,dpapad@chromium.org Change-Id: I58b2acc0496a3c901e57fc240d96059ff50248ed No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 800502 , 807153 Reviewed-on: https://chromium-review.googlesource.com/892658 Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#532772} [modify] https://crrev.com/243daae82c765221c4ed7f344bf66d2698136b1d/chrome/browser/extensions/lazy_background_page_apitest.cc
,
Jan 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9aeacf29cb33bd53db2856610d6e04ca714b55b3 commit 9aeacf29cb33bd53db2856610d6e04ca714b55b3 Author: dpapad <dpapad@chromium.org> Date: Wed Jan 31 20:49:04 2018 MD Extensions: Port LazyBackgroundPageApiTest.UpdateExtensionsPage to new UI (again). 2nd attempt. Previous attempt flaked on some bots, This time using a MutationObserver instead of polling the UI. Bug: 800502 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I3a1890add83a93be4455ab9a04518fe16269eab3 Reviewed-on: https://chromium-review.googlesource.com/894297 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#533394} [modify] https://crrev.com/9aeacf29cb33bd53db2856610d6e04ca714b55b3/chrome/browser/extensions/lazy_background_page_apitest.cc [modify] https://crrev.com/9aeacf29cb33bd53db2856610d6e04ca714b55b3/chrome/browser/resources/md_extensions/detail_view.html [modify] https://crrev.com/9aeacf29cb33bd53db2856610d6e04ca714b55b3/chrome/browser/resources/md_extensions/detail_view.js
,
Jan 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1c568f71c3313b549d1f3df223c9226416ee990f commit 1c568f71c3313b549d1f3df223c9226416ee990f Author: Demetrios Papadopoulos <dpapad@chromium.org> Date: Wed Jan 31 23:23:28 2018 Revert "MD Extensions: Port LazyBackgroundPageApiTest.UpdateExtensionsPage to new UI (again)." This reverts commit 9aeacf29cb33bd53db2856610d6e04ca714b55b3. Reason for revert: Flaked again, see https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=LazyBackgroundPageApiTest.UpdateExtensionsPage_MD Original change's description: > MD Extensions: Port LazyBackgroundPageApiTest.UpdateExtensionsPage to new UI (again). > > 2nd attempt. Previous attempt flaked on some bots, This time using a > MutationObserver instead of polling the UI. > > Bug: 800502 > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: I3a1890add83a93be4455ab9a04518fe16269eab3 > Reviewed-on: https://chromium-review.googlesource.com/894297 > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533394} TBR=rdevlin.cronin@chromium.org,dpapad@chromium.org Change-Id: Ifcfc1d83c40df1077b4e3a73c14f174e8b11608b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 800502 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/896484 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#533471} [modify] https://crrev.com/1c568f71c3313b549d1f3df223c9226416ee990f/chrome/browser/extensions/lazy_background_page_apitest.cc [modify] https://crrev.com/1c568f71c3313b549d1f3df223c9226416ee990f/chrome/browser/resources/md_extensions/detail_view.html [modify] https://crrev.com/1c568f71c3313b549d1f3df223c9226416ee990f/chrome/browser/resources/md_extensions/detail_view.js
,
Feb 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1d9beb96d2862cba33cecd848753e6d7f4cbc641 commit 1d9beb96d2862cba33cecd848753e6d7f4cbc641 Author: dpapad <dpapad@chromium.org> Date: Wed Feb 07 15:46:11 2018 MD Extensions: Ensure custom ExtensionOptions element is registered before used. This fixes a case that only reproduced during testing (ASAN only), where the ExtensionOptions custom element was not registered yet by the time it was created. Bug: 800502 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I71453b53042cfb2dd4eada557223c255d2e78a58 Reviewed-on: https://chromium-review.googlesource.com/905521 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#535008} [modify] https://crrev.com/1d9beb96d2862cba33cecd848753e6d7f4cbc641/chrome/browser/resources/md_extensions/options_dialog.js
,
Feb 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dfa3260ac4018426e5f6b63911d17e500e7c6380 commit dfa3260ac4018426e5f6b63911d17e500e7c6380 Author: dpapad <dpapad@chromium.org> Date: Wed Feb 07 21:15:47 2018 MD Extensions: Enable by default on ToT builds. TBR=atwilson Bug: 800502 Change-Id: I827b23793d87770228b29f0e7c0ea65e3d455c73 Reviewed-on: https://chromium-review.googlesource.com/857814 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#535145} [modify] https://crrev.com/dfa3260ac4018426e5f6b63911d17e500e7c6380/chrome/browser/extensions/lazy_background_page_apitest.cc [modify] https://crrev.com/dfa3260ac4018426e5f6b63911d17e500e7c6380/chrome/browser/policy/policy_browsertest.cc [modify] https://crrev.com/dfa3260ac4018426e5f6b63911d17e500e7c6380/chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_browsertest.js [modify] https://crrev.com/dfa3260ac4018426e5f6b63911d17e500e7c6380/chrome/browser/ui/webui/extensions/extension_settings_browsertest.js [modify] https://crrev.com/dfa3260ac4018426e5f6b63911d17e500e7c6380/chrome/common/chrome_features.cc
,
Feb 7 2018
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by dpa...@chromium.org
, Jan 9 2018Status: Assigned (was: Untriaged)