New issue
Advanced search Search tips

Issue 800501 link

Starred by 1 user
Status: Fixed
Owner:
x...@chromium.org
Closed: Jan 2018
Cc:
omrilio@chromium.org
zork@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 725683


Participants' hotlists:
Fixing-touch


Sign in to add a comment

Cros Splitscreen - disable the splitscreen for M65 stable but keep it enabled for other channels

Project Member Reported by x...@chromium.org, Jan 9 2018 
Chrome Version: (copy from chrome://version)
OS: Chrome

We've decided to punt the splitscreen in tablet mode (see launch bug 789304) to M66, and thus we will disable the feature for M65 stable but will still keep it enabled for other channels to keep receiving user feedbacks.

It will be enabled for all channels starting from M66.

Comment 1 by omrilio@chromium.org, Jan 10 2018

Labels: Hotlist-Fixing-touch
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 17 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7458fbc6ca2ff2fcf38bb4320183d3304fbea671

commit 7458fbc6ca2ff2fcf38bb4320183d3304fbea671
Author: Stephen McGruer <smcgruer@chromium.org>
Date: Wed Jan 17 19:47:51 2018

Revert "Cros splitscreen: Disable the splitscreen for M65 stable but keep it enabled for all other channels."

This reverts commit 0b50e9bff0858f771c6abd299a3388545cc36b03.

Reason for revert: Broke Google Chrome ChromeOS build:

https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20ChromeOS/44493

Original change's description:
> Cros splitscreen: Disable the splitscreen for M65 stable but keep it enabled for all other channels.
> 
> This CL will be reverted after M65 is cut.
> 
> Bug:  800501 
> Change-Id: I8f4597f7855e2ff2c25ba6c0bb0584b8c04d8831
> Reviewed-on: https://chromium-review.googlesource.com/869196
> Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
> Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#529845}

TBR=oshima@chromium.org,xdai@chromium.org

Change-Id: Ia6d9cafd4b8d3ee77f9fa762568a0a1a14ca02df
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  800501 
Reviewed-on: https://chromium-review.googlesource.com/871330
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529853}
[modify] https://crrev.com/7458fbc6ca2ff2fcf38bb4320183d3304fbea671/ash/public/cpp/ash_switches.cc
[modify] https://crrev.com/7458fbc6ca2ff2fcf38bb4320183d3304fbea671/ash/public/cpp/ash_switches.h
[modify] https://crrev.com/7458fbc6ca2ff2fcf38bb4320183d3304fbea671/ash/wm/splitview/split_view_controller.cc
[modify] https://crrev.com/7458fbc6ca2ff2fcf38bb4320183d3304fbea671/chrome/browser/about_flags.cc
[modify] https://crrev.com/7458fbc6ca2ff2fcf38bb4320183d3304fbea671/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/7458fbc6ca2ff2fcf38bb4320183d3304fbea671/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/7458fbc6ca2ff2fcf38bb4320183d3304fbea671/tools/metrics/histograms/enums.xml
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 17 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ddccd3f6dba62870a038ecb7d68b28038fcbe5d9

commit ddccd3f6dba62870a038ecb7d68b28038fcbe5d9
Author: xdai <xdai@chromium.org>
Date: Wed Jan 17 22:34:16 2018

[Reland] Cros splitscreen: Disable the splitscreen for M65 stable but keep it enabled for all other channels.

This CL will be reverted after M65 is cut.

TBR=oshima@chromium.org

Bug:  800501 
Change-Id: I35d388efcb6fc4e2ee6d1e51842e1f2bed823c12
Reviewed-on: https://chromium-review.googlesource.com/869196
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#529845}
Reviewed-on: https://chromium-review.googlesource.com/871504
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529924}
[modify] https://crrev.com/ddccd3f6dba62870a038ecb7d68b28038fcbe5d9/ash/public/cpp/ash_switches.cc
[modify] https://crrev.com/ddccd3f6dba62870a038ecb7d68b28038fcbe5d9/ash/public/cpp/ash_switches.h
[modify] https://crrev.com/ddccd3f6dba62870a038ecb7d68b28038fcbe5d9/ash/wm/splitview/split_view_controller.cc
[modify] https://crrev.com/ddccd3f6dba62870a038ecb7d68b28038fcbe5d9/chrome/browser/about_flags.cc
[modify] https://crrev.com/ddccd3f6dba62870a038ecb7d68b28038fcbe5d9/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/ddccd3f6dba62870a038ecb7d68b28038fcbe5d9/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/ddccd3f6dba62870a038ecb7d68b28038fcbe5d9/tools/metrics/histograms/enums.xml
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 29 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d45327d66e2cfe58c4174fd4cf00deb0e0aad46f

commit d45327d66e2cfe58c4174fd4cf00deb0e0aad46f
Author: xdai <xdai@chromium.org>
Date: Mon Jan 29 18:57:07 2018

Revert "Cros splitscreen: Disable the splitscreen for M65 stable but keep it enabled for all other channels."

This reverts commit ddccd3f6dba62870a038ecb7d68b28038fcbe5d9:
https://chromium-review.googlesource.com/c/chromium/src/+/869196

M65 has been cut. This CL is no longer needed. Revert it.

Bug:  800501 
TBR: oshima@chromium.org
Change-Id: I1943f27874fa83b67ca7d42e1b292f93f52f86a0
Reviewed-on: https://chromium-review.googlesource.com/887878
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532520}
[modify] https://crrev.com/d45327d66e2cfe58c4174fd4cf00deb0e0aad46f/ash/public/cpp/ash_switches.cc
[modify] https://crrev.com/d45327d66e2cfe58c4174fd4cf00deb0e0aad46f/ash/public/cpp/ash_switches.h
[modify] https://crrev.com/d45327d66e2cfe58c4174fd4cf00deb0e0aad46f/ash/wm/splitview/split_view_controller.cc
[modify] https://crrev.com/d45327d66e2cfe58c4174fd4cf00deb0e0aad46f/chrome/browser/about_flags.cc
[modify] https://crrev.com/d45327d66e2cfe58c4174fd4cf00deb0e0aad46f/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/d45327d66e2cfe58c4174fd4cf00deb0e0aad46f/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/d45327d66e2cfe58c4174fd4cf00deb0e0aad46f/tools/metrics/histograms/enums.xml

Comment 6 by x...@chromium.org, Jan 29 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment