New issue
Advanced search Search tips

Issue 800498 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 725683


Participants' hotlists:
Fixing-touch


Sign in to add a comment

Windows in split view still have title bars.

Project Member Reported by sammiequon@chromium.org, Jan 9 2018

Issue description

(1) Enter tablet mode then overview mode.
(2) Snap two chrome apps.

What is the expected result?
No title bars.

What happens instead?
Yes title bars.

 

Comment 1 by x...@chromium.org, Jan 9 2018

Blocking: 725683
Labels: Hotlist-Fixing-touch
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b4b0badbfb6ffcd2fb57e1aa90ae9dd9e4c611b

commit 9b4b0badbfb6ffcd2fb57e1aa90ae9dd9e4c611b
Author: Sammie Quon <sammiequon@google.com>
Date: Tue Jan 30 23:55:13 2018

cros: Hide title bar when window in splitview mode.

Test: ash_unittests CustomFrameViewAshTest.HeaderVisibilityInSplitview
Bug:  800498 
Change-Id: I8bbf318cf1406d788c0b48d9812ca3f15d74c4ae
Reviewed-on: https://chromium-review.googlesource.com/858217
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533095}
[modify] https://crrev.com/9b4b0badbfb6ffcd2fb57e1aa90ae9dd9e4c611b/ash/frame/custom_frame_view_ash.cc
[modify] https://crrev.com/9b4b0badbfb6ffcd2fb57e1aa90ae9dd9e4c611b/ash/frame/custom_frame_view_ash_unittest.cc
[modify] https://crrev.com/9b4b0badbfb6ffcd2fb57e1aa90ae9dd9e4c611b/ash/frame/header_view.cc
[modify] https://crrev.com/9b4b0badbfb6ffcd2fb57e1aa90ae9dd9e4c611b/ash/wm/tablet_mode/tablet_mode_controller.cc
[modify] https://crrev.com/9b4b0badbfb6ffcd2fb57e1aa90ae9dd9e4c611b/ash/wm/tablet_mode/tablet_mode_controller.h
[modify] https://crrev.com/9b4b0badbfb6ffcd2fb57e1aa90ae9dd9e4c611b/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc
[modify] https://crrev.com/9b4b0badbfb6ffcd2fb57e1aa90ae9dd9e4c611b/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.h
[modify] https://crrev.com/9b4b0badbfb6ffcd2fb57e1aa90ae9dd9e4c611b/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash_browsertest.cc

Status: Fixed (was: Assigned)
Cc: minch@chromium.org sammiequon@chromium.org
 Issue 808156  has been merged into this issue.

Sign in to add a comment