New issue
Advanced search Search tips

Issue 800417 link

Starred by 1 user
Status: WontFix
Owner:
steve...@chromium.org
Closed: Jan 2018
Cc:
alemate@chromium.org
afakhry@chromium.org
jamescook@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug
nightlight



Sign in to add a comment

Move NightLightClient to src/ash

Project Member Reported by steve...@chromium.org, Jan 9 2018 
NightLightClient does not appear to have any src/chrome dependencies. We should move the clas to src/ash.

Comment 1 by afakhry@chromium.org, Jan 9 2018

Cc: alemate@chromium.org
This is the client that lives in chrome and connects to ash via mojo. It depends on the SimpleGeolocationProvider which needs chrome to be able to send IP-based geolocation requests.

Comment 2 by steve...@chromium.org, Jan 9 2018 

Hmm I see. It's not clear why we could just add SimpleGeolocationProvider to Ash, which already depends on src/net.

That said, this is fine, I will move the initialization to ChromeBrowserExtraPartsAsh then and add a comment.

Comment 3 by steve...@chromium.org, Jan 9 2018

Status: WontFix (was: Available)
Ah, and we use the chrome system request context for these, which might be a hassle to change for Ash.

Moved to ChromeBrowserExtraPartsAsh in https://chromium-review.googlesource.com/c/chromium/src/+/857322.
►

Sign in to add a comment