New issue
Advanced search Search tips

Issue 800384 link

Starred by 1 user
Status: Fixed
Owner:
perezju@chromium.org
Closed: Jan 2018
Cc:
nedngu...@google.com
jdufault@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Write basic tests that create CrosBrowser with mocked cri

Project Member Reported by jdufault@chromium.org, Jan 9 2018
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 9 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/2320fe5ebdafcb214cca4da90fe544d9e1b0dfcc

commit 2320fe5ebdafcb214cca4da90fe544d9e1b0dfcc
Author: Juan Antonio Navarro Perez <perezju@google.com>
Date: Tue Jan 09 17:59:53 2018

[Telemetry] Fix typo in CrOSBrowserWithOOBE

NOTRY=True
Bug:  chromium:800384 
Change-Id: If978eaf35e425c2a6ace593963adeb667d600bc1
Reviewed-on: https://chromium-review.googlesource.com/857511
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Achuith Bhandarkar <achuith@chromium.org>

[modify] https://crrev.com/2320fe5ebdafcb214cca4da90fe544d9e1b0dfcc/telemetry/telemetry/internal/backends/chrome/cros_browser_with_oobe.py

Comment 2 by perezju@chromium.org, Jan 9 2018 

Sorry for the breakage. That should fix the problem.

Still, you can leave this bug open and assigned to me. I should add some basic tests, at least instantiate some CrosBrowser with the cri mocked out, so that very simple mistakes like this are caught earlier.

Comment 3 by jdufault@chromium.org, Jan 9 2018 

> Still, you can leave this bug open and assigned to me. I should add some basic tests, at least instantiate some CrosBrowser with the cri mocked out, so that very simple mistakes like this are caught earlier.

That'd be fantastic, thank you.

Comment 5 by perezju@chromium.org, Jan 10 2018

Components: Tests>Telemetry
Labels: -Pri-1 Pri-3
Summary: Write basic tests that create CrosBrowser with mocked cri (was: pfq informational starting to fail due to telemetry error: 'CrosPlatformBackend' object has no attribute 'startup_args' on bots)
Lowering Pri as bots are back to green.

Comment 6 by perezju@chromium.org, Jan 10 2018

Cc: nedngu...@google.com

Comment 7 by perezju@chromium.org, Jan 23 2018

Status: Started (was: Untriaged)
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/c03f122f4f15cdc80532d29e9c2de0364e393481

commit c03f122f4f15cdc80532d29e9c2de0364e393481
Author: Juan Antonio Navarro Perez <perezju@google.com>
Date: Wed Jan 24 13:19:26 2018

[Telemetry] Add CrOSBrowserMockCreationTest

Add a few tests to ensure a CrOS browser can be created by Telemetry
APIs and classes, mocking out the platform and other components.

This is done so that tests can run without having access to an actual
cros device, and help to catch some kinds of errors earlier on the
catapult CQ.

Test surface covered includes methods in all of:
- PossibleCrOSBrowser
- CrOSBrowserBackend
- CrOSBrowserWithOOBE

Bug:  chromium:800384 
Change-Id: Ie18d88820de3fb07ccaea422be1b864ddb4ee3ea
Reviewed-on: https://chromium-review.googlesource.com/881562
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>

[modify] https://crrev.com/c03f122f4f15cdc80532d29e9c2de0364e393481/telemetry/telemetry/internal/backends/chrome/cros_browser_finder_unittest.py

Comment 9 by perezju@chromium.org, Jan 24 2018

Status: Fixed (was: Started)
►

Sign in to add a comment