New issue
Advanced search Search tips

Issue 800373 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----

Blocked on:
issue 708158



Sign in to add a comment

PrerenderBrowserTest.PrerenderNoCommitNoSwap in network_service_browser_tests failing on chromium.linux/Linux Tests (dbg)(1)(32)

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Jan 9 2018

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of dmazzoni@chromium.org

PrerenderBrowserTest.PrerenderNoCommitNoSwap in network_service_browser_tests failing on chromium.linux/Linux Tests (dbg)(1)(32)

Builders failed on: 
- Linux Tests (dbg)(1)(32): 
  https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29


 
Blockedon: 708158
Components: Internals>Preload
Owner: a.obzhirov@samsung.com
Status: Assigned (was: Available)
[ RUN      ] PrerenderBrowserTest.PrerenderNoCommitNoSwap
Xlib:  extension "RANDR" missing on display ":99".
Fontconfig warning: "/etc/fonts/fonts.conf", line 146: blank doesn't take any effect anymore. please remove it from your fonts.conf
[27074:27100:0109/084405.822683:WARNING:child_process_launcher_helper_posix.cc(118)] Ignoring invalid file v8_context_snapshot.bin
[27074:27112:0109/084405.859641:ERROR:bus.cc(394)] Failed to connect to the bus: Could not parse server address: Unknown address type (examples of valid types are "tcp" and on UNIX "unix")
[27074:27074:0109/084405.911161:WARNING:password_store_factory.cc(241)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options.
[27074:27100:0109/084406.066722:WARNING:child_process_launcher_helper_posix.cc(118)] Ignoring invalid file v8_context_snapshot.bin
[27110:27110:0109/084406.585646:WARNING:gpu_info.cc(104)] No active GPU found, returning primary GPU.
[27115:27151:0109/084406.838779:WARNING:simple_synchronous_entry.cc(1174)] Could not open platform files for entry.
[27074:27100:0109/084407.002080:WARNING:child_process_launcher_helper_posix.cc(118)] Ignoring invalid file v8_context_snapshot.bin
[27074:27136:0109/084407.093103:WARNING:embedded_test_server.cc(228)] Request not handled. Returning 404: /favicon.ico
../../chrome/browser/prerender/prerender_test_utils.cc:355: Failure
Expected equality of these values:
  expected_final_status_
    Which is: 46
  final_status()
    Which is: 0
 when testing URL / (Expected: Navigation Uncommitted, Actual: Used)
../../chrome/browser/prerender/prerender_test_utils.cc:373: Failure
Expected equality of these values:
  should_be_shown_
    Which is: false
  was_shown_
    Which is: true
[27074:27074:0109/084407.667658:INFO:chrome_cryptauth_service.cc(233)] Profile is not authenticated yet; waiting before starting CryptAuth managers.
[27074:27074:0109/084407.806488:WARNING:url_request_context_getter.cc(43)] URLRequestContextGetter leaking due to no owning thread.
[  FAILED  ] PrerenderBrowserTest.PrerenderNoCommitNoSwap, where TypeParam =  and GetParam() =  (4931 ms)


Owner: pasko@chromium.org

Comment 3 by pasko@chromium.org, Jan 9 2018

Cc: clamy@chromium.org jam@chromium.org
We have another recent flake in  crbug.com/800311  with one relatively clear change to blame. Let me disable the test and avoid reverting the change to observe for a day or two if/how something else would flake ...

Comment 4 by jam@chromium.org, Jan 9 2018

Thanks, I can take a look at the flakiness today. Sorry about that.

Comment 5 by jam@chromium.org, Jan 9 2018

@pasko: if it's flaking just on network service, then it can be disabled in testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4ca33fbd5e0e972583787edcb3190dc953aa1a2

commit f4ca33fbd5e0e972583787edcb3190dc953aa1a2
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Tue Jan 09 18:11:11 2018

Disable PrerenderBrowserTest.MAYBE_PrerenderNoCommitNoSwap on Linux dbg

TBR=pasko@chromium.org

Bug:  800373 ,708158
Change-Id: Ifa2e13b823161bc4fee015e7ea46d44568b36098
Reviewed-on: https://chromium-review.googlesource.com/857579
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528046}
[modify] https://crrev.com/f4ca33fbd5e0e972583787edcb3190dc953aa1a2/chrome/browser/prerender/prerender_browsertest.cc

Comment 7 by pasko@google.com, Jan 9 2018

jam: disabling on all of OS_LINUX is OK in short term I think. Thank you for looking at details. 

Comment 8 by jam@chromium.org, Jan 10 2018

Owner: jam@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c99340513fbb467c3c5345f0be88c357b3e64702

commit c99340513fbb467c3c5345f0be88c357b3e64702
Author: John Abd-El-Malek <jam@chromium.org>
Date: Wed Jan 10 18:12:37 2018

Fix flakes with prerender browser tests on network service.

The problem was with the new CreateHangingFirstRequestInterceptor implementation for the network service case. Returning "true" from the URLLoaderInterceptor isn't enough to hang the frame request, as the URLLoaderClient interfaceptr's destruction will lead to an error in the renderer and an error page will commit. Prerendering code would then think that the prerender has committed and can be used.

Bug:  800373 
Change-Id: Id5b8e20fcec8850b9b00d57cbae803102d95d59d
Reviewed-on: https://chromium-review.googlesource.com/857961
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528355}
[modify] https://crrev.com/c99340513fbb467c3c5345f0be88c357b3e64702/chrome/browser/prerender/prerender_browsertest.cc

Comment 10 by jam@chromium.org, Jan 10 2018

Status: Fixed (was: Started)

Sign in to add a comment