PrerenderBrowserTest.PrerenderNoCommitNoSwap in network_service_browser_tests failing on chromium.linux/Linux Tests (dbg)(1)(32) |
|||||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of dmazzoni@chromium.org PrerenderBrowserTest.PrerenderNoCommitNoSwap in network_service_browser_tests failing on chromium.linux/Linux Tests (dbg)(1)(32) Builders failed on: - Linux Tests (dbg)(1)(32): https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29
,
Jan 9 2018
,
Jan 9 2018
We have another recent flake in crbug.com/800311 with one relatively clear change to blame. Let me disable the test and avoid reverting the change to observe for a day or two if/how something else would flake ...
,
Jan 9 2018
Thanks, I can take a look at the flakiness today. Sorry about that.
,
Jan 9 2018
@pasko: if it's flaking just on network service, then it can be disabled in testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
,
Jan 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f4ca33fbd5e0e972583787edcb3190dc953aa1a2 commit f4ca33fbd5e0e972583787edcb3190dc953aa1a2 Author: Dominic Mazzoni <dmazzoni@chromium.org> Date: Tue Jan 09 18:11:11 2018 Disable PrerenderBrowserTest.MAYBE_PrerenderNoCommitNoSwap on Linux dbg TBR=pasko@chromium.org Bug: 800373 ,708158 Change-Id: Ifa2e13b823161bc4fee015e7ea46d44568b36098 Reviewed-on: https://chromium-review.googlesource.com/857579 Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#528046} [modify] https://crrev.com/f4ca33fbd5e0e972583787edcb3190dc953aa1a2/chrome/browser/prerender/prerender_browsertest.cc
,
Jan 9 2018
jam: disabling on all of OS_LINUX is OK in short term I think. Thank you for looking at details.
,
Jan 10 2018
,
Jan 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c99340513fbb467c3c5345f0be88c357b3e64702 commit c99340513fbb467c3c5345f0be88c357b3e64702 Author: John Abd-El-Malek <jam@chromium.org> Date: Wed Jan 10 18:12:37 2018 Fix flakes with prerender browser tests on network service. The problem was with the new CreateHangingFirstRequestInterceptor implementation for the network service case. Returning "true" from the URLLoaderInterceptor isn't enough to hang the frame request, as the URLLoaderClient interfaceptr's destruction will lead to an error in the renderer and an error page will commit. Prerendering code would then think that the prerender has committed and can be used. Bug: 800373 Change-Id: Id5b8e20fcec8850b9b00d57cbae803102d95d59d Reviewed-on: https://chromium-review.googlesource.com/857961 Reviewed-by: Yuzhu Shen <yzshen@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#528355} [modify] https://crrev.com/c99340513fbb467c3c5345f0be88c357b3e64702/chrome/browser/prerender/prerender_browsertest.cc
,
Jan 10 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by dmazz...@chromium.org
, Jan 9 2018Components: Internals>Preload
Owner: a.obzhirov@samsung.com
Status: Assigned (was: Available)