New issue
Advanced search Search tips

Issue 800368 link

Starred by 1 user
Status: Fixed
Owner:
rtoy@chromium.org
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

DEBUG_AUDIONODE_REFERENCES doesn't compile

Project Member Reported by rtoy@chromium.org, Jan 9 2018 
Changes in the code base to use scoped_refptr has caused DEBUG_AUDIONODE_REFERENCES to bitrot.  Update code so that this works again.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 9 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b539679fb9afa742b1a41d7d0ef14cecbee3377

commit 5b539679fb9afa742b1a41d7d0ef14cecbee3377
Author: Raymond Toy <rtoy@chromium.org>
Date: Tue Jan 09 19:47:52 2018

Make DEBUG_AUDIONODE_REFERENCES compile again

When DEBUG_AUDIONODE_REFERENCES is set to 1, the code fails to compile
because we call Get() on scoped_refptr.  It should be get().

To verify, set DEBUG_AUDIONODE_REFERENCES to 1 in AudioNode.h and
recompile.

Bug:  800368 
Test: None
Change-Id: I6d57506073570957e0cff4c5d657ac007fecf089
Reviewed-on: https://chromium-review.googlesource.com/857350
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528075}
[modify] https://crrev.com/5b539679fb9afa742b1a41d7d0ef14cecbee3377/third_party/WebKit/Source/modules/webaudio/AudioNode.cpp

Comment 2 by rtoy@chromium.org, Jan 10 2018

Status: Fixed (was: Started)
►

Sign in to add a comment