New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 800363 link

Starred by 1 user
Status: Fixed
Owner:
na...@chromium.org
Closed: Jan 2018
Cc:
█ awdf@chromium.org
peter@chromium.org
Components:
EstimatedDays: 2
NextAction: ----
OS: Android
Pri: 3
Type: ----

Blocked on:
issue 800361
Blocking:
issue 806982



Sign in to add a comment

Implement GetDisplayed() for Android O+

Project Member Reported by na...@chromium.org, Jan 9 2018 
Currently on Android devices, we don't synchronize the list of displayed notifications between Android's state (which can be queried via android.app.NotificationManager) and the state stored in the Notifications Database.

This results in a buggy experience because we just show information from the Notifications Database, which might not be up to date with the actual state stored on Android OS. For instance, if a user restarts their phone, GetDisplayed() will return old notifications that're no longer being shown on the phone.

This should be fixed by implementing NotificationPlatformBridgeAndroid::GetDisplayed() properly, wherein we return supports_synchronization set to true, and also return a set of notifications we can get from querying android.app.NotificationManager (getActiveNotifications())

Comment 1 by na...@chromium.org, Jan 9 2018

Blockedon: 800361

Comment 2 by na...@chromium.org, Jan 9 2018

Cc: -bever...@google.com awdf@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a99fad2c5b37e0ede596a45d891645300b26311c

commit a99fad2c5b37e0ede596a45d891645300b26311c
Author: Mugdha Lakhani <nator@chromium.org>
Date: Thu Jan 18 17:14:55 2018

[Android Notifications] Implement GetDisplayed() for Android O+

Bug:  800363 
Change-Id: I41bddcffac5ee7c94f9813872b8a825c1cc761c1
Reviewed-on: https://chromium-review.googlesource.com/871051
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Reviewed-by: Anita Woodruff <awdf@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530177}
[modify] https://crrev.com/a99fad2c5b37e0ede596a45d891645300b26311c/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationManagerProxy.java
[modify] https://crrev.com/a99fad2c5b37e0ede596a45d891645300b26311c/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationManagerProxyImpl.java
[modify] https://crrev.com/a99fad2c5b37e0ede596a45d891645300b26311c/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java
[modify] https://crrev.com/a99fad2c5b37e0ede596a45d891645300b26311c/chrome/browser/notifications/notification_platform_bridge_android.cc
[modify] https://crrev.com/a99fad2c5b37e0ede596a45d891645300b26311c/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/notifications/MockNotificationManagerProxy.java

Comment 4 by na...@chromium.org, Jan 19 2018

Status: Fixed (was: Assigned)

Comment 5 by kbr@chromium.org, Feb 3 2018

Blocking: 806982
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 5 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/631048a10bb7eddb9da7dc812bb8d20eebc264a2

commit 631048a10bb7eddb9da7dc812bb8d20eebc264a2
Author: Mugdha Lakhani <nator@chromium.org>
Date: Mon Feb 05 16:19:58 2018

Revert "[Android Notifications] Implement GetDisplayed() for Android O+"

This reverts commit a99fad2c5b37e0ede596a45d891645300b26311c.
See  Issue 806982  for details.

Bug:  806982 ,  800363 
Change-Id: I08672ec28eb607cb6686fbb3dfd9673caee8eb9b
Reviewed-on: https://chromium-review.googlesource.com/901606
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534395}
[modify] https://crrev.com/631048a10bb7eddb9da7dc812bb8d20eebc264a2/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationManagerProxy.java
[modify] https://crrev.com/631048a10bb7eddb9da7dc812bb8d20eebc264a2/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationManagerProxyImpl.java
[modify] https://crrev.com/631048a10bb7eddb9da7dc812bb8d20eebc264a2/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java
[modify] https://crrev.com/631048a10bb7eddb9da7dc812bb8d20eebc264a2/chrome/browser/notifications/notification_platform_bridge_android.cc
[modify] https://crrev.com/631048a10bb7eddb9da7dc812bb8d20eebc264a2/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/notifications/MockNotificationManagerProxy.java
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 6 2018

Labels: merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9411fa0e94916c3987ce86b125480e3db1e8a282

commit 9411fa0e94916c3987ce86b125480e3db1e8a282
Author: Mugdha Lakhani <nator@chromium.org>
Date: Tue Feb 06 16:24:57 2018

Revert "[Android Notifications] Implement GetDisplayed() for Android O+"

This reverts commit a99fad2c5b37e0ede596a45d891645300b26311c.
See  Issue 806982  for details.

(cherry picked from commit 631048a10bb7eddb9da7dc812bb8d20eebc264a2)

Bug:  806982 ,  800363 
Change-Id: I08672ec28eb607cb6686fbb3dfd9673caee8eb9b
Reviewed-on: https://chromium-review.googlesource.com/901606
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#534395}
Reviewed-on: https://chromium-review.googlesource.com/904664
Cr-Commit-Position: refs/branch-heads/3325@{#346}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/9411fa0e94916c3987ce86b125480e3db1e8a282/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationManagerProxy.java
[modify] https://crrev.com/9411fa0e94916c3987ce86b125480e3db1e8a282/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationManagerProxyImpl.java
[modify] https://crrev.com/9411fa0e94916c3987ce86b125480e3db1e8a282/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java
[modify] https://crrev.com/9411fa0e94916c3987ce86b125480e3db1e8a282/chrome/browser/notifications/notification_platform_bridge_android.cc
[modify] https://crrev.com/9411fa0e94916c3987ce86b125480e3db1e8a282/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/notifications/MockNotificationManagerProxy.java
►

Sign in to add a comment