New issue
Advanced search Search tips

Issue 800330 link

Starred by 1 user
Status: Fixed
Owner:
gambard@chromium.org
Closed: Jan 2018
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task



Sign in to add a comment

Adaptive Toolbar: Have a way to interact with secondary and primary toolbar

Project Member Reported by gambard@chromium.org, Jan 9 2018 
BVC and other classes are interacting with one object (as delegate or directly to send commands).
With the adaptive toolbar, they will need to interact with multiple objects (secondary and primary toolbar). A solution needs to be found to interact with both.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 9 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a675a2d2356ee0751b821bba21fc4190900c4691

commit a675a2d2356ee0751b821bba21fc4190900c4691
Author: gambard <gambard@chromium.org>
Date: Tue Jan 09 17:55:21 2018

Move triggerToolsMenuButtonAnimation to ToolbarCommands

This CL moves the triggerToolsMenuButtonAnimation method to the
ToolbarCommands protocol.
Also it removes this protocol from the one implemented by the
BrowserCommands protocol.

Bug:  800330 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I81573cb5965e4f3cb5e8b72d44acb9d1bd1bcfc3
Reviewed-on: https://chromium-review.googlesource.com/857179
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528038}
[modify] https://crrev.com/a675a2d2356ee0751b821bba21fc4190900c4691/ios/chrome/browser/ui/browser_view_controller.h
[modify] https://crrev.com/a675a2d2356ee0751b821bba21fc4190900c4691/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/a675a2d2356ee0751b821bba21fc4190900c4691/ios/chrome/browser/ui/browser_view_controller_dependency_factory.h
[modify] https://crrev.com/a675a2d2356ee0751b821bba21fc4190900c4691/ios/chrome/browser/ui/browser_view_controller_dependency_factory.mm
[modify] https://crrev.com/a675a2d2356ee0751b821bba21fc4190900c4691/ios/chrome/browser/ui/commands/browser_commands.h
[modify] https://crrev.com/a675a2d2356ee0751b821bba21fc4190900c4691/ios/chrome/browser/ui/commands/toolbar_commands.h
[modify] https://crrev.com/a675a2d2356ee0751b821bba21fc4190900c4691/ios/chrome/browser/ui/ntp/new_tab_page_toolbar_controller.h
[modify] https://crrev.com/a675a2d2356ee0751b821bba21fc4190900c4691/ios/chrome/browser/ui/ntp/new_tab_page_toolbar_controller.mm
[modify] https://crrev.com/a675a2d2356ee0751b821bba21fc4190900c4691/ios/chrome/browser/ui/stack_view/stack_view_controller.mm
[modify] https://crrev.com/a675a2d2356ee0751b821bba21fc4190900c4691/ios/chrome/browser/ui/stack_view/stack_view_toolbar_controller.h
[modify] https://crrev.com/a675a2d2356ee0751b821bba21fc4190900c4691/ios/chrome/browser/ui/stack_view/stack_view_toolbar_controller.mm
[modify] https://crrev.com/a675a2d2356ee0751b821bba21fc4190900c4691/ios/chrome/browser/ui/tab_switcher/tab_switcher.h
[modify] https://crrev.com/a675a2d2356ee0751b821bba21fc4190900c4691/ios/chrome/browser/ui/toolbar/clean/toolbar_button_factory.h
[modify] https://crrev.com/a675a2d2356ee0751b821bba21fc4190900c4691/ios/chrome/browser/ui/toolbar/clean/toolbar_button_factory.mm
[modify] https://crrev.com/a675a2d2356ee0751b821bba21fc4190900c4691/ios/chrome/browser/ui/toolbar/clean/toolbar_coordinator.h
[modify] https://crrev.com/a675a2d2356ee0751b821bba21fc4190900c4691/ios/chrome/browser/ui/toolbar/legacy_toolbar_coordinator.h
[modify] https://crrev.com/a675a2d2356ee0751b821bba21fc4190900c4691/ios/chrome/browser/ui/toolbar/legacy_toolbar_coordinator.mm
[modify] https://crrev.com/a675a2d2356ee0751b821bba21fc4190900c4691/ios/chrome/browser/ui/toolbar/toolbar_adapter.h
[modify] https://crrev.com/a675a2d2356ee0751b821bba21fc4190900c4691/ios/chrome/browser/ui/toolbar/toolbar_adapter.mm
[modify] https://crrev.com/a675a2d2356ee0751b821bba21fc4190900c4691/ios/chrome/browser/ui/toolbar/toolbar_controller.h
[modify] https://crrev.com/a675a2d2356ee0751b821bba21fc4190900c4691/ios/chrome/browser/ui/toolbar/toolbar_controller.mm
[modify] https://crrev.com/a675a2d2356ee0751b821bba21fc4190900c4691/ios/chrome/browser/ui/toolbar/web_toolbar_controller.h
[modify] https://crrev.com/a675a2d2356ee0751b821bba21fc4190900c4691/ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 11 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/948048cd18a5ee8de7eea167e2d93844442b2f5f

commit 948048cd18a5ee8de7eea167e2d93844442b2f5f
Author: Gauthier Ambard <gambard@chromium.org>
Date: Thu Jan 11 12:38:26 2018

Create interface for toolbar coordinators

This CL creates a ToolbarCoordinatorAdaptor, allowing other objects to
communicate with both toolbars without having to take into account the
real number of toolbars (one or two).
It also adds the ToolsMenu as a child coordinator of this adaptor.
Having it as a child coordinator of the adaptor allows the coordinator
to have the ToolsMenuCommands to be dispatched. If we have one child
coordinator in each toolbar, the dispatcher wouldn't know to which
coordinator to dispatch the method calls.

Bug:  798418 ,  800330 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I780eb9a5446824824f8af2cd068115f4714121ca
Reviewed-on: https://chromium-review.googlesource.com/861626
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528606}
[modify] https://crrev.com/948048cd18a5ee8de7eea167e2d93844442b2f5f/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/948048cd18a5ee8de7eea167e2d93844442b2f5f/ios/chrome/browser/ui/toolbar/adaptive/BUILD.gn
[modify] https://crrev.com/948048cd18a5ee8de7eea167e2d93844442b2f5f/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_coordinator.h
[modify] https://crrev.com/948048cd18a5ee8de7eea167e2d93844442b2f5f/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_coordinator.mm
[add] https://crrev.com/948048cd18a5ee8de7eea167e2d93844442b2f5f/ios/chrome/browser/ui/toolbar/adaptive/toolbar_coordinator_adaptor.h
[add] https://crrev.com/948048cd18a5ee8de7eea167e2d93844442b2f5f/ios/chrome/browser/ui/toolbar/adaptive/toolbar_coordinator_adaptor.mm
[modify] https://crrev.com/948048cd18a5ee8de7eea167e2d93844442b2f5f/ios/chrome/browser/ui/toolbar/legacy_toolbar_coordinator.h
[modify] https://crrev.com/948048cd18a5ee8de7eea167e2d93844442b2f5f/ios/chrome/browser/ui/toolbar/public/BUILD.gn
[modify] https://crrev.com/948048cd18a5ee8de7eea167e2d93844442b2f5f/ios/chrome/browser/ui/toolbar/public/primary_toolbar_coordinator.h
[add] https://crrev.com/948048cd18a5ee8de7eea167e2d93844442b2f5f/ios/chrome/browser/ui/toolbar/public/toolbar_coordinating.h
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 11 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d485ddb7839dda79e47164bf181ea79f2131cdb

commit 4d485ddb7839dda79e47164bf181ea79f2131cdb
Author: Gauthier Ambard <gambard@chromium.org>
Date: Thu Jan 11 12:43:44 2018

Use the ToolbarAdaptor in BVC

This CL modifies BVC such as it is now forwarding calls to the toolbar
adaptor when it needs to send calls to both toolbars or the legacy
toolbar.

Bug:  800330 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ia35bc9baf7997a8c2726a4ed439a879dce698d8b
Reviewed-on: https://chromium-review.googlesource.com/860043
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528607}
[modify] https://crrev.com/4d485ddb7839dda79e47164bf181ea79f2131cdb/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/4d485ddb7839dda79e47164bf181ea79f2131cdb/ios/chrome/browser/ui/toolbar/public/primary_toolbar_coordinator.h
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 17 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c632112c0a96d971870f47637390f181595f252

commit 1c632112c0a96d971870f47637390f181595f252
Author: Gauthier Ambard <gambard@chromium.org>
Date: Wed Jan 17 15:58:33 2018

Add mediator to the AdaptiveToolbar

This CL adds the ToolbarMediator to the adaptive toolbar.
It allows the adaptive toolbar to have the progress bar and the buttons
updated to match the desired state of the page.

Bug:  800330 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I4fdf67d5436536e1055dfbcd508b79aa8941f6d4
Reviewed-on: https://chromium-review.googlesource.com/866719
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529755}
[modify] https://crrev.com/1c632112c0a96d971870f47637390f181595f252/ios/chrome/browser/ui/toolbar/adaptive/BUILD.gn
[modify] https://crrev.com/1c632112c0a96d971870f47637390f181595f252/ios/chrome/browser/ui/toolbar/adaptive/adaptive_toolbar_coordinator.mm
[modify] https://crrev.com/1c632112c0a96d971870f47637390f181595f252/ios/chrome/browser/ui/toolbar/adaptive/adaptive_toolbar_view.h
[modify] https://crrev.com/1c632112c0a96d971870f47637390f181595f252/ios/chrome/browser/ui/toolbar/adaptive/adaptive_toolbar_view_controller.h
[modify] https://crrev.com/1c632112c0a96d971870f47637390f181595f252/ios/chrome/browser/ui/toolbar/adaptive/adaptive_toolbar_view_controller.mm
[modify] https://crrev.com/1c632112c0a96d971870f47637390f181595f252/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view.mm
[modify] https://crrev.com/1c632112c0a96d971870f47637390f181595f252/ios/chrome/browser/ui/toolbar/adaptive/secondary_toolbar_view.mm
[modify] https://crrev.com/1c632112c0a96d971870f47637390f181595f252/ios/chrome/browser/ui/toolbar/clean/BUILD.gn
[modify] https://crrev.com/1c632112c0a96d971870f47637390f181595f252/ios/chrome/browser/ui/toolbar/clean/toolbar_button_factory.h
[modify] https://crrev.com/1c632112c0a96d971870f47637390f181595f252/ios/chrome/browser/ui/toolbar/clean/toolbar_button_factory.mm
[add] https://crrev.com/1c632112c0a96d971870f47637390f181595f252/ios/chrome/browser/ui/toolbar/clean/toolbar_tab_grid_button.h
[add] https://crrev.com/1c632112c0a96d971870f47637390f181595f252/ios/chrome/browser/ui/toolbar/clean/toolbar_tab_grid_button.mm

Comment 5 by gambard@chromium.org, Jan 18 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment