Issue metadata
Sign in to add a comment
|
Passphrase info bar disappears on opening new tab from tab switcher mode |
||||||||||||||||||||||
Issue descriptionApp Version: 65.0.3316.0 Canary iOS Version: 11.2.1 Device: iPhoneX only Steps to reproduce: 1. Launch chrome and sign in with the account having passphrase 2. Go to tab switcher mode 3. Tap on + icon 4. Go to tab switcher mode and tap on menu>>new tab button Observed results: At step 3 & 4 notice the passphrase info bar appears and disappears Expected results: Passphrase info bar should be displayed. Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: Not tested Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA Bug reproducible on current stable build (App Version, iOS Version): No on M63 Bug reproducible on the current beta channel build (App Version, iOS Version): No on M64 Link to video/image: M65 canary behavior: https://drive.google.com/file/d/12VxfHMgYmT_nlzvRybwK5kbZB32aUMnu/view?usp=sharing M64 beta behavior: https://drive.google.com/file/d/19hF6y0fqCugZ74l5qSwMbxA_bVExwGcJ/view?usp=sharing
,
Jan 10 2018
,
Jan 24 2018
A CL is in flight.
,
Jan 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cfe94ea22586185ad7b372a9d949ec8fe3d9c096 commit cfe94ea22586185ad7b372a9d949ec8fe3d9c096 Author: edchin <edchin@chromium.org> Date: Wed Jan 24 17:23:54 2018 [ios] Fix infobar bug on iPhoneX In BVC, a second call to |-setUpViewLayout:| exists after startup to handle safe area insets for iPhoneX. In this second call, it is not necessary to update the infobar frame. This CL skips the infobar frame setting in the second call, which is only done on iPhoneX. Bug: 800314 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id58b3d607903e79d8d5518efc3adfc7521d4d75a Reviewed-on: https://chromium-review.googlesource.com/882842 Reviewed-by: edchin <edchin@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#531582} [modify] https://crrev.com/cfe94ea22586185ad7b372a9d949ec8fe3d9c096/ios/chrome/browser/ui/browser_view_controller.mm
,
Jan 24 2018
,
Jan 30 2018
Verified on chrome canary version 66.0.3335.0 on iPhone X with iOS 11.2.2, following steps mentioned in comment #0. Passphrase infobar do not disappear. Looks good. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by sczs@chromium.org
, Jan 10 2018Owner: edchin@chromium.org
Status: Assigned (was: Untriaged)