Issue metadata
Sign in to add a comment
|
Regression:Download entries overlap on download shelf.
Reported by
pranjali...@etouch.net,
Jan 9 2018
|
||||||||||||||||||||||
Issue descriptionChrome Version: 65.0.3315.3 (Official Build) e3b7a8643b5a46f3483a85bb20d25213b84a8906-refs/branch-heads/3315@{#4} OS: Mac(10.12.6,10.13.3) Pre-condition: Enabled 'Force UI direction' flag and ‘Enable RTL’ flags from chrome://flags. Steps to reproduce: 1.Launch chrome and Navigate https://permission.site/ 2.Click on 'Auto download' button and click on ‘allow’ button on bubble. 3.Now again click on ‘Auto Download’ button 3-4 times and observe download shelf. Actual Result: Download entries overlap on download shelf. Expected Result: Download entries should not overlap on download shelf. This is a regression issue, broken in M-63 series, Using the per-revision bisect providing the bisect results, Good Build:63.0.3211.0 (Revision : 500754) Bad Build:63.0.3212.0 (Revision : 500792) You are probably looking for a change made after 500754 (known good), but no later than 500755 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/518f9539aed9dc8d9da94910dd741db015ce42dc..9375b89fa1a2d1b14165e21bd497686ab9e4362f Suspect:https://chromium.googlesource.com/chromium/src/+/9375b89fa1a2d1b14165e21bd497686ab9e4362f sdy@: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. NOTE: 1. Above issue is not reproducible on windows(7,8.1,10) and Linux(14.04 LTS) OS. 2.Issue is also seen on M-63 stable (build #63.0.3239.132),M64 Beta(build #64.0.3282.71) Kindly refer attached screen cast
,
Jan 16 2018
We're not planning any further M63 releases. +abdulsyed@ to evaluate for M64.
,
Jan 16 2018
I don't think RTL is on for users (and probably won't be launched with the old shelf), so I'm going to bump this to M65.
,
Jan 16 2018
,
Jan 22 2018
Friendly ping to get an update on this issue as it is marked as m65 stable blocker.
,
Jan 24 2018
I'm uploading a fix for this now, but it shouldn't block stable since it only affects RTL, which isn't launched yet.
,
Jan 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/945625ed5f17d1bef1cb0850dbc733f95a5a3c83 commit 945625ed5f17d1bef1cb0850dbc733f95a5a3c83 Author: Sidney San Martín <sdy@chromium.org> Date: Wed Jan 24 13:05:12 2018 Fix non-MD download shelf layout broken under RTL. RTL isn't planning to launch without MD downloads, but the non-MD shelf still shouldn't be broken under RTL. This change makes sure to only do RTL transformations for MD downloads. Bug: 800302 Change-Id: I16913eb0d766f8b34a280cf7e62b0b554feef5ff Reviewed-on: https://chromium-review.googlesource.com/882822 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#531512} [modify] https://crrev.com/945625ed5f17d1bef1cb0850dbc733f95a5a3c83/chrome/browser/ui/cocoa/download/download_item_controller.mm [modify] https://crrev.com/945625ed5f17d1bef1cb0850dbc733f95a5a3c83/chrome/browser/ui/cocoa/download/download_shelf_controller.mm
,
Jan 24 2018
,
Jan 24 2018
,
Jan 25 2018
,
Jan 25 2018
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 25 2018
Pls merge your change to M65 branch 3325 ASAP so we can pick it up for next M65 dev release. Thank you.
,
Jan 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b0fe6ffd179822cacdf053fc753554046ed8a718 commit b0fe6ffd179822cacdf053fc753554046ed8a718 Author: Sidney San Martín <sdy@chromium.org> Date: Thu Jan 25 19:28:53 2018 Fix non-MD download shelf layout broken under RTL. RTL isn't planning to launch without MD downloads, but the non-MD shelf still shouldn't be broken under RTL. This change makes sure to only do RTL transformations for MD downloads. TBR=sdy@chromium.org (cherry picked from commit 945625ed5f17d1bef1cb0850dbc733f95a5a3c83) Bug: 800302 Change-Id: I16913eb0d766f8b34a280cf7e62b0b554feef5ff Reviewed-on: https://chromium-review.googlesource.com/882822 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#531512} Reviewed-on: https://chromium-review.googlesource.com/887382 Reviewed-by: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#95} Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369} [modify] https://crrev.com/b0fe6ffd179822cacdf053fc753554046ed8a718/chrome/browser/ui/cocoa/download/download_item_controller.mm [modify] https://crrev.com/b0fe6ffd179822cacdf053fc753554046ed8a718/chrome/browser/ui/cocoa/download/download_shelf_controller.mm
,
Jan 25 2018
Thanks for verifying!
,
Feb 2 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ranjitkan@chromium.org
, Jan 9 2018Labels: RegressedIn-63 ReleaseBlock-Stable Target-65 FoundIn-64 FoundIn-65 Target-63 FoundIn-63 Target-64