New issue
Advanced search Search tips

Issue 800286 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Jan 2018
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

The PartitionAllocTest.PurgeDiscardable case in base_unittests crashed on Loongson.

Reported by wangqing...@loongson.cn, Jan 9 2018

Issue description

UserAgent: Mozilla/5.0 (X11; Linux mips64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3096.2 Safari/537.36

Steps to reproduce the problem:
1. build base_unittests
2. run base_unittests

What is the expected behavior?
passed this test case.

What went wrong?
Note: Google Test filter = PartitionAllocTest.PurgeDiscardable
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from PartitionAllocTest
[ RUN      ] PartitionAllocTest.PurgeDiscardable
../../base/allocator/partition_allocator/partition_alloc_unittest.cc:1942: Failure
Value of: stats->discardable_bytes
  Actual: 0
Expected: 2 * kSystemPageSize
Which is: 32768
../../base/allocator/partition_allocator/partition_alloc_unittest.cc:1944: Failure
Value of: stats->resident_bytes
  Actual: 49152
Expected: 9 * kSystemPageSize
Which is: 147456
../../base/allocator/partition_allocator/partition_alloc_unittest.cc:190: Failure
Value of: ret
  Actual: '\0'
Expected: inCore
Which is: true
../../base/allocator/partition_allocator/partition_alloc_unittest.cc:190: Failure
Value of: ret
  Actual: '\0'
Expected: inCore
Which is: true
../../base/allocator/partition_allocator/partition_alloc_unittest.cc:190: Failure
Value of: ret
  Actual: '\0'
Expected: inCore
Which is: true
../../base/allocator/partition_allocator/partition_alloc_unittest.cc:190: Failure
Value of: ret
  Actual: '\x1' (1)
Expected: inCore
Which is: false
../../base/allocator/partition_allocator/partition_alloc_unittest.cc:190: Failure
Value of: ret
  Actual: '\0'
Expected: inCore
Which is: true
../../base/allocator/partition_allocator/partition_alloc_unittest.cc:190: Failure
Value of: ret
  Actual: '\0'
Expected: inCore
Which is: true
../../base/allocator/partition_allocator/partition_alloc_unittest.cc:1980: Failure
Value of: stats
  Actual: false
Expected: true
Program received signal SIGSEGV, Segmentation fault.
0x000000aaab0a9554 in testing::AssertionResult::AssertionResult<bool>(bool const&, testing::internal::EnableIf<!testing::internal::ImplicitlyConvertible<bool, testing::AssertionResult>::value>::type*) (this=0xffffffa6f0, success=@0x0: <error reading variable>) at ../../third_party/googletest/src/googletest/include/gtest/gtest.h:277
277           : success_(success) {}

Did this work before? N/A 

Does this work in other browsers? N/A

Chrome version: 60.0.3096.2  Channel: n/a
OS Version: 
Flash Version:
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c544f6d7885c105eb1ca91caec59f13b0bc361c

commit 0c544f6d7885c105eb1ca91caec59f13b0bc361c
Author: Wang Qing <wangqing-hf@loongson.cn>
Date: Wed Jan 10 01:16:57 2018

Fix PartitionAlloc test: PartitionAllocTest.PurgeDiscardable crashed on Loongson.

The bug comes from test unit: base_unittests
The crashed case: PartitionAllocTest.PurgeDiscardable

Due to system pagesize is 16384 on Loongson make test slot_size
exceeded maximum application value in PartitionAlloc, thus resulting
in PartitionAllocTest.PurgeDiscardable crashed on Loongson.

Bug:  800286 

R= haraken@chromium.org

Change-Id: I5f8d3d055fc81b7c12f57c45d68d38746b741fca
Reviewed-on: https://chromium-review.googlesource.com/856264
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: 汪 清 <wangqing-hf@loongson.cn>
Cr-Commit-Position: refs/heads/master@{#528193}
[modify] https://crrev.com/0c544f6d7885c105eb1ca91caec59f13b0bc361c/base/allocator/partition_allocator/partition_alloc_unittest.cc

Status: Fixed (was: Unconfirmed)

Sign in to add a comment