Remove "option optimize_for = LITE_RUNTIME;" from android proto files |
|
Issue descriptionIn the process of moving from nano to lite, options option optimize_for = LITE_RUNTIME; have to be introduced into all android proto files. This is needed because the protobuf compiler does not support forcing lite compilation with only a command-line switch. This feature is already supported on the javalite branch of protobuf that should get merged onto master in the next major version (4.0). Once this is out and imported in /third_party, we need to verify it is working (probably by a switch protoc --java_lite_out=...) and remove all the options.
,
Nov 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8121da4a4506f3a590305cec0792e7d31dc1b8a9 commit 8121da4a4506f3a590305cec0792e7d31dc1b8a9 Author: oysteine <oysteine@chromium.org> Date: Fri Nov 30 22:49:19 2018 Revert "[protoc] Use protoc's lite java plugin and runtime" This reverts commit 8aa669efad5cd46935c89fbd96dfe3d207d5ce9e. Reason for revert: crbug.com/910759 Original change's description: > [protoc] Use protoc's lite java plugin and runtime > > protoc the protobuf compiler now requires using a separate plugin for > compiling protos for the java lite runtime. The lite java runtime is now > also separate from the main java runtime and is distributed separately. > > This cl switches java proto compilation for lite protos to this new > mode. > > TBR=android_webview/BUILD.gn > > Bug: 782237, 800281 > Change-Id: I31c2d073bed51109dffeea133495679deef3186b > Reviewed-on: https://chromium-review.googlesource.com/c/1340522 > Commit-Queue: Mohamed Heikal <mheikal@chromium.org> > Reviewed-by: Pavel Yatsuk <pavely@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Reviewed-by: agrieve <agrieve@chromium.org> > Reviewed-by: Peter Wen <wnwen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612720} TBR=pkasting@chromium.org,michaelbai@chromium.org,wnwen@chromium.org,pavely@chromium.org,agrieve@chromium.org,mheikal@chromium.org Change-Id: Ie2dce6e8c5ad03e6a75607a02e234c813f3072a5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 782237, 800281 Reviewed-on: https://chromium-review.googlesource.com/c/1357571 Reviewed-by: oysteine <oysteine@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#612826} [modify] https://crrev.com/8121da4a4506f3a590305cec0792e7d31dc1b8a9/android_webview/BUILD.gn [modify] https://crrev.com/8121da4a4506f3a590305cec0792e7d31dc1b8a9/build/config/android/rules.gni [modify] https://crrev.com/8121da4a4506f3a590305cec0792e7d31dc1b8a9/build/protoc_java.py [modify] https://crrev.com/8121da4a4506f3a590305cec0792e7d31dc1b8a9/chrome/android/BUILD.gn [modify] https://crrev.com/8121da4a4506f3a590305cec0792e7d31dc1b8a9/components/invalidation/impl/BUILD.gn [modify] https://crrev.com/8121da4a4506f3a590305cec0792e7d31dc1b8a9/third_party/feed/BUILD.gn [modify] https://crrev.com/8121da4a4506f3a590305cec0792e7d31dc1b8a9/third_party/protobuf/BUILD.gn
,
Dec 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cabc7f418640412ae496bd23fdd096efac1f7b33 commit cabc7f418640412ae496bd23fdd096efac1f7b33 Author: oysteine <oysteine@chromium.org> Date: Sat Dec 01 00:08:52 2018 Reland "[protoc] Use protoc's lite java plugin and runtime" This reverts commit 8121da4a4506f3a590305cec0792e7d31dc1b8a9. Reason for revert: Builder turned green while the revert was in flight, and the revert seems to have broken it. Original change's description: > Revert "[protoc] Use protoc's lite java plugin and runtime" > > This reverts commit 8aa669efad5cd46935c89fbd96dfe3d207d5ce9e. > > Reason for revert: crbug.com/910759 > > Original change's description: > > [protoc] Use protoc's lite java plugin and runtime > > > > protoc the protobuf compiler now requires using a separate plugin for > > compiling protos for the java lite runtime. The lite java runtime is now > > also separate from the main java runtime and is distributed separately. > > > > This cl switches java proto compilation for lite protos to this new > > mode. > > > > TBR=android_webview/BUILD.gn > > > > Bug: 782237, 800281 > > Change-Id: I31c2d073bed51109dffeea133495679deef3186b > > Reviewed-on: https://chromium-review.googlesource.com/c/1340522 > > Commit-Queue: Mohamed Heikal <mheikal@chromium.org> > > Reviewed-by: Pavel Yatsuk <pavely@chromium.org> > > Reviewed-by: Peter Kasting <pkasting@chromium.org> > > Reviewed-by: agrieve <agrieve@chromium.org> > > Reviewed-by: Peter Wen <wnwen@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#612720} > > TBR=pkasting@chromium.org,michaelbai@chromium.org,wnwen@chromium.org,pavely@chromium.org,agrieve@chromium.org,mheikal@chromium.org > > Change-Id: Ie2dce6e8c5ad03e6a75607a02e234c813f3072a5 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 782237, 800281 > Reviewed-on: https://chromium-review.googlesource.com/c/1357571 > Reviewed-by: oysteine <oysteine@chromium.org> > Commit-Queue: oysteine <oysteine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612826} TBR=pkasting@chromium.org,michaelbai@chromium.org,wnwen@chromium.org,oysteine@chromium.org,pavely@chromium.org,agrieve@chromium.org,mheikal@chromium.org Change-Id: Ia8b508fd7ab9c7c42cc976dc0827683da81a435f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 782237, 800281 Reviewed-on: https://chromium-review.googlesource.com/c/1357641 Reviewed-by: oysteine <oysteine@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#612863} [modify] https://crrev.com/cabc7f418640412ae496bd23fdd096efac1f7b33/android_webview/BUILD.gn [modify] https://crrev.com/cabc7f418640412ae496bd23fdd096efac1f7b33/build/config/android/rules.gni [modify] https://crrev.com/cabc7f418640412ae496bd23fdd096efac1f7b33/build/protoc_java.py [modify] https://crrev.com/cabc7f418640412ae496bd23fdd096efac1f7b33/chrome/android/BUILD.gn [modify] https://crrev.com/cabc7f418640412ae496bd23fdd096efac1f7b33/components/invalidation/impl/BUILD.gn [modify] https://crrev.com/cabc7f418640412ae496bd23fdd096efac1f7b33/third_party/feed/BUILD.gn [modify] https://crrev.com/cabc7f418640412ae496bd23fdd096efac1f7b33/third_party/protobuf/BUILD.gn |
|
►
Sign in to add a comment |
|
Comment 1 by bugdroid1@chromium.org
, Nov 30