The button of the toolbar should be updated depending of the size class of the device.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0a79438c7215ed6a807f75cf16f66e46690e6234 commit 0a79438c7215ed6a807f75cf16f66e46690e6234 Author: Gauthier Ambard <gambard@chromium.org> Date: Tue Jan 09 15:24:22 2018 Add configuration for ToolbarButtonVisibility This CL adds a configuration object vending the visibility of the different toolbar's buttons, based on the type of the toolbar. Bug: 800274 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I186436b2df94163103ca2c4248eb431ad5683b0e Reviewed-on: https://chromium-review.googlesource.com/856437 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Louis Romero <lpromero@chromium.org> Cr-Commit-Position: refs/heads/master@{#527996} [modify] https://crrev.com/0a79438c7215ed6a807f75cf16f66e46690e6234/ios/chrome/browser/ui/toolbar/clean/BUILD.gn [modify] https://crrev.com/0a79438c7215ed6a807f75cf16f66e46690e6234/ios/chrome/browser/ui/toolbar/clean/toolbar_button.mm [modify] https://crrev.com/0a79438c7215ed6a807f75cf16f66e46690e6234/ios/chrome/browser/ui/toolbar/clean/toolbar_button_factory.h [modify] https://crrev.com/0a79438c7215ed6a807f75cf16f66e46690e6234/ios/chrome/browser/ui/toolbar/clean/toolbar_button_factory.mm [add] https://crrev.com/0a79438c7215ed6a807f75cf16f66e46690e6234/ios/chrome/browser/ui/toolbar/clean/toolbar_button_visibility_configuration.h [add] https://crrev.com/0a79438c7215ed6a807f75cf16f66e46690e6234/ios/chrome/browser/ui/toolbar/clean/toolbar_button_visibility_configuration.mm [modify] https://crrev.com/0a79438c7215ed6a807f75cf16f66e46690e6234/ios/chrome/browser/ui/toolbar/clean/toolbar_component_options.h [modify] https://crrev.com/0a79438c7215ed6a807f75cf16f66e46690e6234/ios/chrome/browser/ui/toolbar/clean/toolbar_coordinator.mm [add] https://crrev.com/0a79438c7215ed6a807f75cf16f66e46690e6234/ios/chrome/browser/ui/toolbar/clean/toolbar_type.h [modify] https://crrev.com/0a79438c7215ed6a807f75cf16f66e46690e6234/ios/chrome/browser/ui/toolbar/clean/toolbar_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9e6619e75f9ac6d3e0744fdd8c8cf67b1ebf2bd0 commit 9e6619e75f9ac6d3e0744fdd8c8cf67b1ebf2bd0 Author: Gauthier Ambard <gambard@chromium.org> Date: Wed Jan 10 16:16:16 2018 Update button visibility on the PrimaryToolbar This CL changes the PrimaryToolbar so it updates the visibility of its buttons. It also adds the missing buttons to it. Bug: 800274 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id784e7951107e6cbe73cb54db07625899ad0c56d Reviewed-on: https://chromium-review.googlesource.com/860037 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Louis Romero <lpromero@chromium.org> Cr-Commit-Position: refs/heads/master@{#528334} [modify] https://crrev.com/9e6619e75f9ac6d3e0744fdd8c8cf67b1ebf2bd0/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view.h [modify] https://crrev.com/9e6619e75f9ac6d3e0744fdd8c8cf67b1ebf2bd0/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view.mm [modify] https://crrev.com/9e6619e75f9ac6d3e0744fdd8c8cf67b1ebf2bd0/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view_controller.mm [modify] https://crrev.com/9e6619e75f9ac6d3e0744fdd8c8cf67b1ebf2bd0/ios/chrome/browser/ui/toolbar/clean/toolbar_button_visibility_configuration.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6ae50fd58e3d4438bd2b460b7a06397056ea44c8 commit 6ae50fd58e3d4438bd2b460b7a06397056ea44c8 Author: Gauthier Ambard <gambard@chromium.org> Date: Thu Jan 11 17:18:05 2018 Fix the visibility mask of the ToolbarButtons This CL changes the visibility of the different toolbar buttons to match what is expected from them. Bug: 800274 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I520c504598718957cc4f0a838196c25398229bac Reviewed-on: https://chromium-review.googlesource.com/861783 Reviewed-by: Louis Romero <lpromero@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#528653} [modify] https://crrev.com/6ae50fd58e3d4438bd2b460b7a06397056ea44c8/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view.mm [modify] https://crrev.com/6ae50fd58e3d4438bd2b460b7a06397056ea44c8/ios/chrome/browser/ui/toolbar/clean/toolbar_button_factory.h [modify] https://crrev.com/6ae50fd58e3d4438bd2b460b7a06397056ea44c8/ios/chrome/browser/ui/toolbar/clean/toolbar_button_factory.mm [modify] https://crrev.com/6ae50fd58e3d4438bd2b460b7a06397056ea44c8/ios/chrome/browser/ui/toolbar/clean/toolbar_button_visibility_configuration.h [modify] https://crrev.com/6ae50fd58e3d4438bd2b460b7a06397056ea44c8/ios/chrome/browser/ui/toolbar/clean/toolbar_button_visibility_configuration.mm [modify] https://crrev.com/6ae50fd58e3d4438bd2b460b7a06397056ea44c8/ios/chrome/browser/ui/toolbar/clean/toolbar_view.mm
Comment 1 by bugdroid1@chromium.org
, Jan 9 2018