This bug is here to track places where code related to the non-adaptive toolbar should be removed.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cc7fdcbe08ac44d821f7b3947abbe60fb1ee9e30 commit cc7fdcbe08ac44d821f7b3947abbe60fb1ee9e30 Author: Gauthier Ambard <gambard@chromium.org> Date: Thu Sep 20 07:46:49 2018 [iOS] Remove old UI code in Toolbar button factory This CL removes the code used only by the old UI in the Toolbar Button Factory. In order to keep compilation intact, the methods are emptied, they are not removed. Bug: 800266 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Id74766e69c9f06a7e44fa2c669789a4bc9822675 Reviewed-on: https://chromium-review.googlesource.com/1230677 Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#592713} [modify] https://crrev.com/cc7fdcbe08ac44d821f7b3947abbe60fb1ee9e30/ios/chrome/browser/ui/toolbar/BUILD.gn [modify] https://crrev.com/cc7fdcbe08ac44d821f7b3947abbe60fb1ee9e30/ios/chrome/browser/ui/toolbar/buttons/toolbar_button_factory.h [modify] https://crrev.com/cc7fdcbe08ac44d821f7b3947abbe60fb1ee9e30/ios/chrome/browser/ui/toolbar/buttons/toolbar_button_factory.mm [modify] https://crrev.com/cc7fdcbe08ac44d821f7b3947abbe60fb1ee9e30/ios/chrome/browser/ui/toolbar/resources/BUILD.gn [delete] https://crrev.com/e1a532b5dd87255033cf4201fd8a710e360238fe/ios/chrome/browser/ui/toolbar/resources/collapse.imageset/Contents.json [delete] https://crrev.com/e1a532b5dd87255033cf4201fd8a710e360238fe/ios/chrome/browser/ui/toolbar/resources/collapse.imageset/collapse.png [delete] https://crrev.com/e1a532b5dd87255033cf4201fd8a710e360238fe/ios/chrome/browser/ui/toolbar/resources/collapse.imageset/collapse@2x.png [delete] https://crrev.com/e1a532b5dd87255033cf4201fd8a710e360238fe/ios/chrome/browser/ui/toolbar/resources/collapse.imageset/collapse@3x.png [delete] https://crrev.com/e1a532b5dd87255033cf4201fd8a710e360238fe/ios/chrome/browser/ui/toolbar/resources/collapse_incognito.imageset/Contents.json [delete] https://crrev.com/e1a532b5dd87255033cf4201fd8a710e360238fe/ios/chrome/browser/ui/toolbar/resources/collapse_incognito.imageset/collapse_incognito.png [delete] https://crrev.com/e1a532b5dd87255033cf4201fd8a710e360238fe/ios/chrome/browser/ui/toolbar/resources/collapse_incognito.imageset/collapse_incognito@2x.png [delete] https://crrev.com/e1a532b5dd87255033cf4201fd8a710e360238fe/ios/chrome/browser/ui/toolbar/resources/collapse_incognito.imageset/collapse_incognito@3x.png [delete] https://crrev.com/e1a532b5dd87255033cf4201fd8a710e360238fe/ios/chrome/browser/ui/toolbar/resources/collapse_pressed.imageset/Contents.json [delete] https://crrev.com/e1a532b5dd87255033cf4201fd8a710e360238fe/ios/chrome/browser/ui/toolbar/resources/collapse_pressed.imageset/collapse_pressed.png [delete] https://crrev.com/e1a532b5dd87255033cf4201fd8a710e360238fe/ios/chrome/browser/ui/toolbar/resources/collapse_pressed.imageset/collapse_pressed@2x.png [delete] https://crrev.com/e1a532b5dd87255033cf4201fd8a710e360238fe/ios/chrome/browser/ui/toolbar/resources/collapse_pressed.imageset/collapse_pressed@3x.png [delete] https://crrev.com/e1a532b5dd87255033cf4201fd8a710e360238fe/ios/chrome/browser/ui/toolbar/resources/collapse_pressed_incognito.imageset/Contents.json [delete] https://crrev.com/e1a532b5dd87255033cf4201fd8a710e360238fe/ios/chrome/browser/ui/toolbar/resources/collapse_pressed_incognito.imageset/collapse_pressed_incognito.png [delete] https://crrev.com/e1a532b5dd87255033cf4201fd8a710e360238fe/ios/chrome/browser/ui/toolbar/resources/collapse_pressed_incognito.imageset/collapse_pressed_incognito@2x.png [delete] https://crrev.com/e1a532b5dd87255033cf4201fd8a710e360238fe/ios/chrome/browser/ui/toolbar/resources/collapse_pressed_incognito.imageset/collapse_pressed_incognito@3x.png [delete] https://crrev.com/e1a532b5dd87255033cf4201fd8a710e360238fe/ios/chrome/browser/ui/toolbar/resources/incognito_marker_typing.imageset/Contents.json [delete] https://crrev.com/e1a532b5dd87255033cf4201fd8a710e360238fe/ios/chrome/browser/ui/toolbar/resources/incognito_marker_typing.imageset/incognito_marker_typing.png [delete] https://crrev.com/e1a532b5dd87255033cf4201fd8a710e360238fe/ios/chrome/browser/ui/toolbar/resources/incognito_marker_typing.imageset/incognito_marker_typing@2x.png [delete] https://crrev.com/e1a532b5dd87255033cf4201fd8a710e360238fe/ios/chrome/browser/ui/toolbar/resources/incognito_marker_typing.imageset/incognito_marker_typing@3x.png [modify] https://crrev.com/cc7fdcbe08ac44d821f7b3947abbe60fb1ee9e30/ios/chrome/browser/ui/toolbar/toolbar_resource_macros.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8c458fbe58abe6fa867b63b0942f6d6767aebdf6 commit 8c458fbe58abe6fa867b63b0942f6d6767aebdf6 Author: Gauthier Ambard <gambard@chromium.org> Date: Thu Sep 20 07:54:58 2018 [iOS] Remove FindInPage legacy code This CL removes the code used by FindInPage pre-UI Refresh. Bug: 800266 , 879136 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I1b3ee786c19cebd54dc641fb7a7d71f5d4b1b8b6 Reviewed-on: https://chromium-review.googlesource.com/1233836 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#592716} [modify] https://crrev.com/8c458fbe58abe6fa867b63b0942f6d6767aebdf6/ios/chrome/browser/ui/find_bar/BUILD.gn [modify] https://crrev.com/8c458fbe58abe6fa867b63b0942f6d6767aebdf6/ios/chrome/browser/ui/find_bar/find_bar_controller_ios.mm [delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/find_bar_touch_forwarding_view.h [delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/find_bar_touch_forwarding_view.mm [delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/find_bar_ui_element.h [modify] https://crrev.com/8c458fbe58abe6fa867b63b0942f6d6767aebdf6/ios/chrome/browser/ui/find_bar/find_bar_view.h [modify] https://crrev.com/8c458fbe58abe6fa867b63b0942f6d6767aebdf6/ios/chrome/browser/ui/find_bar/find_bar_view.mm [delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/legacy_find_bar_view.h [delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/legacy_find_bar_view.mm [modify] https://crrev.com/8c458fbe58abe6fa867b63b0942f6d6767aebdf6/ios/chrome/browser/ui/find_bar/resources/BUILD.gn [delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_bg.imageset/Contents.json [delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_bg.imageset/find_bg@2x~ipad.png [delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_bg.imageset/find_bg~ipad.png [delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_close.imageset/Contents.json [delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_close.imageset/find_close.png [delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_close.imageset/find_close@2x.png [delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_close.imageset/find_close@3x.png [delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_close_incognito.imageset/Contents.json [delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_close_incognito.imageset/find_close_incognito.png [delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_close_incognito.imageset/find_close_incognito@2x.png [delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_close_incognito.imageset/find_close_incognito@3x.png [delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_close_pressed.imageset/Contents.json [delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_close_pressed.imageset/find_close_pressed.png [delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_close_pressed.imageset/find_close_pressed@2x.png [delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_close_pressed.imageset/find_close_pressed@3x.png [delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_next_disabled.imageset/Contents.json [delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_next_disabled.imageset/find_next_disabled.png [delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_next_disabled.imageset/find_next_disabled@2x.png [delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_next_disabled.imageset/find_next_disabled@3x.png [delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_next_disabled_incognito.imageset/Contents.json [delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_next_disabled_incognito.imageset/find_next_disabled_incognito.png [delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_next_disabled_incognito.imageset/find_next_disabled_incognito@2x.png [delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_next_disabled_incognito.imageset/find_next_disabled_incognito@3x.png [delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_next_incognito.imageset/Contents.json [delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_next_incognito.imageset/find_next_incognito.png [delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_next_incognito.imageset/find_next_incognito@2x.png [delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_next_incognito.imageset/find_next_incognito@3x.png [delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_next_pressed.imageset/Contents.json [delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_next_pressed.imageset/find_next_pressed.png [delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_next_pressed.imageset/find_next_pressed@2x.png [delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_next_pressed.imageset/find_next_pressed@3x.png [delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_next_pressed_incognito.imageset/Contents.json [delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_next_pressed_incognito.imageset/find_next_pressed_incognito.png [delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_next_pressed_incognito.imageset/find_next_pressed_incognito@2x.png [delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_next_pressed_incognito.imageset/find_next_pressed_incognito@3x.png [delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_prev_disabled.imageset/Contents.json [delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_prev_disabled.imageset/find_prev_disabled.png [delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_prev_disabled.imageset/find_prev_disabled@2x.png [delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_prev_disabled.imageset/find_prev_disabled@3x.png [delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_prev_disabled_incognito.imageset/Contents.json [delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_prev_disabled_incognito.imageset/find_prev_disabled_incognito.png [delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_prev_disabled_incognito.imageset/find_prev_disabled_incognito@2x.png [delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_prev_disabled_incognito.imageset/find_prev_disabled_incognito@3x.png [delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_prev_incognito.imageset/Contents.json [delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_prev_incognito.imageset/find_prev_incognito.png [delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_prev_incognito.imageset/find_prev_incognito@2x.png [delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_prev_incognito.imageset/find_prev_incognito@3x.png [delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_prev_pressed.imageset/Contents.json [delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_prev_pressed.imageset/find_prev_pressed.png [delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_prev_pressed.imageset/find_prev_pressed@2x.png [delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_prev_pressed.imageset/find_prev_pressed@3x.png [delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_prev_pressed_incognito.imageset/Contents.json [delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_prev_pressed_incognito.imageset/find_prev_pressed_incognito.png [delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_prev_pressed_incognito.imageset/find_prev_pressed_incognito@2x.png [delete] https://crrev.com/863fb9e774b6bf5b04db1bc88d5a0db2cab01113/ios/chrome/browser/ui/find_bar/resources/find_prev_pressed_incognito.imageset/find_prev_pressed_incognito@3x.png
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/83c37fe1ee4577f8560723462ecd7543e1ff5314 commit 83c37fe1ee4577f8560723462ecd7543e1ff5314 Author: Gauthier Ambard <gambard@chromium.org> Date: Thu Sep 20 08:36:33 2018 [iOS] Remove LegacyToolbar initialization This CL modifies BVC so the legacy toolbar is no longer initialized. Bug: 800266 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I2cf98fbfd55b550cedecd329eccb1ee36565e98a Reviewed-on: https://chromium-review.googlesource.com/1230735 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#592721} [modify] https://crrev.com/83c37fe1ee4577f8560723462ecd7543e1ff5314/ios/chrome/browser/ui/browser_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/62cc38ffd3ab8094884fb1df00e4fa98dccd1841 commit 62cc38ffd3ab8094884fb1df00e4fa98dccd1841 Author: Gauthier Ambard <gambard@chromium.org> Date: Thu Sep 20 08:50:44 2018 [iOS] Remove legacy toolbar code This CL removes the legacy implementation of the toolbar. Bug: 800266 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ic0bcca519ad1340cd537fda7f015b7021a1ea594 Reviewed-on: https://chromium-review.googlesource.com/1230718 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#592723} [modify] https://crrev.com/62cc38ffd3ab8094884fb1df00e4fa98dccd1841/ios/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/62cc38ffd3ab8094884fb1df00e4fa98dccd1841/ios/chrome/browser/ui/omnibox_perftest.mm [modify] https://crrev.com/62cc38ffd3ab8094884fb1df00e4fa98dccd1841/ios/chrome/browser/ui/qr_scanner/qr_scanner_view_controller_egtest.mm [modify] https://crrev.com/62cc38ffd3ab8094884fb1df00e4fa98dccd1841/ios/chrome/browser/ui/toolbar/clean/BUILD.gn [delete] https://crrev.com/b6ad52589192a4e7f107978a2042cf43bb64d1ee/ios/chrome/browser/ui/toolbar/clean/toolbar_button_updater.h [delete] https://crrev.com/b6ad52589192a4e7f107978a2042cf43bb64d1ee/ios/chrome/browser/ui/toolbar/clean/toolbar_button_updater.mm [delete] https://crrev.com/b6ad52589192a4e7f107978a2042cf43bb64d1ee/ios/chrome/browser/ui/toolbar/clean/toolbar_coordinator.h [delete] https://crrev.com/b6ad52589192a4e7f107978a2042cf43bb64d1ee/ios/chrome/browser/ui/toolbar/clean/toolbar_coordinator.mm [delete] https://crrev.com/b6ad52589192a4e7f107978a2042cf43bb64d1ee/ios/chrome/browser/ui/toolbar/clean/toolbar_view.h [delete] https://crrev.com/b6ad52589192a4e7f107978a2042cf43bb64d1ee/ios/chrome/browser/ui/toolbar/clean/toolbar_view.mm [delete] https://crrev.com/b6ad52589192a4e7f107978a2042cf43bb64d1ee/ios/chrome/browser/ui/toolbar/clean/toolbar_view_controller.h [delete] https://crrev.com/b6ad52589192a4e7f107978a2042cf43bb64d1ee/ios/chrome/browser/ui/toolbar/clean/toolbar_view_controller.mm [modify] https://crrev.com/62cc38ffd3ab8094884fb1df00e4fa98dccd1841/ios/chrome/browser/ui/toolbar/toolbar_egtest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/92644d03391eab3f0502cd79ba0e580af8a0ce9e commit 92644d03391eab3f0502cd79ba0e580af8a0ce9e Author: Gauthier Ambard <gambard@chromium.org> Date: Thu Sep 20 08:55:11 2018 [iOS] Cleanup of Toolbar buttons This CL cleans the toolbar buttons up. It flags the code that cannot be removed yet. This code is usually still used by classes that will be removed in the future. Bug: 800266 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I975e2f7e46e7dfee512f43be8429916c780e5cab Reviewed-on: https://chromium-review.googlesource.com/1232959 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#592725} [modify] https://crrev.com/92644d03391eab3f0502cd79ba0e580af8a0ce9e/ios/chrome/browser/ui/find_bar/find_bar_controller_ios.mm [modify] https://crrev.com/92644d03391eab3f0502cd79ba0e580af8a0ce9e/ios/chrome/browser/ui/toolbar/buttons/BUILD.gn [modify] https://crrev.com/92644d03391eab3f0502cd79ba0e580af8a0ce9e/ios/chrome/browser/ui/toolbar/buttons/resources/BUILD.gn [delete] https://crrev.com/455760fe5861e99832742912d0af5a0440b6ce60/ios/chrome/browser/ui/toolbar/buttons/resources/toolbar_menu.imageset/Contents.json [delete] https://crrev.com/455760fe5861e99832742912d0af5a0440b6ce60/ios/chrome/browser/ui/toolbar/buttons/resources/toolbar_menu.imageset/toolbar_menu.png [delete] https://crrev.com/455760fe5861e99832742912d0af5a0440b6ce60/ios/chrome/browser/ui/toolbar/buttons/resources/toolbar_menu.imageset/toolbar_menu@2x.png [delete] https://crrev.com/455760fe5861e99832742912d0af5a0440b6ce60/ios/chrome/browser/ui/toolbar/buttons/resources/toolbar_menu.imageset/toolbar_menu@3x.png [modify] https://crrev.com/92644d03391eab3f0502cd79ba0e580af8a0ce9e/ios/chrome/browser/ui/toolbar/buttons/toolbar_button.mm [modify] https://crrev.com/92644d03391eab3f0502cd79ba0e580af8a0ce9e/ios/chrome/browser/ui/toolbar/buttons/toolbar_button_factory.mm [delete] https://crrev.com/455760fe5861e99832742912d0af5a0440b6ce60/ios/chrome/browser/ui/toolbar/buttons/toolbar_button_tints.h [delete] https://crrev.com/455760fe5861e99832742912d0af5a0440b6ce60/ios/chrome/browser/ui/toolbar/buttons/toolbar_button_tints.mm [modify] https://crrev.com/92644d03391eab3f0502cd79ba0e580af8a0ce9e/ios/chrome/browser/ui/toolbar/buttons/toolbar_configuration.h [modify] https://crrev.com/92644d03391eab3f0502cd79ba0e580af8a0ce9e/ios/chrome/browser/ui/toolbar/buttons/toolbar_configuration.mm [modify] https://crrev.com/92644d03391eab3f0502cd79ba0e580af8a0ce9e/ios/chrome/browser/ui/toolbar/buttons/toolbar_constants.h [modify] https://crrev.com/92644d03391eab3f0502cd79ba0e580af8a0ce9e/ios/chrome/browser/ui/toolbar/buttons/toolbar_constants.mm [modify] https://crrev.com/92644d03391eab3f0502cd79ba0e580af8a0ce9e/ios/chrome/browser/ui/toolbar/buttons/toolbar_style.h [modify] https://crrev.com/92644d03391eab3f0502cd79ba0e580af8a0ce9e/ios/chrome/browser/ui/toolbar/buttons/toolbar_tools_menu_button.h [modify] https://crrev.com/92644d03391eab3f0502cd79ba0e580af8a0ce9e/ios/chrome/browser/ui/toolbar/buttons/toolbar_tools_menu_button.mm [modify] https://crrev.com/92644d03391eab3f0502cd79ba0e580af8a0ce9e/ios/chrome/browser/ui/toolbar/buttons/tools_menu_button_observer_bridge.mm [modify] https://crrev.com/92644d03391eab3f0502cd79ba0e580af8a0ce9e/ios/chrome/browser/ui/toolbar/legacy/toolbar_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5785e22fef107db68cdde35a94e446d87870d7d9 commit 5785e22fef107db68cdde35a94e446d87870d7d9 Author: Gauthier Ambard <gambard@chromium.org> Date: Thu Sep 20 09:21:54 2018 [iOS] Merge AdaptiveToolbar test suite in ui_egtests This CL merges the AdaptiveToolbar test suite in the more general ui_egtest test suite as it was used a separated test suite to make sure the flag was enabled. As it is now enabled by default, it can be merged and the hooks can be removed. Bug: 800266 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ide6f2d8e0f5385602794e0036c1af3fc7bfb86e6 Reviewed-on: https://chromium-review.googlesource.com/1230734 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#592732} [modify] https://crrev.com/5785e22fef107db68cdde35a94e446d87870d7d9/ios/build/bots/tests/eg_tests.json [modify] https://crrev.com/5785e22fef107db68cdde35a94e446d87870d7d9/ios/chrome/app/tests_fake_hook.mm [modify] https://crrev.com/5785e22fef107db68cdde35a94e446d87870d7d9/ios/chrome/app/tests_hook.h [modify] https://crrev.com/5785e22fef107db68cdde35a94e446d87870d7d9/ios/chrome/browser/ui/tab_grid/tab_grid_egtests_hook.mm [modify] https://crrev.com/5785e22fef107db68cdde35a94e446d87870d7d9/ios/chrome/browser/ui/toolbar/adaptive/BUILD.gn [delete] https://crrev.com/c8c9ce1b40cce9193bfd620f7ad949f7551bfda2/ios/chrome/browser/ui/toolbar/adaptive/adaptive_toolbar_eg_tests_hook.mm [modify] https://crrev.com/5785e22fef107db68cdde35a94e446d87870d7d9/ios/chrome/test/earl_grey/BUILD.gn [modify] https://crrev.com/5785e22fef107db68cdde35a94e446d87870d7d9/ios/chrome/test/earl_grey/eg_tests_hook.mm [modify] https://crrev.com/5785e22fef107db68cdde35a94e446d87870d7d9/testing/buildbot/gn_isolate_map.pyl [modify] https://crrev.com/5785e22fef107db68cdde35a94e446d87870d7d9/testing/buildbot/manage.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bb9a969630bf0ca6a2418df9bd2383cfd27e39ca commit bb9a969630bf0ca6a2418df9bd2383cfd27e39ca Author: Gauthier Ambard <gambard@chromium.org> Date: Thu Sep 20 09:44:04 2018 [iOS] Move TabHistory EarlGrey test to PopupMenu This CL moves the EarlGrey test for the TabHistory to the PopupMenu as the TabHistory has been replaced by the Popup Menu in UIRefresh. Bug: 800266 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ida2bf76b73ef65e5670a3a443d55be685b7d78e7 Reviewed-on: https://chromium-review.googlesource.com/1233742 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#592737} [modify] https://crrev.com/bb9a969630bf0ca6a2418df9bd2383cfd27e39ca/ios/chrome/browser/ui/history_popup/BUILD.gn [modify] https://crrev.com/bb9a969630bf0ca6a2418df9bd2383cfd27e39ca/ios/chrome/browser/ui/popup_menu/BUILD.gn [rename] https://crrev.com/bb9a969630bf0ca6a2418df9bd2383cfd27e39ca/ios/chrome/browser/ui/popup_menu/popup_menu_egtest.mm [modify] https://crrev.com/bb9a969630bf0ca6a2418df9bd2383cfd27e39ca/ios/chrome/test/earl_grey/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b7c917ecb8773a41b3f398ddc9122f1231055b23 commit b7c917ecb8773a41b3f398ddc9122f1231055b23 Author: Gauthier Ambard <gambard@chromium.org> Date: Thu Sep 20 11:53:28 2018 [iOS] Remove TabHistory popup This CL removes the TabHistory popup code as it was only used pre-UI Refresh. Bug: 800266 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I140bbed84ef69efb81c67130186ec72cca684961 Reviewed-on: https://chromium-review.googlesource.com/1233853 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#592762} [modify] https://crrev.com/b7c917ecb8773a41b3f398ddc9122f1231055b23/ios/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/b7c917ecb8773a41b3f398ddc9122f1231055b23/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/b7c917ecb8773a41b3f398ddc9122f1231055b23/ios/chrome/browser/ui/commands/BUILD.gn [modify] https://crrev.com/b7c917ecb8773a41b3f398ddc9122f1231055b23/ios/chrome/browser/ui/commands/browser_commands.h [delete] https://crrev.com/44342369ad6105d117f2f4b9e334a220a1ce8de5/ios/chrome/browser/ui/commands/history_popup_commands.h [delete] https://crrev.com/44342369ad6105d117f2f4b9e334a220a1ce8de5/ios/chrome/browser/ui/history_popup/BUILD.gn [delete] https://crrev.com/44342369ad6105d117f2f4b9e334a220a1ce8de5/ios/chrome/browser/ui/history_popup/OWNERS [delete] https://crrev.com/44342369ad6105d117f2f4b9e334a220a1ce8de5/ios/chrome/browser/ui/history_popup/requirements/BUILD.gn [delete] https://crrev.com/44342369ad6105d117f2f4b9e334a220a1ce8de5/ios/chrome/browser/ui/history_popup/requirements/tab_history_constants.h [delete] https://crrev.com/44342369ad6105d117f2f4b9e334a220a1ce8de5/ios/chrome/browser/ui/history_popup/requirements/tab_history_constants.mm [delete] https://crrev.com/44342369ad6105d117f2f4b9e334a220a1ce8de5/ios/chrome/browser/ui/history_popup/requirements/tab_history_presentation.h [delete] https://crrev.com/44342369ad6105d117f2f4b9e334a220a1ce8de5/ios/chrome/browser/ui/history_popup/requirements/tab_history_ui_updater.h [delete] https://crrev.com/44342369ad6105d117f2f4b9e334a220a1ce8de5/ios/chrome/browser/ui/history_popup/tab_history_cell.h [delete] https://crrev.com/44342369ad6105d117f2f4b9e334a220a1ce8de5/ios/chrome/browser/ui/history_popup/tab_history_cell.mm [delete] https://crrev.com/44342369ad6105d117f2f4b9e334a220a1ce8de5/ios/chrome/browser/ui/history_popup/tab_history_legacy_coordinator.h [delete] https://crrev.com/44342369ad6105d117f2f4b9e334a220a1ce8de5/ios/chrome/browser/ui/history_popup/tab_history_legacy_coordinator.mm [delete] https://crrev.com/44342369ad6105d117f2f4b9e334a220a1ce8de5/ios/chrome/browser/ui/history_popup/tab_history_popup_controller.h [delete] https://crrev.com/44342369ad6105d117f2f4b9e334a220a1ce8de5/ios/chrome/browser/ui/history_popup/tab_history_popup_controller.mm [delete] https://crrev.com/44342369ad6105d117f2f4b9e334a220a1ce8de5/ios/chrome/browser/ui/history_popup/tab_history_popup_controller_unittest.mm [delete] https://crrev.com/44342369ad6105d117f2f4b9e334a220a1ce8de5/ios/chrome/browser/ui/history_popup/tab_history_view_controller.h [delete] https://crrev.com/44342369ad6105d117f2f4b9e334a220a1ce8de5/ios/chrome/browser/ui/history_popup/tab_history_view_controller.mm [modify] https://crrev.com/b7c917ecb8773a41b3f398ddc9122f1231055b23/ios/chrome/browser/ui/overscroll_actions/BUILD.gn [modify] https://crrev.com/b7c917ecb8773a41b3f398ddc9122f1231055b23/ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.mm [modify] https://crrev.com/b7c917ecb8773a41b3f398ddc9122f1231055b23/ios/chrome/browser/ui/toolbar/BUILD.gn [modify] https://crrev.com/b7c917ecb8773a41b3f398ddc9122f1231055b23/ios/chrome/browser/ui/toolbar/clean/BUILD.gn [modify] https://crrev.com/b7c917ecb8773a41b3f398ddc9122f1231055b23/ios/chrome/test/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4101e84171627f564e3654d2a5771599e129ff26 commit 4101e84171627f564e3654d2a5771599e129ff26 Author: Gauthier Ambard <gambard@chromium.org> Date: Thu Sep 20 16:56:59 2018 [iOS] Remove the ToolsMenuButtonObserver This CL removes the class triggering the animations for the tools menu button in the toolbar. It is now directly triggered by the BVC. Bug: 800266 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I19feafb03776741bbde51fe54ace27b990811b2e Reviewed-on: https://chromium-review.googlesource.com/1236655 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#592838} [modify] https://crrev.com/4101e84171627f564e3654d2a5771599e129ff26/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/4101e84171627f564e3654d2a5771599e129ff26/ios/chrome/browser/ui/toolbar/adaptive/adaptive_toolbar_coordinator.mm [modify] https://crrev.com/4101e84171627f564e3654d2a5771599e129ff26/ios/chrome/browser/ui/toolbar/buttons/BUILD.gn [delete] https://crrev.com/9f7e07f6d7ce212437b5c8bc72a9a437fbd2c5f7/ios/chrome/browser/ui/toolbar/buttons/tools_menu_button_observer_bridge.h [delete] https://crrev.com/9f7e07f6d7ce212437b5c8bc72a9a437fbd2c5f7/ios/chrome/browser/ui/toolbar/buttons/tools_menu_button_observer_bridge.mm [modify] https://crrev.com/4101e84171627f564e3654d2a5771599e129ff26/ios/chrome/browser/ui/toolbar/legacy/toolbar_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/123259a71613f72c1e1f4f8c697a2fc569f3c8d0 commit 123259a71613f72c1e1f4f8c697a2fc569f3c8d0 Author: Gauthier Ambard <gambard@chromium.org> Date: Fri Sep 21 12:36:47 2018 [iOS] Remove legacy toolbar button visibility This CL removes the button visibility of the legacy toolbar which has been removed in a previous CL. Bug: 800266 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I7d847599d4720fa6d5a920baa9b5ad468e6e4d32 Reviewed-on: https://chromium-review.googlesource.com/1236654 Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#593157} [modify] https://crrev.com/123259a71613f72c1e1f4f8c697a2fc569f3c8d0/ios/chrome/browser/ui/toolbar/buttons/toolbar_button.mm [modify] https://crrev.com/123259a71613f72c1e1f4f8c697a2fc569f3c8d0/ios/chrome/browser/ui/toolbar/buttons/toolbar_button_visibility_configuration.mm [modify] https://crrev.com/123259a71613f72c1e1f4f8c697a2fc569f3c8d0/ios/chrome/browser/ui/toolbar/buttons/toolbar_component_options.h [modify] https://crrev.com/123259a71613f72c1e1f4f8c697a2fc569f3c8d0/ios/chrome/browser/ui/toolbar/buttons/toolbar_type.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5abf83beeef2741750826d40277b6facb26a3886 commit 5abf83beeef2741750826d40277b6facb26a3886 Author: Gauthier Ambard <gambard@chromium.org> Date: Tue Sep 25 14:42:19 2018 [iOS] Remove the legacy toolbar The legacy toolbar was still used by the StackView. Now that it is removed, the legacy toolbar can also be removed. Bug: 800266 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I9ce8a6348a2b308317225cdd18ef1e794e39874e Reviewed-on: https://chromium-review.googlesource.com/1243125 Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#593925} [modify] https://crrev.com/5abf83beeef2741750826d40277b6facb26a3886/ios/chrome/browser/metrics/BUILD.gn [modify] https://crrev.com/5abf83beeef2741750826d40277b6facb26a3886/ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm [modify] https://crrev.com/5abf83beeef2741750826d40277b6facb26a3886/ios/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/5abf83beeef2741750826d40277b6facb26a3886/ios/chrome/browser/ui/bookmarks/BUILD.gn [modify] https://crrev.com/5abf83beeef2741750826d40277b6facb26a3886/ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm [modify] https://crrev.com/5abf83beeef2741750826d40277b6facb26a3886/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/5abf83beeef2741750826d40277b6facb26a3886/ios/chrome/browser/ui/overscroll_actions/BUILD.gn [modify] https://crrev.com/5abf83beeef2741750826d40277b6facb26a3886/ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.mm [modify] https://crrev.com/5abf83beeef2741750826d40277b6facb26a3886/ios/chrome/browser/ui/toolbar/BUILD.gn [delete] https://crrev.com/edd51630cc3f320c1c60d71d59de57f714f01e0d/ios/chrome/browser/ui/toolbar/legacy/BUILD.gn [delete] https://crrev.com/edd51630cc3f320c1c60d71d59de57f714f01e0d/ios/chrome/browser/ui/toolbar/legacy/abstract_toolbar.h [delete] https://crrev.com/edd51630cc3f320c1c60d71d59de57f714f01e0d/ios/chrome/browser/ui/toolbar/legacy/legacy_toolbar_view.h [delete] https://crrev.com/edd51630cc3f320c1c60d71d59de57f714f01e0d/ios/chrome/browser/ui/toolbar/legacy/legacy_toolbar_view.mm [delete] https://crrev.com/edd51630cc3f320c1c60d71d59de57f714f01e0d/ios/chrome/browser/ui/toolbar/legacy/toolbar_controller+protected.h [delete] https://crrev.com/edd51630cc3f320c1c60d71d59de57f714f01e0d/ios/chrome/browser/ui/toolbar/legacy/toolbar_controller.h [delete] https://crrev.com/edd51630cc3f320c1c60d71d59de57f714f01e0d/ios/chrome/browser/ui/toolbar/legacy/toolbar_controller.mm [delete] https://crrev.com/edd51630cc3f320c1c60d71d59de57f714f01e0d/ios/chrome/browser/ui/toolbar/legacy/toolbar_controller_constants.h [delete] https://crrev.com/edd51630cc3f320c1c60d71d59de57f714f01e0d/ios/chrome/browser/ui/toolbar/legacy/toolbar_controller_constants.mm [delete] https://crrev.com/edd51630cc3f320c1c60d71d59de57f714f01e0d/ios/chrome/browser/ui/toolbar/legacy/toolbar_controller_unittest.mm [delete] https://crrev.com/edd51630cc3f320c1c60d71d59de57f714f01e0d/ios/chrome/browser/ui/toolbar/legacy/toolbar_utils.h [delete] https://crrev.com/edd51630cc3f320c1c60d71d59de57f714f01e0d/ios/chrome/browser/ui/toolbar/legacy/toolbar_utils.mm [modify] https://crrev.com/5abf83beeef2741750826d40277b6facb26a3886/ios/chrome/browser/ui/toolbar/toolbar_egtest.mm [modify] https://crrev.com/5abf83beeef2741750826d40277b6facb26a3886/ios/chrome/test/BUILD.gn [modify] https://crrev.com/5abf83beeef2741750826d40277b6facb26a3886/ios/chrome/test/earl_grey/BUILD.gn [modify] https://crrev.com/5abf83beeef2741750826d40277b6facb26a3886/ios/chrome/test/earl_grey/chrome_matchers.mm
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/24d4953d9c806c61ad824dc0a7d3c4356ca03589 commit 24d4953d9c806c61ad824dc0a7d3c4356ca03589 Author: Gauthier Ambard <gambard@google.com> Date: Wed Sep 26 07:03:02 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ea529df555abf28861880156d763bfc07191b2e7 commit ea529df555abf28861880156d763bfc07191b2e7 Author: Gauthier Ambard <gambard@chromium.org> Date: Wed Sep 26 08:46:10 2018 [iOS] Move ToolsMenu useful code to Popup Menu This CL moves the ToolsMenu constants and EG test to the popup menu folder so the tools menu can be removed. Bug: 800266 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I3381ab1562d8406f8bf9a9528274b03e53222ee5 Reviewed-on: https://chromium-review.googlesource.com/1243073 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#594254} [modify] https://crrev.com/ea529df555abf28861880156d763bfc07191b2e7/ios/chrome/browser/metrics/BUILD.gn [modify] https://crrev.com/ea529df555abf28861880156d763bfc07191b2e7/ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm [modify] https://crrev.com/ea529df555abf28861880156d763bfc07191b2e7/ios/chrome/browser/metrics/tab_usage_recorder_test_util.mm [modify] https://crrev.com/ea529df555abf28861880156d763bfc07191b2e7/ios/chrome/browser/ui/history/BUILD.gn [modify] https://crrev.com/ea529df555abf28861880156d763bfc07191b2e7/ios/chrome/browser/ui/history/history_ui_egtest.mm [modify] https://crrev.com/ea529df555abf28861880156d763bfc07191b2e7/ios/chrome/browser/ui/payments/BUILD.gn [modify] https://crrev.com/ea529df555abf28861880156d763bfc07191b2e7/ios/chrome/browser/ui/payments/payment_request_can_make_payment_egtest.mm [modify] https://crrev.com/ea529df555abf28861880156d763bfc07191b2e7/ios/chrome/browser/ui/popup_menu/BUILD.gn [modify] https://crrev.com/ea529df555abf28861880156d763bfc07191b2e7/ios/chrome/browser/ui/popup_menu/popup_menu_constants.h [modify] https://crrev.com/ea529df555abf28861880156d763bfc07191b2e7/ios/chrome/browser/ui/popup_menu/popup_menu_constants.mm [modify] https://crrev.com/ea529df555abf28861880156d763bfc07191b2e7/ios/chrome/browser/ui/popup_menu/popup_menu_egtest.mm [rename] https://crrev.com/ea529df555abf28861880156d763bfc07191b2e7/ios/chrome/browser/ui/popup_menu/request_desktop_mobile_site_egtest.mm [modify] https://crrev.com/ea529df555abf28861880156d763bfc07191b2e7/ios/chrome/browser/ui/sad_tab/BUILD.gn [modify] https://crrev.com/ea529df555abf28861880156d763bfc07191b2e7/ios/chrome/browser/ui/sad_tab/sad_tab_view_egtest.mm [modify] https://crrev.com/ea529df555abf28861880156d763bfc07191b2e7/ios/chrome/browser/ui/toolbar/BUILD.gn [modify] https://crrev.com/ea529df555abf28861880156d763bfc07191b2e7/ios/chrome/browser/ui/toolbar/toolbar_egtest.mm [modify] https://crrev.com/ea529df555abf28861880156d763bfc07191b2e7/ios/chrome/browser/ui/tools_menu/BUILD.gn [modify] https://crrev.com/ea529df555abf28861880156d763bfc07191b2e7/ios/chrome/browser/ui/tools_menu/public/BUILD.gn [modify] https://crrev.com/ea529df555abf28861880156d763bfc07191b2e7/ios/chrome/browser/ui/tools_menu/public/tools_menu_constants.h [modify] https://crrev.com/ea529df555abf28861880156d763bfc07191b2e7/ios/chrome/browser/ui/tools_menu/public/tools_menu_constants.mm [modify] https://crrev.com/ea529df555abf28861880156d763bfc07191b2e7/ios/chrome/browser/ui/tools_menu/tools_menu_model.mm [delete] https://crrev.com/6bfde54fba9d73713ff5f9876592ad2d39afe773/ios/chrome/browser/ui/tools_menu/tools_popup_menu_egtest.mm [modify] https://crrev.com/ea529df555abf28861880156d763bfc07191b2e7/ios/chrome/test/earl_grey/BUILD.gn [modify] https://crrev.com/ea529df555abf28861880156d763bfc07191b2e7/ios/chrome/test/earl_grey/chrome_earl_grey_ui.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bfac67054fa3549fc88a452a2284e8a027163ac5 commit bfac67054fa3549fc88a452a2284e8a027163ac5 Author: Gauthier Ambard <gambard@chromium.org> Date: Wed Sep 26 08:49:41 2018 [iOS] Remove ToolsMenu's code in BVC This CL removes the tools menu code which was used in BVC. Bug: 800266 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I69445adcba326a621a8d948cafc7e8d506389e3c Reviewed-on: https://chromium-review.googlesource.com/1243304 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#594255} [modify] https://crrev.com/bfac67054fa3549fc88a452a2284e8a027163ac5/ios/chrome/browser/ui/browser_view_controller.mm
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/11869bd2f45b9503d6745591e82509c41a1236b6 commit 11869bd2f45b9503d6745591e82509c41a1236b6 Author: Gauthier Ambard <gambard@google.com> Date: Wed Sep 26 10:11:00 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f7d1baedca054dcbc8e0c6c058aff32ecae98716 commit f7d1baedca054dcbc8e0c6c058aff32ecae98716 Author: Gauthier Ambard <gambard@chromium.org> Date: Wed Sep 26 11:19:56 2018 [iOS] Remove ToolsMenu code The ToolsMenu is no longer used and can be removed. Bug: 800266 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Id42a041f23fd2aecde8f87a0c23fd0f2e9d014f4 Reviewed-on: https://chromium-review.googlesource.com/1243111 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#594279} [modify] https://crrev.com/f7d1baedca054dcbc8e0c6c058aff32ecae98716/ios/chrome/browser/feature_engagement/BUILD.gn [modify] https://crrev.com/f7d1baedca054dcbc8e0c6c058aff32ecae98716/ios/chrome/browser/feature_engagement/feature_engagement_egtest.mm [modify] https://crrev.com/f7d1baedca054dcbc8e0c6c058aff32ecae98716/ios/chrome/browser/metrics/BUILD.gn [modify] https://crrev.com/f7d1baedca054dcbc8e0c6c058aff32ecae98716/ios/chrome/browser/metrics/tab_usage_recorder_test_util.mm [modify] https://crrev.com/f7d1baedca054dcbc8e0c6c058aff32ecae98716/ios/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/f7d1baedca054dcbc8e0c6c058aff32ecae98716/ios/chrome/browser/ui/bookmarks/BUILD.gn [modify] https://crrev.com/f7d1baedca054dcbc8e0c6c058aff32ecae98716/ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm [modify] https://crrev.com/f7d1baedca054dcbc8e0c6c058aff32ecae98716/ios/chrome/browser/ui/dialogs/BUILD.gn [modify] https://crrev.com/f7d1baedca054dcbc8e0c6c058aff32ecae98716/ios/chrome/browser/ui/dialogs/javascript_dialog_egtest.mm [modify] https://crrev.com/f7d1baedca054dcbc8e0c6c058aff32ecae98716/ios/chrome/browser/ui/find_bar/BUILD.gn [modify] https://crrev.com/f7d1baedca054dcbc8e0c6c058aff32ecae98716/ios/chrome/browser/ui/find_bar/find_in_page_egtest.mm [modify] https://crrev.com/f7d1baedca054dcbc8e0c6c058aff32ecae98716/ios/chrome/browser/ui/history/BUILD.gn [modify] https://crrev.com/f7d1baedca054dcbc8e0c6c058aff32ecae98716/ios/chrome/browser/ui/history/history_ui_egtest.mm [modify] https://crrev.com/f7d1baedca054dcbc8e0c6c058aff32ecae98716/ios/chrome/browser/ui/keyboard_commands_egtest.mm [modify] https://crrev.com/f7d1baedca054dcbc8e0c6c058aff32ecae98716/ios/chrome/browser/ui/overscroll_actions/BUILD.gn [modify] https://crrev.com/f7d1baedca054dcbc8e0c6c058aff32ecae98716/ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.mm [modify] https://crrev.com/f7d1baedca054dcbc8e0c6c058aff32ecae98716/ios/chrome/browser/ui/payments/BUILD.gn [modify] https://crrev.com/f7d1baedca054dcbc8e0c6c058aff32ecae98716/ios/chrome/browser/ui/popup_menu/BUILD.gn [delete] https://crrev.com/7e381b899f185e2780dcbe41adc8a4618a9b7e7e/ios/chrome/browser/ui/popup_menu/popup_menu_controller.h [delete] https://crrev.com/7e381b899f185e2780dcbe41adc8a4618a9b7e7e/ios/chrome/browser/ui/popup_menu/popup_menu_controller.mm [modify] https://crrev.com/f7d1baedca054dcbc8e0c6c058aff32ecae98716/ios/chrome/browser/ui/popup_menu/popup_menu_mediator.mm [delete] https://crrev.com/7e381b899f185e2780dcbe41adc8a4618a9b7e7e/ios/chrome/browser/ui/popup_menu/popup_menu_view.h [delete] https://crrev.com/7e381b899f185e2780dcbe41adc8a4618a9b7e7e/ios/chrome/browser/ui/popup_menu/popup_menu_view.mm [modify] https://crrev.com/f7d1baedca054dcbc8e0c6c058aff32ecae98716/ios/chrome/browser/ui/popup_menu/resources/BUILD.gn [delete] https://crrev.com/7e381b899f185e2780dcbe41adc8a4618a9b7e7e/ios/chrome/browser/ui/popup_menu/resources/popup_background.imageset/Contents.json [delete] https://crrev.com/7e381b899f185e2780dcbe41adc8a4618a9b7e7e/ios/chrome/browser/ui/popup_menu/resources/popup_background.imageset/popup_background.png [delete] https://crrev.com/7e381b899f185e2780dcbe41adc8a4618a9b7e7e/ios/chrome/browser/ui/popup_menu/resources/popup_background.imageset/popup_background@2x.png [delete] https://crrev.com/7e381b899f185e2780dcbe41adc8a4618a9b7e7e/ios/chrome/browser/ui/popup_menu/resources/popup_background.imageset/popup_background@3x.png [modify] https://crrev.com/f7d1baedca054dcbc8e0c6c058aff32ecae98716/ios/chrome/browser/ui/reading_list/BUILD.gn [modify] https://crrev.com/f7d1baedca054dcbc8e0c6c058aff32ecae98716/ios/chrome/browser/ui/reading_list/reading_list_egtest.mm [modify] https://crrev.com/f7d1baedca054dcbc8e0c6c058aff32ecae98716/ios/chrome/browser/ui/sad_tab/BUILD.gn [modify] https://crrev.com/f7d1baedca054dcbc8e0c6c058aff32ecae98716/ios/chrome/browser/ui/settings/BUILD.gn [modify] https://crrev.com/f7d1baedca054dcbc8e0c6c058aff32ecae98716/ios/chrome/browser/ui/settings/accounts_collection_egtest.mm [modify] https://crrev.com/f7d1baedca054dcbc8e0c6c058aff32ecae98716/ios/chrome/browser/ui/settings/autofill_credit_card_settings_egtest.mm [modify] https://crrev.com/f7d1baedca054dcbc8e0c6c058aff32ecae98716/ios/chrome/browser/ui/settings/autofill_profile_settings_egtest.mm [modify] https://crrev.com/f7d1baedca054dcbc8e0c6c058aff32ecae98716/ios/chrome/browser/ui/settings/block_popups_egtest.mm [modify] https://crrev.com/f7d1baedca054dcbc8e0c6c058aff32ecae98716/ios/chrome/browser/ui/settings/clear_browsing_data_egtest.mm [modify] https://crrev.com/f7d1baedca054dcbc8e0c6c058aff32ecae98716/ios/chrome/browser/ui/settings/passwords_settings_egtest.mm [modify] https://crrev.com/f7d1baedca054dcbc8e0c6c058aff32ecae98716/ios/chrome/browser/ui/settings/settings_egtest.mm [modify] https://crrev.com/f7d1baedca054dcbc8e0c6c058aff32ecae98716/ios/chrome/browser/ui/settings/sync_utils/BUILD.gn [modify] https://crrev.com/f7d1baedca054dcbc8e0c6c058aff32ecae98716/ios/chrome/browser/ui/settings/sync_utils/sync_fake_server_egtest.mm [modify] https://crrev.com/f7d1baedca054dcbc8e0c6c058aff32ecae98716/ios/chrome/browser/ui/settings/translate_ui_egtest.mm [modify] https://crrev.com/f7d1baedca054dcbc8e0c6c058aff32ecae98716/ios/chrome/browser/ui/tab_grid/BUILD.gn [modify] https://crrev.com/f7d1baedca054dcbc8e0c6c058aff32ecae98716/ios/chrome/browser/ui/tab_grid/tab_grid_egtest_util.mm [modify] https://crrev.com/f7d1baedca054dcbc8e0c6c058aff32ecae98716/ios/chrome/browser/ui/toolbar/BUILD.gn [modify] https://crrev.com/f7d1baedca054dcbc8e0c6c058aff32ecae98716/ios/chrome/browser/ui/toolbar/adaptive/BUILD.gn [modify] https://crrev.com/f7d1baedca054dcbc8e0c6c058aff32ecae98716/ios/chrome/browser/ui/toolbar/adaptive/adaptive_toolbar_egtest.mm [modify] https://crrev.com/f7d1baedca054dcbc8e0c6c058aff32ecae98716/ios/chrome/browser/ui/toolbar/adaptive/toolbar_coordinator_adaptor.h [modify] https://crrev.com/f7d1baedca054dcbc8e0c6c058aff32ecae98716/ios/chrome/browser/ui/toolbar/clean/BUILD.gn [modify] https://crrev.com/f7d1baedca054dcbc8e0c6c058aff32ecae98716/ios/chrome/browser/ui/toolbar/public/BUILD.gn [delete] https://crrev.com/7e381b899f185e2780dcbe41adc8a4618a9b7e7e/ios/chrome/browser/ui/tools_menu/BUILD.gn [delete] https://crrev.com/7e381b899f185e2780dcbe41adc8a4618a9b7e7e/ios/chrome/browser/ui/tools_menu/OWNERS [delete] https://crrev.com/7e381b899f185e2780dcbe41adc8a4618a9b7e7e/ios/chrome/browser/ui/tools_menu/new_tab_menu_view_item.h [delete] https://crrev.com/7e381b899f185e2780dcbe41adc8a4618a9b7e7e/ios/chrome/browser/ui/tools_menu/new_tab_menu_view_item.mm [delete] https://crrev.com/7e381b899f185e2780dcbe41adc8a4618a9b7e7e/ios/chrome/browser/ui/tools_menu/public/BUILD.gn [delete] https://crrev.com/7e381b899f185e2780dcbe41adc8a4618a9b7e7e/ios/chrome/browser/ui/tools_menu/public/tools_menu_configuration_provider.h [delete] https://crrev.com/7e381b899f185e2780dcbe41adc8a4618a9b7e7e/ios/chrome/browser/ui/tools_menu/public/tools_menu_constants.h [delete] https://crrev.com/7e381b899f185e2780dcbe41adc8a4618a9b7e7e/ios/chrome/browser/ui/tools_menu/public/tools_menu_constants.mm [delete] https://crrev.com/7e381b899f185e2780dcbe41adc8a4618a9b7e7e/ios/chrome/browser/ui/tools_menu/public/tools_menu_presentation_provider.h [delete] https://crrev.com/7e381b899f185e2780dcbe41adc8a4618a9b7e7e/ios/chrome/browser/ui/tools_menu/public/tools_menu_presentation_state_provider.h [delete] https://crrev.com/7e381b899f185e2780dcbe41adc8a4618a9b7e7e/ios/chrome/browser/ui/tools_menu/reading_list_menu_view_item.h [delete] https://crrev.com/7e381b899f185e2780dcbe41adc8a4618a9b7e7e/ios/chrome/browser/ui/tools_menu/reading_list_menu_view_item.mm [delete] https://crrev.com/7e381b899f185e2780dcbe41adc8a4618a9b7e7e/ios/chrome/browser/ui/tools_menu/reading_list_menu_view_item_unittest.mm [delete] https://crrev.com/7e381b899f185e2780dcbe41adc8a4618a9b7e7e/ios/chrome/browser/ui/tools_menu/tools_menu_configuration.h [delete] https://crrev.com/7e381b899f185e2780dcbe41adc8a4618a9b7e7e/ios/chrome/browser/ui/tools_menu/tools_menu_configuration.mm [delete] https://crrev.com/7e381b899f185e2780dcbe41adc8a4618a9b7e7e/ios/chrome/browser/ui/tools_menu/tools_menu_coordinator.h [delete] https://crrev.com/7e381b899f185e2780dcbe41adc8a4618a9b7e7e/ios/chrome/browser/ui/tools_menu/tools_menu_coordinator.mm [delete] https://crrev.com/7e381b899f185e2780dcbe41adc8a4618a9b7e7e/ios/chrome/browser/ui/tools_menu/tools_menu_model.h [delete] https://crrev.com/7e381b899f185e2780dcbe41adc8a4618a9b7e7e/ios/chrome/browser/ui/tools_menu/tools_menu_model.mm [delete] https://crrev.com/7e381b899f185e2780dcbe41adc8a4618a9b7e7e/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.h [delete] https://crrev.com/7e381b899f185e2780dcbe41adc8a4618a9b7e7e/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.mm [delete] https://crrev.com/7e381b899f185e2780dcbe41adc8a4618a9b7e7e/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller_unittest.mm [delete] https://crrev.com/7e381b899f185e2780dcbe41adc8a4618a9b7e7e/ios/chrome/browser/ui/tools_menu/tools_menu_view_item.h [delete] https://crrev.com/7e381b899f185e2780dcbe41adc8a4618a9b7e7e/ios/chrome/browser/ui/tools_menu/tools_menu_view_item.mm [delete] https://crrev.com/7e381b899f185e2780dcbe41adc8a4618a9b7e7e/ios/chrome/browser/ui/tools_menu/tools_menu_view_item_unittest.mm [delete] https://crrev.com/7e381b899f185e2780dcbe41adc8a4618a9b7e7e/ios/chrome/browser/ui/tools_menu/tools_menu_view_tools_cell.h [delete] https://crrev.com/7e381b899f185e2780dcbe41adc8a4618a9b7e7e/ios/chrome/browser/ui/tools_menu/tools_menu_view_tools_cell.mm [delete] https://crrev.com/7e381b899f185e2780dcbe41adc8a4618a9b7e7e/ios/chrome/browser/ui/tools_menu/tools_popup_controller.h [delete] https://crrev.com/7e381b899f185e2780dcbe41adc8a4618a9b7e7e/ios/chrome/browser/ui/tools_menu/tools_popup_controller.mm [modify] https://crrev.com/f7d1baedca054dcbc8e0c6c058aff32ecae98716/ios/chrome/test/BUILD.gn [modify] https://crrev.com/f7d1baedca054dcbc8e0c6c058aff32ecae98716/ios/chrome/test/earl_grey/BUILD.gn [modify] https://crrev.com/f7d1baedca054dcbc8e0c6c058aff32ecae98716/ios/chrome/test/earl_grey/chrome_earl_grey_ui.mm [modify] https://crrev.com/f7d1baedca054dcbc8e0c6c058aff32ecae98716/ios/chrome/test/earl_grey/chrome_matchers.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/172d0cd082939480cb1b0bfed3367c89dea547c6 commit 172d0cd082939480cb1b0bfed3367c89dea547c6 Author: Gauthier Ambard <gambard@chromium.org> Date: Wed Sep 26 11:46:47 2018 [iOS] Additional cleanup This CL removes some code as part of the post-UI Refresh cleanup. Bug: 800266 , 884725 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I0d31f1a42f50762c7b82dae639f79b77688d3ad9 Reviewed-on: https://chromium-review.googlesource.com/1245443 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#594283} [modify] https://crrev.com/172d0cd082939480cb1b0bfed3367c89dea547c6/ios/chrome/app/application_delegate/app_state.mm [modify] https://crrev.com/172d0cd082939480cb1b0bfed3367c89dea547c6/ios/chrome/browser/ui/background_generator.h [modify] https://crrev.com/172d0cd082939480cb1b0bfed3367c89dea547c6/ios/chrome/browser/ui/background_generator.mm [modify] https://crrev.com/172d0cd082939480cb1b0bfed3367c89dea547c6/ios/chrome/browser/ui/commands/BUILD.gn [modify] https://crrev.com/172d0cd082939480cb1b0bfed3367c89dea547c6/ios/chrome/browser/ui/commands/browser_commands.h [delete] https://crrev.com/ef5c93d6c77e13eeb9628553e0f2d48d8e8421cc/ios/chrome/browser/ui/commands/tools_menu_commands.h [modify] https://crrev.com/172d0cd082939480cb1b0bfed3367c89dea547c6/ios/chrome/browser/ui/omnibox/omnibox_text_field_ios.mm [modify] https://crrev.com/172d0cd082939480cb1b0bfed3367c89dea547c6/ios/chrome/browser/ui/popup_menu/popup_menu_mediator.mm [modify] https://crrev.com/172d0cd082939480cb1b0bfed3367c89dea547c6/ios/chrome/browser/ui/reading_list/reading_list_menu_notification_delegate.h [modify] https://crrev.com/172d0cd082939480cb1b0bfed3367c89dea547c6/ios/chrome/browser/ui/reading_list/reading_list_menu_notifier.h [modify] https://crrev.com/172d0cd082939480cb1b0bfed3367c89dea547c6/ios/chrome/browser/ui/reading_list/reading_list_menu_notifier.mm [modify] https://crrev.com/172d0cd082939480cb1b0bfed3367c89dea547c6/ios/chrome/browser/ui/side_swipe/card_side_swipe_view.mm [modify] https://crrev.com/172d0cd082939480cb1b0bfed3367c89dea547c6/ios/chrome/browser/ui/toolbar/adaptive/adaptive_toolbar_egtest.mm [modify] https://crrev.com/172d0cd082939480cb1b0bfed3367c89dea547c6/ios/chrome/browser/ui/toolbar/buttons/toolbar_button_factory.h [modify] https://crrev.com/172d0cd082939480cb1b0bfed3367c89dea547c6/ios/chrome/browser/ui/toolbar/buttons/toolbar_button_factory.mm [modify] https://crrev.com/172d0cd082939480cb1b0bfed3367c89dea547c6/ios/chrome/browser/ui/toolbar/buttons/toolbar_constants.h [modify] https://crrev.com/172d0cd082939480cb1b0bfed3367c89dea547c6/ios/chrome/browser/ui/toolbar/buttons/toolbar_constants.mm [modify] https://crrev.com/172d0cd082939480cb1b0bfed3367c89dea547c6/ios/chrome/browser/ui/toolbar/buttons/toolbar_tools_menu_button.h [modify] https://crrev.com/172d0cd082939480cb1b0bfed3367c89dea547c6/ios/chrome/browser/ui/toolbar/buttons/toolbar_tools_menu_button.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b68a800d5d6bc8951a7b7a89c81ce5d0dfcfad52 commit b68a800d5d6bc8951a7b7a89c81ce5d0dfcfad52 Author: Gauthier Ambard <gambard@chromium.org> Date: Wed Sep 26 12:41:58 2018 [iOS] Remove Toolbar images This CL removes the legacy toolbar images. Bug: 800266 , 884724 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ia336af4492e6d3581dd94a2209fc27d809acf57f Reviewed-on: https://chromium-review.googlesource.com/1243287 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#594291} [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_100_percent/toolbar_dark_back.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_100_percent/toolbar_dark_back_disabled.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_100_percent/toolbar_dark_back_pressed.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_100_percent/toolbar_dark_background.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_100_percent/toolbar_dark_forward.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_100_percent/toolbar_dark_forward_disabled.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_100_percent/toolbar_dark_forward_pressed.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_100_percent/toolbar_dark_overview.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_100_percent/toolbar_dark_overview_disabled.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_100_percent/toolbar_dark_overview_pressed.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_100_percent/toolbar_dark_reload.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_100_percent/toolbar_dark_reload_disabled.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_100_percent/toolbar_dark_reload_pressed.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_100_percent/toolbar_dark_share.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_100_percent/toolbar_dark_share_disabled.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_100_percent/toolbar_dark_share_pressed.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_100_percent/toolbar_dark_star.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_100_percent/toolbar_dark_star_pressed.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_100_percent/toolbar_dark_stop.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_100_percent/toolbar_dark_stop_disabled.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_100_percent/toolbar_dark_stop_pressed.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_100_percent/toolbar_dark_tools.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_100_percent/toolbar_dark_tools_pressed.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_100_percent/toolbar_dark_voice.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_100_percent/toolbar_dark_voice_pressed.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_100_percent/toolbar_light_back.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_100_percent/toolbar_light_back_disabled.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_100_percent/toolbar_light_back_pressed.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_100_percent/toolbar_light_background.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_100_percent/toolbar_light_callingapp.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_100_percent/toolbar_light_callingapp_pressed.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_100_percent/toolbar_light_forward.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_100_percent/toolbar_light_forward_disabled.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_100_percent/toolbar_light_forward_pressed.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_100_percent/toolbar_light_overview.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_100_percent/toolbar_light_overview_disabled.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_100_percent/toolbar_light_overview_pressed.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_100_percent/toolbar_light_reload.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_100_percent/toolbar_light_reload_disabled.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_100_percent/toolbar_light_reload_pressed.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_100_percent/toolbar_light_share.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_100_percent/toolbar_light_share_disabled.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_100_percent/toolbar_light_share_pressed.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_100_percent/toolbar_light_star.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_100_percent/toolbar_light_star_pressed.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_100_percent/toolbar_light_stop.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_100_percent/toolbar_light_stop_disabled.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_100_percent/toolbar_light_stop_pressed.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_100_percent/toolbar_light_tools.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_100_percent/toolbar_light_tools_pressed.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_100_percent/toolbar_light_voice.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_100_percent/toolbar_light_voice_pressed.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_100_percent/toolbar_shadow.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_100_percent/toolbar_shadow_full_bleed.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_100_percent/toolbar_tts.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_100_percent/toolbar_tts_pressed.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_200_percent/toolbar_dark_back.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_200_percent/toolbar_dark_back_disabled.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_200_percent/toolbar_dark_back_pressed.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_200_percent/toolbar_dark_background.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_200_percent/toolbar_dark_forward.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_200_percent/toolbar_dark_forward_disabled.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_200_percent/toolbar_dark_forward_pressed.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_200_percent/toolbar_dark_overview.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_200_percent/toolbar_dark_overview_disabled.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_200_percent/toolbar_dark_overview_pressed.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_200_percent/toolbar_dark_reload.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_200_percent/toolbar_dark_reload_disabled.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_200_percent/toolbar_dark_reload_pressed.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_200_percent/toolbar_dark_share.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_200_percent/toolbar_dark_share_disabled.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_200_percent/toolbar_dark_share_pressed.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_200_percent/toolbar_dark_star.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_200_percent/toolbar_dark_star_pressed.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_200_percent/toolbar_dark_stop.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_200_percent/toolbar_dark_stop_disabled.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_200_percent/toolbar_dark_stop_pressed.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_200_percent/toolbar_dark_tools.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_200_percent/toolbar_dark_tools_pressed.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_200_percent/toolbar_dark_voice.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_200_percent/toolbar_dark_voice_pressed.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_200_percent/toolbar_light_back.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_200_percent/toolbar_light_back_disabled.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_200_percent/toolbar_light_back_pressed.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_200_percent/toolbar_light_background.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_200_percent/toolbar_light_callingapp.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_200_percent/toolbar_light_callingapp_pressed.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_200_percent/toolbar_light_forward.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_200_percent/toolbar_light_forward_disabled.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_200_percent/toolbar_light_forward_pressed.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_200_percent/toolbar_light_overview.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_200_percent/toolbar_light_overview_disabled.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_200_percent/toolbar_light_overview_pressed.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_200_percent/toolbar_light_reload.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_200_percent/toolbar_light_reload_disabled.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_200_percent/toolbar_light_reload_pressed.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_200_percent/toolbar_light_share.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_200_percent/toolbar_light_share_disabled.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_200_percent/toolbar_light_share_pressed.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_200_percent/toolbar_light_star.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_200_percent/toolbar_light_star_pressed.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_200_percent/toolbar_light_stop.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_200_percent/toolbar_light_stop_disabled.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_200_percent/toolbar_light_stop_pressed.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_200_percent/toolbar_light_tools.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_200_percent/toolbar_light_tools_pressed.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_200_percent/toolbar_light_voice.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_200_percent/toolbar_light_voice_pressed.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_200_percent/toolbar_shadow.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_200_percent/toolbar_shadow_full_bleed.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_200_percent/toolbar_tts.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_200_percent/toolbar_tts_pressed.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_300_percent/toolbar_dark_back.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_300_percent/toolbar_dark_back_disabled.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_300_percent/toolbar_dark_back_pressed.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_300_percent/toolbar_dark_background.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_300_percent/toolbar_dark_forward.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_300_percent/toolbar_dark_forward_disabled.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_300_percent/toolbar_dark_forward_pressed.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_300_percent/toolbar_dark_overview.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_300_percent/toolbar_dark_overview_disabled.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_300_percent/toolbar_dark_overview_pressed.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_300_percent/toolbar_dark_reload.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_300_percent/toolbar_dark_reload_disabled.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_300_percent/toolbar_dark_reload_pressed.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_300_percent/toolbar_dark_share.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_300_percent/toolbar_dark_share_disabled.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_300_percent/toolbar_dark_share_pressed.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_300_percent/toolbar_dark_star.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_300_percent/toolbar_dark_star_filled.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_300_percent/toolbar_dark_stop.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_300_percent/toolbar_dark_stop_disabled.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_300_percent/toolbar_dark_stop_pressed.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_300_percent/toolbar_dark_tools.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_300_percent/toolbar_dark_tools_pressed.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_300_percent/toolbar_dark_voice.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_300_percent/toolbar_dark_voice_pressed.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_300_percent/toolbar_light_back.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_300_percent/toolbar_light_back_disabled.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_300_percent/toolbar_light_back_pressed.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_300_percent/toolbar_light_background.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_300_percent/toolbar_light_callingapp.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_300_percent/toolbar_light_callingapp_pressed.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_300_percent/toolbar_light_forward.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_300_percent/toolbar_light_forward_disabled.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_300_percent/toolbar_light_forward_pressed.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_300_percent/toolbar_light_overview.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_300_percent/toolbar_light_overview_disabled.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_300_percent/toolbar_light_overview_pressed.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_300_percent/toolbar_light_reload.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_300_percent/toolbar_light_reload_disabled.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_300_percent/toolbar_light_reload_pressed.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_300_percent/toolbar_light_share.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_300_percent/toolbar_light_share_disabled.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_300_percent/toolbar_light_share_pressed.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_300_percent/toolbar_light_star.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_300_percent/toolbar_light_star_pressed.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_300_percent/toolbar_light_stop.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_300_percent/toolbar_light_stop_disabled.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_300_percent/toolbar_light_stop_pressed.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_300_percent/toolbar_light_tools.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_300_percent/toolbar_light_tools_pressed.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_300_percent/toolbar_light_voice.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_300_percent/toolbar_light_voice_pressed.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_300_percent/toolbar_shadow.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_300_percent/toolbar_shadow_full_bleed.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_300_percent/toolbar_tts.png [delete] https://crrev.com/7e3dbd0d31015b9f931f496c0d771461dc395c1f/ios/chrome/app/theme/default_300_percent/toolbar_tts_pressed.png [modify] https://crrev.com/b68a800d5d6bc8951a7b7a89c81ce5d0dfcfad52/ios/chrome/app/theme/ios_theme_resources.grd [modify] https://crrev.com/b68a800d5d6bc8951a7b7a89c81ce5d0dfcfad52/ios/chrome/browser/providers/images/chromium_branded_image_provider.h [modify] https://crrev.com/b68a800d5d6bc8951a7b7a89c81ce5d0dfcfad52/ios/chrome/browser/providers/images/chromium_branded_image_provider.mm [modify] https://crrev.com/b68a800d5d6bc8951a7b7a89c81ce5d0dfcfad52/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_legacy_presenter.mm [modify] https://crrev.com/b68a800d5d6bc8951a7b7a89c81ce5d0dfcfad52/ios/chrome/browser/ui/overscroll_actions/overscroll_actions_view.mm [modify] https://crrev.com/b68a800d5d6bc8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fb4d3d03acd33e6dc1b3f0238ac7ec719c31394b commit fb4d3d03acd33e6dc1b3f0238ac7ec719c31394b Author: Gauthier Ambard <gambard@chromium.org> Date: Wed Sep 26 12:51:23 2018 [iOS] Remove the ToolbarOwner protocol The ToolbarOwner protocol was used in the TabSwitcher/StackView animations. Now that they are removed, the protocol can be removed too. Bug: 800266 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I26ea284194530e614afac161cc9db582963b00ee Reviewed-on: https://chromium-review.googlesource.com/1245464 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#594293} [modify] https://crrev.com/fb4d3d03acd33e6dc1b3f0238ac7ec719c31394b/ios/chrome/app/main_controller.mm [modify] https://crrev.com/fb4d3d03acd33e6dc1b3f0238ac7ec719c31394b/ios/chrome/browser/ui/browser_view_controller.h [modify] https://crrev.com/fb4d3d03acd33e6dc1b3f0238ac7ec719c31394b/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/fb4d3d03acd33e6dc1b3f0238ac7ec719c31394b/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view.h [modify] https://crrev.com/fb4d3d03acd33e6dc1b3f0238ac7ec719c31394b/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view.mm [modify] https://crrev.com/fb4d3d03acd33e6dc1b3f0238ac7ec719c31394b/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view_controller.h [modify] https://crrev.com/fb4d3d03acd33e6dc1b3f0238ac7ec719c31394b/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view_controller.mm [modify] https://crrev.com/fb4d3d03acd33e6dc1b3f0238ac7ec719c31394b/ios/chrome/browser/ui/main/tab_switcher.h [modify] https://crrev.com/fb4d3d03acd33e6dc1b3f0238ac7ec719c31394b/ios/chrome/browser/ui/ntp/new_tab_page_controller.h [modify] https://crrev.com/fb4d3d03acd33e6dc1b3f0238ac7ec719c31394b/ios/chrome/browser/ui/ntp/new_tab_page_controller.mm [modify] https://crrev.com/fb4d3d03acd33e6dc1b3f0238ac7ec719c31394b/ios/chrome/browser/ui/tab_grid/tab_grid_coordinator_unittest.mm [modify] https://crrev.com/fb4d3d03acd33e6dc1b3f0238ac7ec719c31394b/ios/chrome/browser/ui/toolbar/BUILD.gn [modify] https://crrev.com/fb4d3d03acd33e6dc1b3f0238ac7ec719c31394b/ios/chrome/browser/ui/toolbar/legacy_toolbar_ui_updater.h [modify] https://crrev.com/fb4d3d03acd33e6dc1b3f0238ac7ec719c31394b/ios/chrome/browser/ui/toolbar/legacy_toolbar_ui_updater.mm [modify] https://crrev.com/fb4d3d03acd33e6dc1b3f0238ac7ec719c31394b/ios/chrome/browser/ui/toolbar/legacy_toolbar_ui_updater_unittest.mm [delete] https://crrev.com/a8b5ba02d5a5ce9e0678fc2f21de3221b1326572/ios/chrome/browser/ui/toolbar/toolbar_owner.h [delete] https://crrev.com/a8b5ba02d5a5ce9e0678fc2f21de3221b1326572/ios/chrome/browser/ui/toolbar/toolbar_snapshot_providing.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6b6a1caafe1c01007b2f6804855fa22d748b2267 commit 6b6a1caafe1c01007b2f6804855fa22d748b2267 Author: Gauthier Ambard <gambard@chromium.org> Date: Wed Sep 26 13:13:21 2018 [iOS] Remove the openNewTab command The openNewTab command was only used by the TabSwitcher. Bug: 800266 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ia33d9099c69e0f45caeb78b1c078be2f7e3097aa Reviewed-on: https://chromium-review.googlesource.com/1245789 Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#594294} [modify] https://crrev.com/6b6a1caafe1c01007b2f6804855fa22d748b2267/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/6b6a1caafe1c01007b2f6804855fa22d748b2267/ios/chrome/browser/ui/commands/browser_commands.h [modify] https://crrev.com/6b6a1caafe1c01007b2f6804855fa22d748b2267/ios/chrome/browser/ui/print/print_controller_egtest.mm [modify] https://crrev.com/6b6a1caafe1c01007b2f6804855fa22d748b2267/ios/chrome/browser/ui/tabs/tab_strip_controller.mm [modify] https://crrev.com/6b6a1caafe1c01007b2f6804855fa22d748b2267/ios/chrome/test/app/chrome_test_util.h [modify] https://crrev.com/6b6a1caafe1c01007b2f6804855fa22d748b2267/ios/chrome/test/app/chrome_test_util.mm [modify] https://crrev.com/6b6a1caafe1c01007b2f6804855fa22d748b2267/ios/chrome/test/app/tab_test_util.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dcecc8744986b052de19efbe49ee81dfa1903ca1 commit dcecc8744986b052de19efbe49ee81dfa1903ca1 Author: Gauthier Ambard <gambard@chromium.org> Date: Wed Sep 26 14:37:50 2018 [iOS] Reorganize toolbar's folder Now that the toolbar's files have been cleaned up after UI Refresh, the folder can be reorganized. The files related to the fullscreen features are moved to a separate folder. The toolbar model delegate gets its own gn target. The resources are unused and are removed. Bug: 800266 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I0e7043e13c2c90c6f939af55d7e447f929667681 Reviewed-on: https://chromium-review.googlesource.com/1245798 Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#594311} [modify] https://crrev.com/dcecc8744986b052de19efbe49ee81dfa1903ca1/ios/chrome/browser/tabs/BUILD.gn [modify] https://crrev.com/dcecc8744986b052de19efbe49ee81dfa1903ca1/ios/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/dcecc8744986b052de19efbe49ee81dfa1903ca1/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/dcecc8744986b052de19efbe49ee81dfa1903ca1/ios/chrome/browser/ui/content_suggestions/BUILD.gn [modify] https://crrev.com/dcecc8744986b052de19efbe49ee81dfa1903ca1/ios/chrome/browser/ui/content_suggestions/content_suggestions_coordinator.mm [modify] https://crrev.com/dcecc8744986b052de19efbe49ee81dfa1903ca1/ios/chrome/browser/ui/ntp/BUILD.gn [modify] https://crrev.com/dcecc8744986b052de19efbe49ee81dfa1903ca1/ios/chrome/browser/ui/qr_scanner/BUILD.gn [modify] https://crrev.com/dcecc8744986b052de19efbe49ee81dfa1903ca1/ios/chrome/browser/ui/side_swipe/BUILD.gn [modify] https://crrev.com/dcecc8744986b052de19efbe49ee81dfa1903ca1/ios/chrome/browser/ui/toolbar/BUILD.gn [modify] https://crrev.com/dcecc8744986b052de19efbe49ee81dfa1903ca1/ios/chrome/browser/ui/toolbar/adaptive/BUILD.gn [modify] https://crrev.com/dcecc8744986b052de19efbe49ee81dfa1903ca1/ios/chrome/browser/ui/toolbar/clean/BUILD.gn [add] https://crrev.com/dcecc8744986b052de19efbe49ee81dfa1903ca1/ios/chrome/browser/ui/toolbar/fullscreen/BUILD.gn [rename] https://crrev.com/dcecc8744986b052de19efbe49ee81dfa1903ca1/ios/chrome/browser/ui/toolbar/fullscreen/legacy_toolbar_ui_updater.h [rename] https://crrev.com/dcecc8744986b052de19efbe49ee81dfa1903ca1/ios/chrome/browser/ui/toolbar/fullscreen/legacy_toolbar_ui_updater.mm [rename] https://crrev.com/dcecc8744986b052de19efbe49ee81dfa1903ca1/ios/chrome/browser/ui/toolbar/fullscreen/legacy_toolbar_ui_updater_unittest.mm [rename] https://crrev.com/dcecc8744986b052de19efbe49ee81dfa1903ca1/ios/chrome/browser/ui/toolbar/fullscreen/toolbar_ui.h [rename] https://crrev.com/dcecc8744986b052de19efbe49ee81dfa1903ca1/ios/chrome/browser/ui/toolbar/fullscreen/toolbar_ui.mm [rename] https://crrev.com/dcecc8744986b052de19efbe49ee81dfa1903ca1/ios/chrome/browser/ui/toolbar/fullscreen/toolbar_ui_broadcasting_util.h [rename] https://crrev.com/dcecc8744986b052de19efbe49ee81dfa1903ca1/ios/chrome/browser/ui/toolbar/fullscreen/toolbar_ui_broadcasting_util.mm [rename] https://crrev.com/dcecc8744986b052de19efbe49ee81dfa1903ca1/ios/chrome/browser/ui/toolbar/fullscreen/toolbar_ui_broadcasting_util_unittest.mm [delete] https://crrev.com/97ec10ef30d024b391967066f22659be34325f1d/ios/chrome/browser/ui/toolbar/resources/BUILD.gn [delete] https://crrev.com/97ec10ef30d024b391967066f22659be34325f1d/ios/chrome/browser/ui/toolbar/resources/toolbar_dark_newtab.imageset/Contents.json [delete] https://crrev.com/97ec10ef30d024b391967066f22659be34325f1d/ios/chrome/browser/ui/toolbar/resources/toolbar_dark_newtab.imageset/toolbar_dark_newtab.png [delete] https://crrev.com/97ec10ef30d024b391967066f22659be34325f1d/ios/chrome/browser/ui/toolbar/resources/toolbar_dark_newtab.imageset/toolbar_dark_newtab@2x.png [delete] https://crrev.com/97ec10ef30d024b391967066f22659be34325f1d/ios/chrome/browser/ui/toolbar/resources/toolbar_dark_newtab.imageset/toolbar_dark_newtab@3x.png [delete] https://crrev.com/97ec10ef30d024b391967066f22659be34325f1d/ios/chrome/browser/ui/toolbar/resources/toolbar_dark_newtab_active.imageset/Contents.json [delete] https://crrev.com/97ec10ef30d024b391967066f22659be34325f1d/ios/chrome/browser/ui/toolbar/resources/toolbar_dark_newtab_active.imageset/toolbar_dark_newtab_active.png [delete] https://crrev.com/97ec10ef30d024b391967066f22659be34325f1d/ios/chrome/browser/ui/toolbar/resources/toolbar_dark_newtab_active.imageset/toolbar_dark_newtab_active@2x.png [delete] https://crrev.com/97ec10ef30d024b391967066f22659be34325f1d/ios/chrome/browser/ui/toolbar/resources/toolbar_dark_newtab_active.imageset/toolbar_dark_newtab_active@3x.png [delete] https://crrev.com/97ec10ef30d024b391967066f22659be34325f1d/ios/chrome/browser/ui/toolbar/resources/toolbar_dark_newtab_incognito.imageset/Contents.json [delete] https://crrev.com/97ec10ef30d024b391967066f22659be34325f1d/ios/chrome/browser/ui/toolbar/resources/toolbar_dark_newtab_incognito.imageset/toolbar_dark_newtab_incognito.png [delete] https://crrev.com/97ec10ef30d024b391967066f22659be34325f1d/ios/chrome/browser/ui/toolbar/resources/toolbar_dark_newtab_incognito.imageset/toolbar_dark_newtab_incognito@2x.png [delete] https://crrev.com/97ec10ef30d024b391967066f22659be34325f1d/ios/chrome/browser/ui/toolbar/resources/toolbar_dark_newtab_incognito.imageset/toolbar_dark_newtab_incognito@3x.png [delete] https://crrev.com/97ec10ef30d024b391967066f22659be34325f1d/ios/chrome/browser/ui/toolbar/resources/toolbar_dark_newtab_incognito_active.imageset/Contents.json [delete] https://crrev.com/97ec10ef30d024b391967066f22659be34325f1d/ios/chrome/browser/ui/toolbar/resources/toolbar_dark_newtab_incognito_active.imageset/toolbar_dark_newtab_incognito_active.png [delete] https://crrev.com/97ec10ef30d024b391967066f22659be34325f1d/ios/chrome/browser/ui/toolbar/resources/toolbar_dark_newtab_incognito_active.imageset/toolbar_dark_newtab_incognito_active@2x.png [delete] https://crrev.com/97ec10ef30d024b391967066f22659be34325f1d/ios/chrome/browser/ui/toolbar/resources/toolbar_dark_newtab_incognito_active.imageset/toolbar_dark_newtab_incognito_active@3x.png [modify] https://crrev.com/dcecc8744986b052de19efbe49ee81dfa1903ca1/ios/chrome/browser/ui/toolbar/test/BUILD.gn [modify] https://crrev.com/dcecc8744986b052de19efbe49ee81dfa1903ca1/ios/chrome/browser/ui/toolbar/test/toolbar_broadcast_test_util.mm [modify] https://crrev.com/dcecc8744986b052de19efbe49ee81dfa1903ca1/ios/chrome/test/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b27600c3654e7d3012623412b9e80d8f92a7bb95 commit b27600c3654e7d3012623412b9e80d8f92a7bb95 Author: Gauthier Ambard <gambard@chromium.org> Date: Wed Sep 26 15:53:16 2018 [iOS] Move toolbar files to their root folder This CL moves the clean and adaptive toolbar files to the toolbar folder directly. Now that there is only one toolbar implementation, it is no longer needed to separate the files. Bug: 800266 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I348caff07d9d7fd7759e447ec615e3d3ec7f337f Reviewed-on: https://chromium-review.googlesource.com/1245712 Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#594328} [modify] https://crrev.com/b27600c3654e7d3012623412b9e80d8f92a7bb95/ios/chrome/app/BUILD.gn [modify] https://crrev.com/b27600c3654e7d3012623412b9e80d8f92a7bb95/ios/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/b27600c3654e7d3012623412b9e80d8f92a7bb95/ios/chrome/browser/ui/browser_view_controller.h [modify] https://crrev.com/b27600c3654e7d3012623412b9e80d8f92a7bb95/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/b27600c3654e7d3012623412b9e80d8f92a7bb95/ios/chrome/browser/ui/content_suggestions/BUILD.gn [modify] https://crrev.com/b27600c3654e7d3012623412b9e80d8f92a7bb95/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view_controller.mm [modify] https://crrev.com/b27600c3654e7d3012623412b9e80d8f92a7bb95/ios/chrome/browser/ui/location_bar/BUILD.gn [modify] https://crrev.com/b27600c3654e7d3012623412b9e80d8f92a7bb95/ios/chrome/browser/ui/location_bar/location_bar_coordinator.mm [modify] https://crrev.com/b27600c3654e7d3012623412b9e80d8f92a7bb95/ios/chrome/browser/ui/location_bar/location_bar_coordinator_unittest.mm [modify] https://crrev.com/b27600c3654e7d3012623412b9e80d8f92a7bb95/ios/chrome/browser/ui/location_bar/location_bar_legacy_coordinator.mm [modify] https://crrev.com/b27600c3654e7d3012623412b9e80d8f92a7bb95/ios/chrome/browser/ui/omnibox_perftest.mm [modify] https://crrev.com/b27600c3654e7d3012623412b9e80d8f92a7bb95/ios/chrome/browser/ui/qr_scanner/BUILD.gn [modify] https://crrev.com/b27600c3654e7d3012623412b9e80d8f92a7bb95/ios/chrome/browser/ui/side_swipe/BUILD.gn [modify] https://crrev.com/b27600c3654e7d3012623412b9e80d8f92a7bb95/ios/chrome/browser/ui/side_swipe/side_swipe_egtest.mm [modify] https://crrev.com/b27600c3654e7d3012623412b9e80d8f92a7bb95/ios/chrome/browser/ui/toolbar/BUILD.gn [delete] https://crrev.com/b9ad9db79f527c22d34a34deac65d518638d13c7/ios/chrome/browser/ui/toolbar/adaptive/BUILD.gn [delete] https://crrev.com/b9ad9db79f527c22d34a34deac65d518638d13c7/ios/chrome/browser/ui/toolbar/adaptive/adaptive_toolbar_view_controller+subclassing.h [delete] https://crrev.com/b9ad9db79f527c22d34a34deac65d518638d13c7/ios/chrome/browser/ui/toolbar/adaptive/secondary_toolbar_coordinator.h [delete] https://crrev.com/b9ad9db79f527c22d34a34deac65d518638d13c7/ios/chrome/browser/ui/toolbar/adaptive/secondary_toolbar_view_controller.h [rename] https://crrev.com/b27600c3654e7d3012623412b9e80d8f92a7bb95/ios/chrome/browser/ui/toolbar/adaptive_toolbar_coordinator+subclassing.h [rename] https://crrev.com/b27600c3654e7d3012623412b9e80d8f92a7bb95/ios/chrome/browser/ui/toolbar/adaptive_toolbar_coordinator.h [rename] https://crrev.com/b27600c3654e7d3012623412b9e80d8f92a7bb95/ios/chrome/browser/ui/toolbar/adaptive_toolbar_coordinator.mm [rename] https://crrev.com/b27600c3654e7d3012623412b9e80d8f92a7bb95/ios/chrome/browser/ui/toolbar/adaptive_toolbar_egtest.mm [rename] https://crrev.com/b27600c3654e7d3012623412b9e80d8f92a7bb95/ios/chrome/browser/ui/toolbar/adaptive_toolbar_view.h [add] https://crrev.com/b27600c3654e7d3012623412b9e80d8f92a7bb95/ios/chrome/browser/ui/toolbar/adaptive_toolbar_view_controller+subclassing.h [rename] https://crrev.com/b27600c3654e7d3012623412b9e80d8f92a7bb95/ios/chrome/browser/ui/toolbar/adaptive_toolbar_view_controller.h [rename] https://crrev.com/b27600c3654e7d3012623412b9e80d8f92a7bb95/ios/chrome/browser/ui/toolbar/adaptive_toolbar_view_controller.mm [rename] https://crrev.com/b27600c3654e7d3012623412b9e80d8f92a7bb95/ios/chrome/browser/ui/toolbar/adaptive_toolbar_view_controller_unittest.mm [delete] https://crrev.com/b9ad9db79f527c22d34a34deac65d518638d13c7/ios/chrome/browser/ui/toolbar/clean/BUILD.gn [rename] https://crrev.com/b27600c3654e7d3012623412b9e80d8f92a7bb95/ios/chrome/browser/ui/toolbar/primary_toolbar_coordinator.h [rename] https://crrev.com/b27600c3654e7d3012623412b9e80d8f92a7bb95/ios/chrome/browser/ui/toolbar/primary_toolbar_coordinator.mm [rename] https://crrev.com/b27600c3654e7d3012623412b9e80d8f92a7bb95/ios/chrome/browser/ui/toolbar/primary_toolbar_view.h [rename] https://crrev.com/b27600c3654e7d3012623412b9e80d8f92a7bb95/ios/chrome/browser/ui/toolbar/primary_toolbar_view.mm [rename] https://crrev.com/b27600c3654e7d3012623412b9e80d8f92a7bb95/ios/chrome/browser/ui/toolbar/primary_toolbar_view_controller.h [rename] https://crrev.com/b27600c3654e7d3012623412b9e80d8f92a7bb95/ios/chrome/browser/ui/toolbar/primary_toolbar_view_controller.mm [rename] https://crrev.com/b27600c3654e7d3012623412b9e80d8f92a7bb95/ios/chrome/browser/ui/toolbar/primary_toolbar_view_controller_delegate.h [add] https://crrev.com/b27600c3654e7d3012623412b9e80d8f92a7bb95/ios/chrome/browser/ui/toolbar/secondary_toolbar_coordinator.h [rename] https://crrev.com/b27600c3654e7d3012623412b9e80d8f92a7bb95/ios/chrome/browser/ui/toolbar/secondary_toolbar_coordinator.mm [rename] https://crrev.com/b27600c3654e7d3012623412b9e80d8f92a7bb95/ios/chrome/browser/ui/toolbar/secondary_toolbar_view.h [rename] https://crrev.com/b27600c3654e7d3012623412b9e80d8f92a7bb95/ios/chrome/browser/ui/toolbar/secondary_toolbar_view.mm [add] https://crrev.com/b27600c3654e7d3012623412b9e80d8f92a7bb95/ios/chrome/browser/ui/toolbar/secondary_toolbar_view_controller.h [rename] https://crrev.com/b27600c3654e7d3012623412b9e80d8f92a7bb95/ios/chrome/browser/ui/toolbar/secondary_toolbar_view_controller.mm [rename] https://crrev.com/b27600c3654e7d3012623412b9e80d8f92a7bb95/ios/chrome/browser/ui/toolbar/toolbar_consumer.h [rename] https://crrev.com/b27600c3654e7d3012623412b9e80d8f92a7bb95/ios/chrome/browser/ui/toolbar/toolbar_coordinatee.h [rename] https://crrev.com/b27600c3654e7d3012623412b9e80d8f92a7bb95/ios/chrome/browser/ui/toolbar/toolbar_coordinator_adaptor.h [rename] https://crrev.com/b27600c3654e7d3012623412b9e80d8f92a7bb95/ios/chrome/browser/ui/toolbar/toolbar_coordinator_adaptor.mm [rename] https://crrev.com/b27600c3654e7d3012623412b9e80d8f92a7bb95/ios/chrome/browser/ui/toolbar/toolbar_coordinator_delegate.h [rename] https://crrev.com/b27600c3654e7d3012623412b9e80d8f92a7bb95/ios/chrome/browser/ui/toolbar/toolbar_mediator.h [rename] https://crrev.com/b27600c3654e7d3012623412b9e80d8f92a7bb95/ios/chrome/browser/ui/toolbar/toolbar_mediator.mm [rename] https://crrev.com/b27600c3654e7d3012623412b9e80d8f92a7bb95/ios/chrome/browser/ui/toolbar/toolbar_mediator_unittest.mm [rename] https://crrev.com/b27600c3654e7d3012623412b9e80d8f92a7bb95/ios/chrome/browser/ui/toolbar/toolbar_progress_bar.h [rename] https://crrev.com/b27600c3654e7d3012623412b9e80d8f92a7bb95/ios/chrome/browser/ui/toolbar/toolbar_progress_bar.mm [modify] https://crrev.com/b27600c3654e7d3012623412b9e80d8f92a7bb95/ios/chrome/test/BUILD.gn [modify] https://crrev.com/b27600c3654e7d3012623412b9e80d8f92a7bb95/ios/chrome/test/earl_grey/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e9d5c35e11dde744a0fff4c268aaa94f57ef2752 commit e9d5c35e11dde744a0fff4c268aaa94f57ef2752 Author: Gauthier Ambard <gambard@chromium.org> Date: Tue Oct 02 09:20:22 2018 [iOS] Remove the LocationBar hint text boolean This CL removes the method allowing the web controller to decide if the location bar needs to display the hint text or not. It keeps the SetShouldShowHintText in the LocationBar for now as I don't know the code well enough to remove all of it. Bug: 374984, 800266 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I3612e999ac7648620db958e0f6913727f3f64c80 Reviewed-on: https://chromium-review.googlesource.com/1245364 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#595768} [modify] https://crrev.com/e9d5c35e11dde744a0fff4c268aaa94f57ef2752/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/e9d5c35e11dde744a0fff4c268aaa94f57ef2752/ios/chrome/browser/ui/location_bar/location_bar_coordinator_unittest.mm [modify] https://crrev.com/e9d5c35e11dde744a0fff4c268aaa94f57ef2752/ios/chrome/browser/ui/location_bar/location_bar_legacy_coordinator.mm [modify] https://crrev.com/e9d5c35e11dde744a0fff4c268aaa94f57ef2752/ios/chrome/browser/ui/omnibox/location_bar_controller.h [modify] https://crrev.com/e9d5c35e11dde744a0fff4c268aaa94f57ef2752/ios/chrome/browser/ui/toolbar/toolbar_coordinator_delegate.h [modify] https://crrev.com/e9d5c35e11dde744a0fff4c268aaa94f57ef2752/ios/web/public/web_state/ui/crw_native_content.h [modify] https://crrev.com/e9d5c35e11dde744a0fff4c268aaa94f57ef2752/ios/web/web_state/ui/crw_web_controller.h [modify] https://crrev.com/e9d5c35e11dde744a0fff4c268aaa94f57ef2752/ios/web/web_state/ui/crw_web_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fb08d63cca6cd5ba0f57f433c5213e3b053d83b7 commit fb08d63cca6cd5ba0f57f433c5213e3b053d83b7 Author: Gauthier Ambard <gambard@chromium.org> Date: Tue Oct 02 09:22:39 2018 [iOS] Move toolbar model to location bar The toolbar model is only used by the location bar. It is called toolbar model to because of the components code. It has nothing to do with the ios/chrome/browser/ui/toolbar. Bug: 800266 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I3161f3bb47ec16e21331266a4e1a2bcfa091b325 Reviewed-on: https://chromium-review.googlesource.com/1246164 Reviewed-by: Mark Cogan <marq@chromium.org> Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#595770} [modify] https://crrev.com/fb08d63cca6cd5ba0f57f433c5213e3b053d83b7/ios/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/fb08d63cca6cd5ba0f57f433c5213e3b053d83b7/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/fb08d63cca6cd5ba0f57f433c5213e3b053d83b7/ios/chrome/browser/ui/location_bar/BUILD.gn [rename] https://crrev.com/fb08d63cca6cd5ba0f57f433c5213e3b053d83b7/ios/chrome/browser/ui/location_bar/toolbar_model_delegate_ios.h [rename] https://crrev.com/fb08d63cca6cd5ba0f57f433c5213e3b053d83b7/ios/chrome/browser/ui/location_bar/toolbar_model_delegate_ios.mm [modify] https://crrev.com/fb08d63cca6cd5ba0f57f433c5213e3b053d83b7/ios/chrome/browser/ui/omnibox_perftest.mm [modify] https://crrev.com/fb08d63cca6cd5ba0f57f433c5213e3b053d83b7/ios/chrome/browser/ui/toolbar/BUILD.gn
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/f9edb3410b49caa9add5378e515727ced6fec216 commit f9edb3410b49caa9add5378e515727ced6fec216 Author: Mark Cogan <marq@google.com> Date: Thu Oct 11 00:51:05 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0e16b79da1951e343022c5f77f7b324f652fb521 commit 0e16b79da1951e343022c5f77f7b324f652fb521 Author: Mark Cogan <marq@google.com> Date: Thu Oct 11 14:08:21 2018 [iOS] Remove voice bar. This CL removes the remaining voice bar support. Bug: 800266 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I9b348cd4360ee692b228f972a6216ebcf8838350 Reviewed-on: https://chromium-review.googlesource.com/c/1251451 Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#598750} [modify] https://crrev.com/0e16b79da1951e343022c5f77f7b324f652fb521/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/0e16b79da1951e343022c5f77f7b324f652fb521/ios/public/provider/chrome/browser/voice/BUILD.gn [delete] https://crrev.com/a552714b72f23e982c897f658011eb12f03f6b82/ios/public/provider/chrome/browser/voice/voice_search_bar.h [delete] https://crrev.com/a552714b72f23e982c897f658011eb12f03f6b82/ios/public/provider/chrome/browser/voice/voice_search_bar_owner.h [modify] https://crrev.com/0e16b79da1951e343022c5f77f7b324f652fb521/ios/public/provider/chrome/browser/voice/voice_search_provider.h [modify] https://crrev.com/0e16b79da1951e343022c5f77f7b324f652fb521/ios/public/provider/chrome/browser/voice/voice_search_provider.mm
Closing this as all the TODO have been removed.
Comment 1 by gambard@chromium.org
, Jan 18 2018