Remove the page header tag in V8
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/e1c85e213d5744011e8856c344a284165734a652 commit e1c85e213d5744011e8856c344a284165734a652 Author: Hannes Payer <hpayer@chromium.org> Date: Tue Jan 09 14:49:11 2018 [heap] Only allow valid inner pointers when calling GcSafeFindCodeForInnerPointer. Bug: chromium:800251 Change-Id: I9cf94a1e17ca12970b5660f0320c02151d7b79a3 Reviewed-on: https://chromium-review.googlesource.com/856637 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#50445} [modify] https://crrev.com/e1c85e213d5744011e8856c344a284165734a652/src/heap/heap.cc
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/f6657e4692fc948343810195535abeedadcf3da9 commit f6657e4692fc948343810195535abeedadcf3da9 Author: Hannes Payer <hpayer@chromium.org> Date: Thu Jan 11 12:45:43 2018 [heap] Replace page header check in store buffer with slower large object lookup. Bug: chromium:800251 Change-Id: I44d997bd54be214c34ca2864470f7cdfc3cc30f3 Reviewed-on: https://chromium-review.googlesource.com/859437 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#50504} [modify] https://crrev.com/f6657e4692fc948343810195535abeedadcf3da9/src/heap/spaces-inl.h [modify] https://crrev.com/f6657e4692fc948343810195535abeedadcf3da9/src/heap/spaces.h [modify] https://crrev.com/f6657e4692fc948343810195535abeedadcf3da9/src/heap/store-buffer.cc
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/6af43874b59a65a5072cc2f32aa81b727cb466e7 commit 6af43874b59a65a5072cc2f32aa81b727cb466e7 Author: Hannes Payer <hpayer@chromium.org> Date: Thu Jan 11 14:49:34 2018 [heap] Remove page header tag from owner field. Bug: chromium:800251 Change-Id: I101131b4651b0bb27a79e5107ee43caf1229ffc7 Reviewed-on: https://chromium-review.googlesource.com/860010 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#50507} [modify] https://crrev.com/6af43874b59a65a5072cc2f32aa81b727cb466e7/src/globals.h [modify] https://crrev.com/6af43874b59a65a5072cc2f32aa81b727cb466e7/src/heap/incremental-marking.cc [modify] https://crrev.com/6af43874b59a65a5072cc2f32aa81b727cb466e7/src/heap/spaces-inl.h [modify] https://crrev.com/6af43874b59a65a5072cc2f32aa81b727cb466e7/src/heap/spaces.cc [modify] https://crrev.com/6af43874b59a65a5072cc2f32aa81b727cb466e7/src/heap/spaces.h [modify] https://crrev.com/6af43874b59a65a5072cc2f32aa81b727cb466e7/test/cctest/heap/test-spaces.cc
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/8d7522bc675c59b55b8115a2933a7d06b278ce28 commit 8d7522bc675c59b55b8115a2933a7d06b278ce28 Author: Adam Klein <adamk@chromium.org> Date: Thu Jan 11 17:56:55 2018 Revert "[heap] Remove page header tag from owner field." This reverts commit 6af43874b59a65a5072cc2f32aa81b727cb466e7. Reason for revert: Linux TSAN failures: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/19028 Original change's description: > [heap] Remove page header tag from owner field. > > Bug: chromium:800251 > Change-Id: I101131b4651b0bb27a79e5107ee43caf1229ffc7 > Reviewed-on: https://chromium-review.googlesource.com/860010 > Commit-Queue: Hannes Payer <hpayer@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#50507} TBR=ulan@chromium.org,hpayer@chromium.org Change-Id: I29001423959f6d9faadbdba5228b28cfb1f5b341 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:800251 Reviewed-on: https://chromium-review.googlesource.com/861923 Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#50512} [modify] https://crrev.com/8d7522bc675c59b55b8115a2933a7d06b278ce28/src/globals.h [modify] https://crrev.com/8d7522bc675c59b55b8115a2933a7d06b278ce28/src/heap/incremental-marking.cc [modify] https://crrev.com/8d7522bc675c59b55b8115a2933a7d06b278ce28/src/heap/spaces-inl.h [modify] https://crrev.com/8d7522bc675c59b55b8115a2933a7d06b278ce28/src/heap/spaces.cc [modify] https://crrev.com/8d7522bc675c59b55b8115a2933a7d06b278ce28/src/heap/spaces.h [modify] https://crrev.com/8d7522bc675c59b55b8115a2933a7d06b278ce28/test/cctest/heap/test-spaces.cc
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/14eec66781926e4bd5cb2f9026e75e0c7966baea commit 14eec66781926e4bd5cb2f9026e75e0c7966baea Author: Hannes Payer <hpayer@chromium.org> Date: Fri Jan 12 13:44:55 2018 [heap] Remove page header tag from owner field. This reverts commit 8d7522bc675c59b55b8115a2933a7d06b278ce28 and fixes the TSAN issue. Bug: chromium:800251 Change-Id: Ie88e5281f7543bb3420703e798416d4a6dbbd91a Reviewed-on: https://chromium-review.googlesource.com/864042 Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#50535} [modify] https://crrev.com/14eec66781926e4bd5cb2f9026e75e0c7966baea/src/globals.h [modify] https://crrev.com/14eec66781926e4bd5cb2f9026e75e0c7966baea/src/heap/incremental-marking.cc [modify] https://crrev.com/14eec66781926e4bd5cb2f9026e75e0c7966baea/src/heap/spaces-inl.h [modify] https://crrev.com/14eec66781926e4bd5cb2f9026e75e0c7966baea/src/heap/spaces.cc [modify] https://crrev.com/14eec66781926e4bd5cb2f9026e75e0c7966baea/src/heap/spaces.h [modify] https://crrev.com/14eec66781926e4bd5cb2f9026e75e0c7966baea/test/cctest/heap/test-spaces.cc
Comment 1 by bugdroid1@chromium.org
, Jan 9 2018