New issue
Advanced search Search tips

Issue 800236 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Jan 2018
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

The PartitionAllocTest.PartialPageFreelists test case in base_unittests crashed on Loongson.

Reported by wangqing...@loongson.cn, Jan 9 2018

Issue description

UserAgent: Mozilla/5.0 (X11; Linux mips64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3096.2 Safari/537.36

Steps to reproduce the problem:
1. build base_unittests
2. run base_unittests

What is the expected behavior?
passed this test case.

What went wrong?
Note: Google Test filter = PartitionAllocTest.PartialPageFreelists
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from PartitionAllocTest
[ RUN      ] PartitionAllocTest.PartialPageFreelists
../../base/allocator/partition_allocator/partition_alloc_unittest.cc:832: Failure
Value of: big_size + kExtraAllocSize
  Actual: 4088
Expected: kSystemPageSize - kAllocationGranularity
Which is: 16376
../../base/allocator/partition_allocator/partition_alloc_unittest.cc:845: Failure
Value of: totalSlots
  Actual: 16
Expected: 4u
Which is: 4
../../base/allocator/partition_allocator/partition_alloc_unittest.cc:851: Failure
Value of: page->num_unprovisioned_slots
  Actual: 11
Expected: 2
../../base/allocator/partition_allocator/partition_alloc_unittest.cc:855: Failure
Value of: page->freelist_head
  Actual: true
Expected: false
../../base/allocator/partition_allocator/partition_alloc_unittest.cc:857: Failure
Value of: page->num_unprovisioned_slots
  Actual: 11
Expected: 2
../../base/allocator/partition_allocator/partition_alloc_unittest.cc:863: Failure
Value of: page->num_unprovisioned_slots
  Actual: 11
Expected: 0
../../base/allocator/partition_allocator/partition_alloc_unittest.cc:867: Failure
Value of: page->freelist_head
  Actual: true
Expected: false
../../base/allocator/partition_allocator/partition_alloc_unittest.cc:869: Failure
Value of: page->num_unprovisioned_slots
  Actual: 11
Expected: 0
../../base/allocator/partition_allocator/partition_alloc_unittest.cc:876: Failure
Value of: page2->num_allocated_slots
  Actual: 5
Expected: 1
Program received signal SIGSEGV, Segmentation fault.
0x000000aaabfaacb8 in PartitionBucketAlloc (bucket=0xaaacbcb630 <(anonymous namespace)::g_tls_metadata+1296>, size=8192, flags=0, 
    root=0xaaacbc3548 <base::(anonymous namespace)::allocator>) at ../../base/allocator/partition_allocator/partition_alloc.h:666
666       void* ret = page->freelist_head;

Did this work before? N/A 

Does this work in other browsers? N/A

Chrome version: 60.0.3096.2  Channel: n/a
OS Version: 
Flash Version:
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c9bbccc0f7df8b238a4059a4e6f5d72ef36e0ea

commit 9c9bbccc0f7df8b238a4059a4e6f5d72ef36e0ea
Author: Wang Qing <wangqing-hf@loongson.cn>
Date: Tue Jan 09 08:10:56 2018

Fix PartitionAlloc test: PartitionAllocTest.PartialPageFreelists crashed on Loongson.

The bug comes from test unit: base_unittests
The crashed case: PartitionAllocTest.PartialPageFreelists

Due to the system pagesize is 16384 on Loongson different from
4096 on other architecturies, such as X86.

Bug:  800236 

R= haraken@chromium.org

Change-Id: Ie1d1ebcb6db70f856fcede1b45b6cb0c0628b263
Reviewed-on: https://chromium-review.googlesource.com/856318
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: 汪 清 <wangqing-hf@loongson.cn>
Cr-Commit-Position: refs/heads/master@{#527933}
[modify] https://crrev.com/9c9bbccc0f7df8b238a4059a4e6f5d72ef36e0ea/base/allocator/partition_allocator/partition_alloc_unittest.cc

Comment 2 Deleted

Status: Fixed (was: Unconfirmed)

Sign in to add a comment