New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 800216 link

Starred by 1 user
Status: WontFix
Owner:
calamity@chromium.org
Closed: Feb 2018
Cc:
█ mgiuca@chromium.org
dominickn@chromium.org
█ bgalbs@google.com
pcovell@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Desktop PWAs: Title-bar buttons should have same dimensions and animations

Project Member Reported by mgiuca@chromium.org, Jan 9 2018 
Chrome Version: 65 (r527850)
OS: Chrome

What steps will reproduce the problem?
(1) Install a Desktop PWA (--enable-features=DesktopPWAWindowing)
(2) Mouse over the Chrome (three-dot) menu.
(3) Mouse over the minimize / maximize / close buttons.

What is the expected result?
They have the same hover target, highlight size and shape.

What happens instead?
The three-dot menu is smaller and has rounded corners. See screenshots.
dpwa-min-button.png
4.1 KB View Download
dpwa-chrome-button.png
4.2 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77e158308530e7e5430092aa5dc3f063bc060548

commit 77e158308530e7e5430092aa5dc3f063bc060548
Author: Christopher Lam <calamity@chromium.org>
Date: Tue Jan 23 01:43:34 2018

Fix Layout in BrowserNonClientFrameViewAsh.

This CL fixes the weird Layout order that the title bar had on Ash. Now
the Layout of the title bar no longer relies on the Layout of the
frame caption buttons.

Bug:  800216 
Change-Id: I7a3678a0dcecf7d68eec95c178633fcc346bd67b
Reviewed-on: https://chromium-review.googlesource.com/870291
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531119}
[modify] https://crrev.com/77e158308530e7e5430092aa5dc3f063bc060548/ash/frame/caption_buttons/frame_caption_button_container_view.cc
[modify] https://crrev.com/77e158308530e7e5430092aa5dc3f063bc060548/ash/frame/caption_buttons/frame_caption_button_container_view.h
[modify] https://crrev.com/77e158308530e7e5430092aa5dc3f063bc060548/ash/frame/default_frame_header.cc
[modify] https://crrev.com/77e158308530e7e5430092aa5dc3f063bc060548/ash/frame/header_view.cc
[modify] https://crrev.com/77e158308530e7e5430092aa5dc3f063bc060548/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/77e158308530e7e5430092aa5dc3f063bc060548/chrome/browser/ui/views/frame/hosted_app_button_container.cc

Comment 2 by mgiuca@chromium.org, Feb 13 2018 

The remainder of this issue is WontFix, isn't it?

Since the three-dot menu is a menu, and the C/M/M buttons are buttons, they should have different styling. WAI?

Comment 3 by calamity@chromium.org, Feb 19 2018

Status: WontFix (was: Assigned)
After the latest round of UI reviews, yes.
►

Sign in to add a comment