Desktop PWAs: Unify "Site settings" and "App info" (or delete App info) |
|||||
Issue descriptionCurrently, we show both "Site settings" and "App info" on the Chrome menu for Desktop PWAs. While these have separate functionality, it's a bit hard for the user to understand what the difference is, and what sort of things are to be found under each of these. Fundamentally, we should just have a single page that shows all the info and controls for a particular app. Overview of the differences: Site settings is: - Per-origin. - Available for any web origin (not just installed apps). - Implemented in Web-UI. - Currently is (only) a permissions management UI for web permissions. App info is: - Per-installed-app (remember, there can be >1 installed app per origin). - Available for any installed app, including PWAs, hosted apps, and packaged apps (so may not correspond to a web origin at all). - Implemented in Views. - Contains options / info for: - Installed size (not really relevant for PWAs). - Open as window vs tab. - Permissions (always blank for PWAs, whose permissions are managed on the web). - Unpin from shelf. - Remove (uninstall). Unifying these two surfaces is difficult due to the fact that there is no 1:1 mapping between origins and apps. Possibly the biggest problem is that App Info contains a "Permissions" section which is blank for PWAs, since permissions are managed on the web, and we should probably start by deleting that. In the long run, we should somehow unify these two. (We could also just delete App info for PWAs, since all of the settings in the dialog are also available on the right-click menu in the launcher.) ???
,
Jan 12 2018
As discussed offline, I think removing the app info dialog entirely, and having a Site-Settings based replacement is an acceptable path forward.
,
Jan 17 2018
And we have agreement on this today. We will also rename "Site Settings" in the UI to "App Info", so we keep the consistent name among all the different types of app. Assigning myself for now.
,
Feb 5 2018
,
Feb 6 2018
App Info for DPWAs should launch the Site Settings page everywhere. A user should never see the Chrome App App Info dialog for DPWAs.
,
Feb 6 2018
Okay, looks like there's three places to update: 1. The three dot menu 2. The chromeOS launcher 3. chrome:apps
,
Feb 7 2018
We plan to have a different dialog for PWA "App Info" to be developed later. We will continue to use the name "Site Settings" for menu items that go to Site Settings.
,
Feb 9 2018
Having "App Info" link to Site Settings is being discussed. Some hosted apps have chrome permissions (e.g. the Web Store) where we should show both site settings and app info. If we are going to have "App Info" link to Site Settings for PWAs then for hosted non-PWAs I propose we include the site settings link in the app info dialog. +hwi: WDYT?
,
Feb 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0c486a8e893b3eaf3bd3801e189eb4d39e8d1ff9 commit 0c486a8e893b3eaf3bd3801e189eb4d39e8d1ff9 Author: Alan Cutter <alancutter@chromium.org> Date: Fri Feb 09 00:11:06 2018 Strip ampersands out of chrome:apps strings This CL is a small refactor CL with no behavioral changes in preparation for adding a new context menu entry to chrome:apps. Strings defined in chrome/app/generated_resources.grd sometimes have ampersand characters not intended for display, we should remove them before displaying the string. Bug: 800205 Change-Id: I2f3c1ddaba35f7627adf29d481b9180d60e00b0e Reviewed-on: https://chromium-review.googlesource.com/905724 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#535584} [modify] https://crrev.com/0c486a8e893b3eaf3bd3801e189eb4d39e8d1ff9/chrome/browser/ui/webui/ntp/ntp_resource_cache.cc
,
Feb 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/004f3b4b4000be325307d1c409a03411aa00beaa commit 004f3b4b4000be325307d1c409a03411aa00beaa Author: Alan Cutter <alancutter@chromium.org> Date: Fri Feb 09 04:35:03 2018 Make "App info" navigate to "Site settings" for bookmark apps in chrome:apps Bookmark apps don't get special Chrome app permissions and it doesn't make sense to display the permissions allocated to them when it will always be none. This CL changes the "App info" context menu entry to go to "Site settings" for the bookmark app's URL. This is inline with our UX mocks for PWAs. Bug: 800205 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I4d4d203aa0cbb8611824ee4090eb7542fdbacc52 Reviewed-on: https://chromium-review.googlesource.com/905725 Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#535645} [modify] https://crrev.com/004f3b4b4000be325307d1c409a03411aa00beaa/chrome/browser/ui/webui/ntp/app_launcher_handler.cc
,
Feb 9 2018
re:c7-9 1. The three dot menu: should open the page info inline https://docs.google.com/presentation/d/1HDXjNMQVuubUdLnS4uF8xdwki4Lo7gSJSZi-VSq2LZ8/edit#slide=id.g32b1e762f8_2_35 Reasoning for 1: This gives immediate access to in-use permissions, Certificate, and Cookies without needing to jump to Site settings. 2. The chromeOS launcher: should open the site settings https://docs.google.com/presentation/d/1HDXjNMQVuubUdLnS4uF8xdwki4Lo7gSJSZi-VSq2LZ8/edit#slide=id.g30da763e24_2_6 Reasoning for 2: The site settings and the page info share and serve common info/function, i.e. permissions, so there's a large similarity. A potential issue of using the menu label "Site settings" instead of "App info" in the context menu of an app icon is that it feels disconnected. Keeping the label "App info" seems more natural in context. We'll keep an eye on how the flow from the menu 'App info' to the site settings feels in the implementation, and optimize it if that doesn't feel right. 3. chrome://apps: are these hosted apps and packaged apps? (and hosted apps are gmail, web store, etc? and packaged apps are Secure Shell, Files app? Please correct me, I don't know them well yet) My recommendation is to scope out this case, and address 1 and 2 for PWAs only. i.e. keep the App Info dialog for non-PWAs as-is. Adding Site Settings for these cases seems to have little benefits. It seems a rare edge case to intend to go to site settings from a hosted app's app icon, and packaged apps don't have associated origins. I might be missing some context in answering the above. So let me know if things should be in other ways. Thanks for working on this Alan!
,
Feb 12 2018
1. All good, Page Info is a good dialog for this purpose. 2. Keeping an eye on the chromeOS launcher sounds good. The current solution does seem a little weird but I don't think there's any major problems. For hosted apps that have special permissions the user can still access site settings via Page Info. 3. chrome://apps is the app launcher for non-chromeOS desktop. It has the same functionality and purpose as the chromeOS launcher AFAIK. Side note: I've been implementing these changes for Bookmark apps as the reasoning applied equally well to them and it's technically simpler, I hope that's okay. (PWAs ⊂ Bookmark apps)
,
Feb 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/61c1f7910f2733ef0f60736f885a60edf62f7052 commit 61c1f7910f2733ef0f60736f885a60edf62f7052 Author: Alan Cutter <alancutter@chromium.org> Date: Mon Feb 12 00:24:13 2018 Make "App info" navigate to "Site settings" for bookmark apps in app launcher Bookmark apps don't get special Chrome app permissions and it doesn't make sense to display the permissions allocated to them when it will always be none. This CL changes the "App info" context menu entry to go to "Site settings" for the bookmark app's URL. This is inline with our UX mocks for PWAs. Bug: 800205 Change-Id: I8e0135836c44bd7c88a22ea87b7bf1526dba14eb Reviewed-on: https://chromium-review.googlesource.com/910329 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#536014} [modify] https://crrev.com/61c1f7910f2733ef0f60736f885a60edf62f7052/chrome/browser/ui/app_list/app_list_controller_delegate.cc [modify] https://crrev.com/61c1f7910f2733ef0f60736f885a60edf62f7052/chrome/browser/ui/chrome_pages.cc [modify] https://crrev.com/61c1f7910f2733ef0f60736f885a60edf62f7052/chrome/browser/ui/chrome_pages.h
,
Feb 12 2018
We now make "App Info" open Site Settings for Bookmark apps from the three dot menu, the chromeOS launcher and chrome://apps. Further changes to "App Info" in the three dot menu are tracked in issue 811178 . |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by mgiuca@chromium.org
, Jan 9 2018