The new tabbed CBD dialog seems to be the default one on Stable (63.0.3239.108 ), and I can't find any Finch config controlling it. When can we: 1) Delete the old code? https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html 2) Delete the feature flag?, https://cs.chromium.org/search/?q=ktabsInCBD&sq=package:chromium&type=cs
Yes, the new dialog shipped in 63. Everything seems to be working fine, so the old code isn't necessary anymore. I will remove it soon.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b7c59483343c54d9dda4eeec48f15d704f7b7466 commit b7c59483343c54d9dda4eeec48f15d704f7b7466 Author: Christian Dullweber <dullweber@chromium.org> Date: Mon Jan 29 11:25:01 2018 Remove kTabsInCBD flag and cleanup code The feature shipped in M63 so the old code is not required anymore. This CL removes the old CBD dialog and the kTabsInCBD flag as well as migration code for preferences. Users that have not been migrated will get default values for selected checkboxes in the basic tab. Bug: 800184 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If9325462be1bf652206b7956d5d25dcfec717078 Reviewed-on: https://chromium-review.googlesource.com/857059 Reviewed-by: Mike West <mkwst@chromium.org> Reviewed-by: James MacLean <wjmaclean@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Reviewed-by: Martin Šrámek <msramek@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#532393} [modify] https://crrev.com/b7c59483343c54d9dda4eeec48f15d704f7b7466/chrome/app/resources/locale_settings.grd [modify] https://crrev.com/b7c59483343c54d9dda4eeec48f15d704f7b7466/chrome/app/settings_strings.grdp [modify] https://crrev.com/b7c59483343c54d9dda4eeec48f15d704f7b7466/chrome/browser/about_flags.cc [modify] https://crrev.com/b7c59483343c54d9dda4eeec48f15d704f7b7466/chrome/browser/android/chrome_feature_list.cc [modify] https://crrev.com/b7c59483343c54d9dda4eeec48f15d704f7b7466/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc [modify] https://crrev.com/b7c59483343c54d9dda4eeec48f15d704f7b7466/chrome/browser/browsing_data/counters/browsing_data_counter_factory.cc [modify] https://crrev.com/b7c59483343c54d9dda4eeec48f15d704f7b7466/chrome/browser/browsing_data/counters/browsing_data_counter_utils.cc [modify] https://crrev.com/b7c59483343c54d9dda4eeec48f15d704f7b7466/chrome/browser/browsing_data/counters/browsing_data_counter_utils.h [modify] https://crrev.com/b7c59483343c54d9dda4eeec48f15d704f7b7466/chrome/browser/browsing_data/counters/site_settings_counter_unittest.cc [modify] https://crrev.com/b7c59483343c54d9dda4eeec48f15d704f7b7466/chrome/browser/content_settings/host_content_settings_map_factory.cc [modify] https://crrev.com/b7c59483343c54d9dda4eeec48f15d704f7b7466/chrome/browser/content_settings/host_content_settings_map_unittest.cc [modify] https://crrev.com/b7c59483343c54d9dda4eeec48f15d704f7b7466/chrome/browser/extensions/api/browsing_data/browsing_data_api.cc [modify] https://crrev.com/b7c59483343c54d9dda4eeec48f15d704f7b7466/chrome/browser/extensions/api/browsing_data/browsing_data_test.cc [delete] https://crrev.com/90cb6716a63971dc8ec61f00415326c9606aa69d/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html [delete] https://crrev.com/90cb6716a63971dc8ec61f00415326c9606aa69d/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js [modify] https://crrev.com/b7c59483343c54d9dda4eeec48f15d704f7b7466/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog_tabs.html [modify] https://crrev.com/b7c59483343c54d9dda4eeec48f15d704f7b7466/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog_tabs.js [modify] https://crrev.com/b7c59483343c54d9dda4eeec48f15d704f7b7466/chrome/browser/resources/settings/clear_browsing_data_dialog/compiled_resources2.gyp [modify] https://crrev.com/b7c59483343c54d9dda4eeec48f15d704f7b7466/chrome/browser/resources/settings/privacy_page/privacy_page.html [modify] https://crrev.com/b7c59483343c54d9dda4eeec48f15d704f7b7466/chrome/browser/resources/settings/privacy_page/privacy_page.js [modify] https://crrev.com/b7c59483343c54d9dda4eeec48f15d704f7b7466/chrome/browser/resources/settings/settings_resources.grd [modify] https://crrev.com/b7c59483343c54d9dda4eeec48f15d704f7b7466/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/b7c59483343c54d9dda4eeec48f15d704f7b7466/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc [modify] https://crrev.com/b7c59483343c54d9dda4eeec48f15d704f7b7466/chrome/browser/ui/zoom/chrome_zoom_level_prefs.cc [modify] https://crrev.com/b7c59483343c54d9dda4eeec48f15d704f7b7466/chrome/common/chrome_features.cc [modify] https://crrev.com/b7c59483343c54d9dda4eeec48f15d704f7b7466/chrome/common/chrome_features.h [modify] https://crrev.com/b7c59483343c54d9dda4eeec48f15d704f7b7466/components/browsing_data/core/browsing_data_utils.cc [modify] https://crrev.com/b7c59483343c54d9dda4eeec48f15d704f7b7466/components/browsing_data/core/browsing_data_utils.h [modify] https://crrev.com/b7c59483343c54d9dda4eeec48f15d704f7b7466/components/browsing_data/core/browsing_data_utils_unittest.cc [modify] https://crrev.com/b7c59483343c54d9dda4eeec48f15d704f7b7466/content/browser/host_zoom_map_impl.cc [modify] https://crrev.com/b7c59483343c54d9dda4eeec48f15d704f7b7466/content/browser/host_zoom_map_impl.h [modify] https://crrev.com/b7c59483343c54d9dda4eeec48f15d704f7b7466/content/browser/host_zoom_map_impl_unittest.cc [modify] https://crrev.com/b7c59483343c54d9dda4eeec48f15d704f7b7466/content/public/browser/host_zoom_map.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0279ee385bdca4a5ff933c37cb50acc4e6aad864 commit 0279ee385bdca4a5ff933c37cb50acc4e6aad864 Author: Christian Dullweber <dullweber@chromium.org> Date: Mon Jan 29 11:45:58 2018 Remove '-tabs' from CBD code Remove the -tabs suffix from CBD code as the old dialog has been removed and the new dialog isn't special anymore. Also remove some footer related code as the footer has been removed. Bug: 800184 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I937e2133feb192eff9f043c5bc060d8296806070 Reviewed-on: https://chromium-review.googlesource.com/873911 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#532398} [rename] https://crrev.com/0279ee385bdca4a5ff933c37cb50acc4e6aad864/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html [rename] https://crrev.com/0279ee385bdca4a5ff933c37cb50acc4e6aad864/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js [modify] https://crrev.com/0279ee385bdca4a5ff933c37cb50acc4e6aad864/chrome/browser/resources/settings/clear_browsing_data_dialog/compiled_resources2.gyp [modify] https://crrev.com/0279ee385bdca4a5ff933c37cb50acc4e6aad864/chrome/browser/resources/settings/privacy_page/privacy_page.html [modify] https://crrev.com/0279ee385bdca4a5ff933c37cb50acc4e6aad864/chrome/browser/resources/settings/settings_resources.grd [modify] https://crrev.com/0279ee385bdca4a5ff933c37cb50acc4e6aad864/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc [modify] https://crrev.com/0279ee385bdca4a5ff933c37cb50acc4e6aad864/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.h [modify] https://crrev.com/0279ee385bdca4a5ff933c37cb50acc4e6aad864/chrome/test/data/webui/settings/privacy_page_test.js
Old code and feature flag have been deleted.
Comment 1 by dpa...@chromium.org
, Jan 9 2018