New issue
Advanced search Search tips

Issue 800181 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

LUCI build view doesn't show the gerrit patchset number

Project Member Reported by iannucci@chromium.org, Jan 9 2018

Issue description

Comment 1 by efoo@chromium.org, Jan 9 2018

Labels: LUCI-M0-Backlog
Is this limited to Buildbot builds in Milo or does LUCI bot builds also lack the Gerrit CL info? Marking for backlog for the time being.

If this is a limitation in Milo Buildbot only, we should punt this as "working as intended" and push towards LUCI bots.
Owner: tandrii@chromium.org
Status: Assigned (was: Untriaged)
Summary: LUCI build view doesn't show the gerrit patchset number (was: LUCI buildbot view doesn't show the gerrit patchset number)
bad title. This is a regression vs buildbot in pure LUCI. I've actually fixed it for buildbot builds in LUCI, but forgot to fix in swarmbucket builds in LUCI.
Status: Started (was: Assigned)
https://chromium-review.googlesource.com/#/c/855822/
Labels: -Type-Bug -Pri-3 Pri-2 Type-Bug-Regression

Comment 5 by efoo@chromium.org, Jan 9 2018

Labels: REQBY-LUCI-Afterglow
Marking with known issue label. This is low pri but a regression, so we should get to this before afterglow. 

Project Member

Comment 6 by bugdroid1@chromium.org, Jan 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/480253140ea8bd0b3e65773792a327037c2f90ee

commit 480253140ea8bd0b3e65773792a327037c2f90ee
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Tue Jan 09 03:42:39 2018

Milo: add gerrit patchset numbers to swarmbucket builds.

R=hinoka

Bug:  800181 
Change-Id: I482e7ae8344ffe3fb21143e6302948788565a973
Reviewed-on: https://chromium-review.googlesource.com/855822
Reviewed-by: Erik Staab <estaab@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/480253140ea8bd0b3e65773792a327037c2f90ee/milo/buildsource/buildbucket/builder.go
[modify] https://crrev.com/480253140ea8bd0b3e65773792a327037c2f90ee/milo/buildsource/buildbucket/expectations/master.tryserver.infra/InfraPresubmit.Swarming.json

Owner: hinoka@chromium.org
Status: Assigned (was: Started)
Back to Ryan to update status once new Milo is deployed. I think this should be fixed now.

Comment 8 by efoo@chromium.org, Jan 30 2018

Labels: LUCI-Backlog

Comment 9 by efoo@chromium.org, Jan 30 2018

Labels: -LUCI-M0-Backlog

Comment 10 by efoo@chromium.org, Feb 28 2018

Ryan? 
Cc: -tandrii@chromium.org hinoka@chromium.org
Owner: tandrii@chromium.org
Status: Fixed (was: Assigned)

Comment 12 by no...@chromium.org, Feb 28 2018

Status: Assigned (was: Fixed)
Still no patchset number in https://ci.chromium.org/p/chromium/builders/luci.chromium.try/chromium_presubmit/45899
Status: Started (was: Assigned)
hm, yet another code rendering path :( Let's see.
I de-copy-pastified patchset handling in MILO https://chromium-review.googlesource.com/c/940770/ 

Comment 15 by efoo@chromium.org, Mar 1 2018

Labels: -LUCI-Backlog LUCI-Chromium
Project Member

Comment 16 by bugdroid1@chromium.org, Mar 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/f18b39f05d308aa5a34d05a5a9b02555690e72c4

commit f18b39f05d308aa5a34d05a5a9b02555690e72c4
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Sat Mar 03 01:51:17 2018

Milo: refactor patch link generation once and for all.

R=hinoka@chromium.org, nodir@chromium.org

Bug:  800181 
Change-Id: Ib1cf3877921fe2eb673a07a7a6eac5f798af94c5
Reviewed-on: https://chromium-review.googlesource.com/940770
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>

[modify] https://crrev.com/f18b39f05d308aa5a34d05a5a9b02555690e72c4/milo/buildsource/buildbot/build.go
[modify] https://crrev.com/f18b39f05d308aa5a34d05a5a9b02555690e72c4/milo/buildsource/buildbot/expectations/chromium_presubmit.426944.build.json
[modify] https://crrev.com/f18b39f05d308aa5a34d05a5a9b02555690e72c4/milo/buildsource/buildbot/expectations/gerritCL.1234.build.json
[modify] https://crrev.com/f18b39f05d308aa5a34d05a5a9b02555690e72c4/milo/buildsource/buildbot/expectations/win_chromium_rel_ng.246309.build.json
[modify] https://crrev.com/f18b39f05d308aa5a34d05a5a9b02555690e72c4/milo/buildsource/buildbucket/builder.go
[modify] https://crrev.com/f18b39f05d308aa5a34d05a5a9b02555690e72c4/milo/buildsource/buildbucket/expectations/master.tryserver.infra/InfraPresubmit.Swarming.json
[modify] https://crrev.com/f18b39f05d308aa5a34d05a5a9b02555690e72c4/milo/buildsource/swarming/build.go
[modify] https://crrev.com/f18b39f05d308aa5a34d05a5a9b02555690e72c4/milo/buildsource/swarming/expectations/build-expired.json
[modify] https://crrev.com/f18b39f05d308aa5a34d05a5a9b02555690e72c4/milo/buildsource/swarming/expectations/build-gerrit.json
[modify] https://crrev.com/f18b39f05d308aa5a34d05a5a9b02555690e72c4/milo/frontend/expectations/buildbot.build-Debug_page-_chromium_presubmit_426944.html
[modify] https://crrev.com/f18b39f05d308aa5a34d05a5a9b02555690e72c4/milo/frontend/expectations/buildbot.build-Debug_page-_gerritCL_1234.html
[modify] https://crrev.com/f18b39f05d308aa5a34d05a5a9b02555690e72c4/milo/frontend/expectations/buildbot.build-Debug_page-_win_chromium_rel_ng_246309.html
[modify] https://crrev.com/f18b39f05d308aa5a34d05a5a9b02555690e72c4/milo/frontend/expectations/swarming.build-build-expired.html
[modify] https://crrev.com/f18b39f05d308aa5a34d05a5a9b02555690e72c4/milo/frontend/expectations/swarming.build-build-gerrit.html
[modify] https://crrev.com/f18b39f05d308aa5a34d05a5a9b02555690e72c4/milo/frontend/ui/build.go

Comment 17 by efoo@chromium.org, Mar 3 2018

Labels: -REQBY-LUCI-Afterglow
Status: Fixed (was: Started)

Sign in to add a comment