New issue
Advanced search Search tips

Issue 800176 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocked on:
issue 775530



Sign in to add a comment

Add instrumentation tests for subresource_filter and the Ads setting

Project Member Reported by csharrison@chromium.org, Jan 9 2018

Issue description

This feature does not have sufficient end to end coverage on Android. First, we need to set up e2e coverage of Safe Browsing.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/50b1a523fe51cd837489b4a657214c3740deb193

commit 50b1a523fe51cd837489b4a657214c3740deb193
Author: Charles Harrison <csharrison@chromium.org>
Date: Fri Jan 19 22:55:57 2018

SubresourceFilter instrumentation test harness

This CL adds some simple tests to the SubresourceFilter in filtering
ads on sites violating the better ads standard.

Followups will include tests for other android-specific features like UI.

Bug: 800176
Change-Id: I28a1c8c7af4a2646ddf9572c2560d6cf43c18f3a
Reviewed-on: https://chromium-review.googlesource.com/857656
Reviewed-by: Shivani Sharma <shivanisha@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530644}
[add] https://crrev.com/50b1a523fe51cd837489b4a657214c3740deb193/chrome/android/java/src/org/chromium/chrome/browser/subresource_filter/TestSubresourceFilterPublisher.java
[modify] https://crrev.com/50b1a523fe51cd837489b4a657214c3740deb193/chrome/android/java_sources.gni
[add] https://crrev.com/50b1a523fe51cd837489b4a657214c3740deb193/chrome/android/javatests/src/org/chromium/chrome/browser/SubresourceFilterTest.java
[modify] https://crrev.com/50b1a523fe51cd837489b4a657214c3740deb193/chrome/browser/BUILD.gn
[add] https://crrev.com/50b1a523fe51cd837489b4a657214c3740deb193/chrome/browser/android/subresource_filter/test_subresource_filter_publisher.cc
[add] https://crrev.com/50b1a523fe51cd837489b4a657214c3740deb193/chrome/test/data/android/subresource_filter/page-with-img.html
[modify] https://crrev.com/50b1a523fe51cd837489b4a657214c3740deb193/components/subresource_filter/content/browser/content_ruleset_service.cc
[modify] https://crrev.com/50b1a523fe51cd837489b4a657214c3740deb193/components/subresource_filter/content/browser/content_ruleset_service.h
[modify] https://crrev.com/50b1a523fe51cd837489b4a657214c3740deb193/components/subresource_filter/core/browser/ruleset_service.h

Project Member

Comment 2 by bugdroid1@chromium.org, Jan 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5bf341b89fe3181aa68766d22f28b715d8aabf8

commit c5bf341b89fe3181aa68766d22f28b715d8aabf8
Author: Charles Harrison <csharrison@chromium.org>
Date: Fri Jan 26 17:59:37 2018

[subresource_filter] Add more instrumentation tests for the infobar

This CL adds tests for:
1. Infobar existence
2. Clicking "learn more" on the infobar
3. Clicking the checkbox and reloading the site
4. Closing the infobar

Bug: 800176
Change-Id: I4cf28352c182320bcec5c9e6e8e53cd2c30d02d2
Reviewed-on: https://chromium-review.googlesource.com/886743
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Shivani Sharma <shivanisha@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532001}
[modify] https://crrev.com/c5bf341b89fe3181aa68766d22f28b715d8aabf8/chrome/android/javatests/src/org/chromium/chrome/browser/SubresourceFilterTest.java

Sign in to add a comment