New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 800170 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 17
Cc:
Components:
EstimatedDays: ----
NextAction: 2019-01-22
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Feature



Sign in to add a comment

Support ddljson without image

Project Member Reported by sfiera@google.com, Jan 9 2018

Issue description

Interactive doodles now no longer return a CTA image, by design. However, LogoTracker interprets (have logo && don't have image) as an image decoding failure.

We need to:
* Add extra code to distinguish decoding failure from absence of image
* Stop checking that we have an image, when there is a Doodle
* Get LogoCache to properly cache a Doodle without an image
* Make sure that we don't introduce regressions on mobile, where the image is always expected to be present if there is a Doodle.
 

Comment 1 by sfiera@google.com, Jan 9 2018

Labels: -zine-ntp-local-doodles zine-local-ntp-doodles
Labels: Needs-Feedback
Is this happening for 65?

Comment 3 by sfiera@chromium.org, Jan 18 2018

Labels: -Pri-1 -M-65 Pri-3
Labels: zine-triaged

Comment 5 by treib@chromium.org, Feb 14 2018

sfiera, should we WontFix this? IIRC we decided not to go with this approach after all.

Comment 6 by sfiera@chromium.org, Feb 14 2018

I was mistaken in the original description, in that interactive doodles still include a CTA. We still anticipate that (one day) it would make sense to not include it, though. I think open/P3 matches that, but it might be better to rephrase the bug to match the goal (“Don’t download interactive CTA if it won’t be shown” or something).
Owner: ----
Status: Available (was: Started)
(not working on client-side Chrome any more)

Comment 8 by treib@chromium.org, May 8 2018

Cc: -treib@chromium.org
Labels: -Needs-Feedback Type-Feature
Blockedon: 851187
Labels: NTPDoodle
Need to evaluate whether this applies to doodles on the Local NTP.
Cc: ramyan@chromium.org
Owner: kmilka@chromium.org
Status: Assigned (was: Available)
It looks like everything here works. We're just doing some extra work by downloading an image that's never used, which would take a bit of refactoring to eliminate?
Yes, I believe that's correct: For interactive Doodles, we download, decode etc. an image that's never used. Since that's not particularly bad, and interactive Doodles are somewhat rare anyway, this is not very urgent. Would still be nice to fix eventually.
(Video Doodles are also implemented as interactives, so they're not *that* rare.)
Blockedon: -851187
NextAction: 2019-01-22
Status: Started (was: Assigned)
While debugging today's Doodle we discovered that the Doodle team's testing sandboxes don't include the image (data_uri field) for interactive doodles. 
Labels: KR-NTP-Architecture-Local O-Optimal-NTP-Architecture
Project Member

Comment 15 by bugdroid1@chromium.org, Jan 17 (5 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf7b0cb7ff8897c1e1160c48dc2dcfca0c37329e

commit bf7b0cb7ff8897c1e1160c48dc2dcfca0c37329e
Author: Kyle Milka <kmilka@chromium.org>
Date: Thu Jan 17 19:07:41 2019

Allow ddljson response to not contain an image

Interactive doodles don't use the image (data_uri field) included
in the ddljson response. Don't require that responses (on Desktop)
contain an image. Allow logo_cache to cache a doodle that doesn't
include an image.

Bug:  800170 
Change-Id: I637ab2130db29efadecebd787c244e59008d3e63
Reviewed-on: https://chromium-review.googlesource.com/c/1405431
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623783}
[modify] https://crrev.com/bf7b0cb7ff8897c1e1160c48dc2dcfca0c37329e/chrome/browser/resources/local_ntp/doodles.js
[modify] https://crrev.com/bf7b0cb7ff8897c1e1160c48dc2dcfca0c37329e/chrome/browser/search/local_ntp_source.cc
[modify] https://crrev.com/bf7b0cb7ff8897c1e1160c48dc2dcfca0c37329e/chrome/browser/ui/search/local_ntp_doodle_browsertest.cc
[modify] https://crrev.com/bf7b0cb7ff8897c1e1160c48dc2dcfca0c37329e/components/search_provider_logos/google_logo_api_unittest.cc
[modify] https://crrev.com/bf7b0cb7ff8897c1e1160c48dc2dcfca0c37329e/components/search_provider_logos/logo_cache.cc
[modify] https://crrev.com/bf7b0cb7ff8897c1e1160c48dc2dcfca0c37329e/components/search_provider_logos/logo_cache_unittest.cc
[modify] https://crrev.com/bf7b0cb7ff8897c1e1160c48dc2dcfca0c37329e/components/search_provider_logos/logo_service_impl.cc
[modify] https://crrev.com/bf7b0cb7ff8897c1e1160c48dc2dcfca0c37329e/components/search_provider_logos/logo_service_impl.h
[modify] https://crrev.com/bf7b0cb7ff8897c1e1160c48dc2dcfca0c37329e/tools/metrics/histograms/enums.xml

Comment 16 by kmilka@chromium.org, Jan 17 (5 days ago)

Status: Fixed (was: Started)

Comment 17 by monor...@bugs.chromium.org, Yesterday (28 hours ago)

The NextAction date has arrived: 2019-01-22
Project Member

Comment 18 by bugdroid1@chromium.org, Today (22 hours ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f630b0d3526a18552fe41cf72bfec465b68ed6b8

commit f630b0d3526a18552fe41cf72bfec465b68ed6b8
Author: Kyle Milka <kmilka@chromium.org>
Date: Tue Jan 22 17:31:11 2019

Revert "Allow ddljson response to not contain an image"

This reverts commit bf7b0cb7ff8897c1e1160c48dc2dcfca0c37329e.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Allow ddljson response to not contain an image
> 
> Interactive doodles don't use the image (data_uri field) included
> in the ddljson response. Don't require that responses (on Desktop)
> contain an image. Allow logo_cache to cache a doodle that doesn't
> include an image.
> 
> Bug:  800170 
> Change-Id: I637ab2130db29efadecebd787c244e59008d3e63
> Reviewed-on: https://chromium-review.googlesource.com/c/1405431
> Commit-Queue: Kyle Milka <kmilka@chromium.org>
> Reviewed-by: Marc Treib <treib@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#623783}

TBR=treib@chromium.org,kmilka@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  800170 
Change-Id: Ided4301b88586d21cbb653aefaf75206aa6d2c5d
Reviewed-on: https://chromium-review.googlesource.com/c/1426879
Reviewed-by: Kyle Milka <kmilka@chromium.org>
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624813}
[modify] https://crrev.com/f630b0d3526a18552fe41cf72bfec465b68ed6b8/chrome/browser/resources/local_ntp/doodles.js
[modify] https://crrev.com/f630b0d3526a18552fe41cf72bfec465b68ed6b8/chrome/browser/search/local_ntp_source.cc
[modify] https://crrev.com/f630b0d3526a18552fe41cf72bfec465b68ed6b8/chrome/browser/ui/search/local_ntp_doodle_browsertest.cc
[modify] https://crrev.com/f630b0d3526a18552fe41cf72bfec465b68ed6b8/components/search_provider_logos/google_logo_api_unittest.cc
[modify] https://crrev.com/f630b0d3526a18552fe41cf72bfec465b68ed6b8/components/search_provider_logos/logo_cache.cc
[modify] https://crrev.com/f630b0d3526a18552fe41cf72bfec465b68ed6b8/components/search_provider_logos/logo_cache_unittest.cc
[modify] https://crrev.com/f630b0d3526a18552fe41cf72bfec465b68ed6b8/components/search_provider_logos/logo_service_impl.cc
[modify] https://crrev.com/f630b0d3526a18552fe41cf72bfec465b68ed6b8/components/search_provider_logos/logo_service_impl.h
[modify] https://crrev.com/f630b0d3526a18552fe41cf72bfec465b68ed6b8/tools/metrics/histograms/enums.xml

Sign in to add a comment