New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 800131 link

Starred by 1 user
Status: Fixed
Owner:
█ thanhdle@chromium.org
Last visit > 30 days ago
Closed: Jan 2018
Cc:
bengr@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Refactor expand/collapse all log method chrome://interventions-internals

Project Member Reported by thanhdle@chromium.org, Jan 8 2018 
The expandAllLogs and collapseAllLogs are basically identical.

https://cs.chromium.org/chromium/src/chrome/browser/resources/interventions_internals/index.js?type=cs&q=index.js+interventions+expandAllLogs&sq=package:chromium&l=115

Also need to check for rows[i - 1].querySelector('.arrow') before accessing the className attribute.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 9 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7c1d8f8a1d46dcf1cdfd825d95d0949edd2d978

commit b7c1d8f8a1d46dcf1cdfd825d95d0949edd2d978
Author: Thanh Le <thanhdle@chromium.org>
Date: Tue Jan 09 07:21:43 2018

Refactor expandAllLogs and collapseAllLog method.

Added checks when selecting the arrow button before accessing the
className attribute.

Combine the two methods into one with a parameter indicating the type of
operation.

Bug:  800131 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Idff8c54055b234dd060217665d2bb9fd1ac7933a
Reviewed-on: https://chromium-review.googlesource.com/855240
Commit-Queue: Thanh Le <thanhdle@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527924}
[modify] https://crrev.com/b7c1d8f8a1d46dcf1cdfd825d95d0949edd2d978/chrome/browser/resources/interventions_internals/index.js

Comment 2 by thanhdle@chromium.org, Jan 9 2018

Status: Fixed (was: Started)
►

Sign in to add a comment