New issue
Advanced search Search tips

Issue 800128 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Autofill - expiration month dropdown

Project Member Reported by parastoog@chromium.org, Jan 8 2018

Issue description

For some websites the expiration month doesn’t get filled if it's a dropdown.

Examples:

freepeople.com (Desktop), Home Depot (Desktop).

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b24973e9cfafeb5c2240bb9142798a37eba8eee

commit 5b24973e9cfafeb5c2240bb9142798a37eba8eee
Author: Parastoo Geranmayeh <parastoog@google.com>
Date: Tue Jan 09 20:21:25 2018

[Autofill] Fill exp month w/ value (not content.)

Problem:

For some websites the expiration date (month) doesn’t get filled
(if it’s a dropdown.)

Solution:

When filling dropdowns, we should not set the value to content but to
the value.

Tests added.

Fixes: freepeople.com (Desktop), Home Depot (Desktop), and etc.


Bug:  800128 
Change-Id: Ic74473dd3744daa645d0b81196eb4109561d5ad8
Reviewed-on: https://chromium-review.googlesource.com/854733
Commit-Queue: Parastoo Geranmayeh <parastoog@google.com>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528086}
[modify] https://crrev.com/5b24973e9cfafeb5c2240bb9142798a37eba8eee/components/autofill/core/browser/field_filler.cc
[modify] https://crrev.com/5b24973e9cfafeb5c2240bb9142798a37eba8eee/components/autofill/core/browser/field_filler_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment