MoblabVMTestStage: Ensure that the test scheduled inside moblab VM is actually run. |
|||||
Issue descriptionEnsure that the test scheduled inside moblab VM is actually run. run_suite (by design!) returns success if there are no hosts for the given job dependencies. This means that if the dut VM doesn't boot, run_suite in the moblab vm simply succeeds. This is wrong. Example build: https://uberchromegw.corp.google.com/i/chromiumos/builders/moblab-generic-vm-paladin/builds/511
,
Jan 9 2018
,
Jan 9 2018
,
Jan 9 2018
Actually, this wasn't a case of unavailable hosts. That message seems to be printed each time :( So, this is CL is useless: https://chromium-review.googlesource.com/#/c/chromiumos/chromite/+/855580 The problem is here: https://pantheon.corp.google.com/storage/browser/chromeos-image-archive/moblab-generic-vm-paladin/R65-10289.0.0-rc3/moblab_vm_test_results/results-1-moblab_DummyServerNoSspSuite/sysinfo/mnt/moblab/results/1-moblab/hostless/debug/ 01/08 01:14:07.886 DEBUG| suite:0876| Getting control file list for suite: dummy_server_nossp 01/08 01:14:07.925 WARNI| suite:0581| Skipping server/site_tests/dummy_PassServer/control.nossp Error parsing data because invalid syntax (line 1) 01/08 01:14:07.925 DEBUG| suite:0882| Parsed 0 control files. So, no test was scheduled because we failed to parse the control file for it! I seem to remember seeing this before.
,
Jan 9 2018
https://chromium-review.googlesource.com/c/chromiumos/chromite/+/855580
,
Jan 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/054c58c54581285025b95463049f24ae5d79fae4 commit 054c58c54581285025b95463049f24ae5d79fae4 Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Wed Jan 10 08:10:52 2018 cbuildbot: Validate individual test in MoblabVMTestStage We've seen instances of moblab's internal run_suite succeeding even when it failed to schedule any tests. This can happen if the suite determines that all tests have unmet dependencies, or if it determines that the test's control file has a syntax error! While we work on those weird habits of run_suite, actually validate that the requested test ran and passed inside moblab's run_suite. BUG= chromium:800102 TEST=moblab-generic-vm-pre-cq Change-Id: I3fa66a66342579c62993b1a4bf2f50a3c4147d56 Reviewed-on: https://chromium-review.googlesource.com/855580 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/054c58c54581285025b95463049f24ae5d79fae4/cbuildbot/stages/vm_test_stages.py [modify] https://crrev.com/054c58c54581285025b95463049f24ae5d79fae4/cbuildbot/stages/vm_test_stages_unittest.py
,
Jan 11 2018
,
Jan 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/8587d1f292abd1291f4657cd8f86634a997957dc commit 8587d1f292abd1291f4657cd8f86634a997957dc Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Fri Jan 12 03:37:38 2018 Add some context in control parsing error. We get this cryptic error every once in a while in dynamic_suite: Error parsing data because invalid syntax (line 1) But, it doesn't tell us what the control file was anywhere. So, tell us. BUG= chromium:800102 TEST=unittests Change-Id: Ice1471d3d72907d02df9969c617fa185c9fa9320 Reviewed-on: https://chromium-review.googlesource.com/855586 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Xixuan Wu <xixuan@chromium.org> [modify] https://crrev.com/8587d1f292abd1291f4657cd8f86634a997957dc/client/common_lib/control_data.py |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by pprabhu@chromium.org
, Jan 8 2018Labels: -Pri-3 Pri-1